Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479398 > unrolled thread

[PATCH] phy: rockchip-typec: add pm_runtime_disable in err case

Back to article view | Back to linux.kernel

Contents

  [PATCH] phy: rockchip-typec: add pm_runtime_disable in err case Chris Zhong <zyw@rock-chips.com> - 2016-09-08 19:40 +0200
    Re: [PATCH] phy: rockchip-typec: add pm_runtime_disable in err case Brian Norris <briannorris@chromium.org> - 2016-09-08 20:10 +0200

#1479398 — [PATCH] phy: rockchip-typec: add pm_runtime_disable in err case

Add pm_runtime_disable in err case to make the pm_runtime_enable/disable
is invoked balanced.

Signed-off-by: Chris Zhong <zyw@rock-chips.com>

---

 drivers/phy/phy-rockchip-typec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/phy-rockchip-typec.c b/drivers/phy/phy-rockchip-typec.c
index 7cfb0f8..dd257c7 100644
--- a/drivers/phy/phy-rockchip-typec.c
+++ b/drivers/phy/phy-rockchip-typec.c
@@ -977,6 +977,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
 		if (IS_ERR(phy)) {
 			dev_err(dev, "failed to create phy: %s\n",
 				child_np->name);
+			pm_runtime_disable(dev);
 			return PTR_ERR(phy);
 		}
 
@@ -986,6 +987,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
 	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
 	if (IS_ERR(phy_provider)) {
 		dev_err(dev, "Failed to register phy provider\n");
+		pm_runtime_disable(dev);
 		return PTR_ERR(phy_provider);
 	}
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1479410

On Thu, Sep 08, 2016 at 10:38:11AM -0700, Chris Zhong wrote:
> Add pm_runtime_disable in err case to make the pm_runtime_enable/disable
> is invoked balanced.
> 
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>

Makes sense.

Reviewed-by: Brian Norris <briannorris@chromium.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web