Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478934 > unrolled thread

[PATCH] staging/lustre/lov: add missing header dependencies

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging/lustre/lov: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-08 10:50 +0200
    Re: [PATCH] staging/lustre/lov: add missing header dependencies James Simmons <jsimmons@infradead.org> - 2016-09-08 20:00 +0200

#1478934 — [PATCH] staging/lustre/lov: add missing header dependencies

We get 1 warning when building kernel with W=1:
drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]

In fact, these functions are declared in ../llite/vvp_internal.h,
so this patch add missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
index f9621b0..912c416 100644
--- a/drivers/staging/lustre/lustre/lov/lov_object.c
+++ b/drivers/staging/lustre/lustre/lov/lov_object.c
@@ -38,6 +38,7 @@
 #define DEBUG_SUBSYSTEM S_LOV
 
 #include "lov_cl_internal.h"
+#include "../llite/vvp_internal.h"
 
 /** \addtogroup lov
  *  @{
-- 
2.7.4

[toc] | [next] | [standalone]

#1479407

> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Nak. The header vvp_internal.h is meant to private to the llite layer.
Looking at the coming patch updates I see lov_lsm_[put|get] will not be
used in the lov later. Now lov_read_and_clear_async is still used in
both layers. The header used for this case is cl_object.h. Might rename 
that function to be consistent with the rest of the header. I will look 
into a cleanup for this.

> ---
>  drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
>  #define DEBUG_SUBSYSTEM S_LOV
>  
>  #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>  
>  /** \addtogroup lov
>   *  @{
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web