Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480658 > unrolled thread
| Started by | Sean Fu <fxinrong@gmail.com> |
|---|---|
| First post | 2016-09-10 18:00 +0200 |
| Last post | 2016-09-10 18:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree. Sean Fu <fxinrong@gmail.com> - 2016-09-10 18:00 +0200
Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree. Jeff Mahoney <jeffm@suse.com> - 2016-09-10 18:10 +0200
| From | Sean Fu <fxinrong@gmail.com> |
|---|---|
| Date | 2016-09-10 18:00 +0200 |
| Subject | Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree. |
| Message-ID | <sfSRc-252-15@gated-at.bofh.it> |
On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: > On 9/8/16 11:08 PM, Sean Fu wrote: > > On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > >> On 9/6/16 5:58 AM, David Sterba wrote: > >>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > >>>>>> Since root is only used to get fs_info->chunk_root, why not use fs_info > >>>>>> directly? > >>>>> > >>>>> Weird. Exactly this was a part of my fs_info patchset. I guess I need > >>>>> to go back and check what else is missing. > >>>> > >>>> Actually, most of this didn't land. Pretty much anything that's a root > >>>> ->fs_info conversion is in there. > >>> > >>> Only half of the patchset has been merged so far because it did not pass > >>> testing, so I bisected to some point. I was about to let you know once > >>> most of 4.9 patches are prepared so there are less merge conflicts. > >> > >> Ok, thanks. I was going to start the rebase today but I'll hold off > >> until you're set for 4.9. > >> > > Hi Jeff, Could you please share your patch? Where can i get it? > > I wanna have a look at it. > > Sure, it's the whole series that starts with this commit: > commit 160ceedfd40085cfb1e08305917fcc24cefdad93 > Author: Jeff Mahoney <jeffm@suse.com> > Date: Wed Aug 31 23:55:33 2016 -0400 > > btrfs: add dynamic debug support > > ... I still need to do clean up some commits that need merging. > > https://git.kernel.org/cgit/linux/kernel/git/jeffm/linux-btrfs.git/log/?h=btrfs-testing/kdave/misc-4.9/root-fsinfo-cleanup > Nice work. Thanks for your explaination. I have one more question about it. Although the total text size of this function is not changed, using fs_info should need one more instruction to get chunk_root field of fs_info than using chunk_root directly. Does it cause any performance impact? Sean > -Jeff > > > > Thanks > >> -Jeff > >> > >> -- > >> Jeff Mahoney > >> SUSE Labs > >> > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > Jeff Mahoney > SUSE Labs >
[toc] | [next] | [standalone]
| From | Jeff Mahoney <jeffm@suse.com> |
|---|---|
| Date | 2016-09-10 18:10 +0200 |
| Message-ID | <sfT0S-2o0-9@gated-at.bofh.it> |
| In reply to | #1480658 |
[Multipart message — attachments visible in raw view] — view raw
On 9/10/16 11:58 AM, Sean Fu wrote: > On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: >> On 9/8/16 11:08 PM, Sean Fu wrote: >>> On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: >>>> On 9/6/16 5:58 AM, David Sterba wrote: >>>>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: >>>>>>>> Since root is only used to get fs_info->chunk_root, why not use fs_info >>>>>>>> directly? >>>>>>> >>>>>>> Weird. Exactly this was a part of my fs_info patchset. I guess I need >>>>>>> to go back and check what else is missing. >>>>>> >>>>>> Actually, most of this didn't land. Pretty much anything that's a root >>>>>> ->fs_info conversion is in there. >>>>> >>>>> Only half of the patchset has been merged so far because it did not pass >>>>> testing, so I bisected to some point. I was about to let you know once >>>>> most of 4.9 patches are prepared so there are less merge conflicts. >>>> >>>> Ok, thanks. I was going to start the rebase today but I'll hold off >>>> until you're set for 4.9. >>>> >>> Hi Jeff, Could you please share your patch? Where can i get it? >>> I wanna have a look at it. >> >> Sure, it's the whole series that starts with this commit: >> commit 160ceedfd40085cfb1e08305917fcc24cefdad93 >> Author: Jeff Mahoney <jeffm@suse.com> >> Date: Wed Aug 31 23:55:33 2016 -0400 >> >> btrfs: add dynamic debug support >> >> ... I still need to do clean up some commits that need merging. >> >> https://git.kernel.org/cgit/linux/kernel/git/jeffm/linux-btrfs.git/log/?h=btrfs-testing/kdave/misc-4.9/root-fsinfo-cleanup >> > Nice work. Thanks for your explaination. > I have one more question about it. > Although the total text size of this function is not changed, using > fs_info should need one more instruction to get chunk_root field of > fs_info than using chunk_root directly. > Does it cause any performance impact? I doubt it. The caller had to do the dereference before. -Jeff > Sean >> -Jeff >> >> >>> Thanks >>>> -Jeff >>>> >>>> -- >>>> Jeff Mahoney >>>> SUSE Labs >>>> >>> >>> >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> >> -- >> Jeff Mahoney >> SUSE Labs >> > > > > -- Jeff Mahoney SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web