Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1479105 > unrolled thread
| Started by | Andy Yan <andy.yan@rock-chips.com> |
|---|---|
| First post | 2016-09-08 13:10 +0200 |
| Last post | 2016-09-08 16:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] arm64: rockchip: fix i2c resource describe error of rk3368 Andy Yan <andy.yan@rock-chips.com> - 2016-09-08 13:10 +0200
Re: [PATCH] arm64: rockchip: fix i2c resource describe error of rk3368 Heiko Stuebner <heiko@sntech.de> - 2016-09-08 16:40 +0200
| From | Andy Yan <andy.yan@rock-chips.com> |
|---|---|
| Date | 2016-09-08 13:10 +0200 |
| Subject | [PATCH] arm64: rockchip: fix i2c resource describe error of rk3368 |
| Message-ID | <sf5nt-53y-43@gated-at.bofh.it> |
According to the TRM and downstream code from rockchip, the register
address of i2c1 on rk3368 is 0xff660000 and i2c2 is 0xff140000.
This patch fix the i2c1 & i2c2 register address definition error, also
fix the clk and pinctrl reference error.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3368.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
index 0fcb214..2f8e19f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
@@ -315,16 +315,16 @@
status = "disabled";
};
- i2c1: i2c@ff140000 {
+ i2c2: i2c@ff140000 {
compatible = "rockchip,rk3368-i2c", "rockchip,rk3288-i2c";
reg = <0x0 0xff140000 0x0 0x1000>;
interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
clock-names = "i2c";
- clocks = <&cru PCLK_I2C1>;
+ clocks = <&cru PCLK_I2C2>;
pinctrl-names = "default";
- pinctrl-0 = <&i2c1_xfer>;
+ pinctrl-0 = <&i2c2_xfer>;
status = "disabled";
};
@@ -554,16 +554,16 @@
status = "disabled";
};
- i2c2: i2c@ff660000 {
+ i2c1: i2c@ff660000 {
compatible = "rockchip,rk3368-i2c", "rockchip,rk3288-i2c";
reg = <0x0 0xff660000 0x0 0x1000>;
interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
clock-names = "i2c";
- clocks = <&cru PCLK_I2C2>;
+ clocks = <&cru PCLK_I2C1>;
pinctrl-names = "default";
- pinctrl-0 = <&i2c2_xfer>;
+ pinctrl-0 = <&i2c1_xfer>;
status = "disabled";
};
--
2.7.4
[toc] | [next] | [standalone]
| From | Heiko Stuebner <heiko@sntech.de> |
|---|---|
| Date | 2016-09-08 16:40 +0200 |
| Message-ID | <sf8EG-6YA-13@gated-at.bofh.it> |
| In reply to | #1479105 |
Am Donnerstag, 8. September 2016, 19:03:43 CEST schrieb Andy Yan: > According to the TRM and downstream code from rockchip, the register > address of i2c1 on rk3368 is 0xff660000 and i2c2 is 0xff140000. > > This patch fix the i2c1 & i2c2 register address definition error, also > fix the clk and pinctrl reference error. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> after also checking the TRM for confirmation, applied to my dts64 branch Thanks for catching that Heiko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web