Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1479209 > unrolled thread
| Started by | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| First post | 2016-09-08 15:20 +0200 |
| Last post | 2016-09-09 12:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support Shawn Guo <shawnguo@kernel.org> - 2016-09-08 15:20 +0200
RE: [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support "S.H. Xie" <shaohui.xie@nxp.com> - 2016-09-09 12:30 +0200
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2016-09-08 15:20 +0200 |
| Subject | Re: [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support |
| Message-ID | <sf7pg-6h3-21@gated-at.bofh.it> |
On Mon, Sep 05, 2016 at 06:01:33PM +0800, shh.xie@gmail.com wrote:
> +&ifc {
> + status = "okay";
For sake of consistency, please have 'status' at the end of property
list.
Shawn
> + #address-cells = <2>;
> + #size-cells = <1>;
> + /* NAND Flashe and CPLD on board */
> + ranges = <0x0 0x0 0x0 0x7e800000 0x00010000
> + 0x2 0x0 0x0 0x7fb00000 0x00000100>;
> +
> + nand@0,0 {
> + compatible = "fsl,ifc-nand";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x0 0x0 0x10000>;
> + };
> +
> + cpld: board-control@2,0 {
> + compatible = "fsl,ls1046ardb-cpld";
> + reg = <0x2 0x0 0x0000100>;
> + };
> +};
[toc] | [next] | [standalone]
| From | "S.H. Xie" <shaohui.xie@nxp.com> |
|---|---|
| Date | 2016-09-09 12:30 +0200 |
| Message-ID | <sfrei-1AG-47@gated-at.bofh.it> |
| In reply to | #1479209 |
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Thursday, September 08, 2016 9:12 PM
> To: shh.xie@gmail.com
> Cc: devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
> linux-arm-kernel@lists.infradead.org; catalin.marinas@arm.com;
> will.deacon@arm.com; linux-kernel@vger.kernel.org; arnd@arndb.de; Vincent Hu
> <mingkai.hu@nxp.com>; S.H. Xie <shaohui.xie@nxp.com>
> Subject: Re: [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support
>
> On Mon, Sep 05, 2016 at 06:01:33PM +0800, shh.xie@gmail.com wrote:
> > +&ifc {
> > + status = "okay";
>
> For sake of consistency, please have 'status' at the end of property list.
[S.H] Will fix it in next version.
Thanks,
Shaohui
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web