Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479203 > unrolled thread

[PATCH] x86, clock: Fix kvm guest tsc initialization

Back to article view | Back to linux.kernel

Contents

  [PATCH] x86, clock: Fix kvm guest tsc initialization Prarit Bhargava <prarit@redhat.com> - 2016-09-08 15:10 +0200
    Re: [PATCH] x86, clock: Fix kvm guest tsc initialization Paolo Bonzini <pbonzini@redhat.com> - 2016-09-08 15:40 +0200
      Re: [PATCH] x86, clock: Fix kvm guest tsc initialization Prarit Bhargava <prarit@redhat.com> - 2016-09-08 15:50 +0200
      [PATCH v2] x86, clock: Fix kvm guest tsc initialization Prarit Bhargava <prarit@redhat.com> - 2016-09-08 16:20 +0200
        Re: [PATCH v2] x86, clock: Fix kvm guest tsc initialization Paolo Bonzini <pbonzini@redhat.com> - 2016-09-08 16:50 +0200

#1479203 — [PATCH] x86, clock: Fix kvm guest tsc initialization

When booting a kvm guest on AMD with the latest kernel the following
messages are displayed in the boot log:

 tsc: Unable to calibrate against PIT
 tsc: HPET/PMTIMER calibration failed

aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
introduced a change to account for a difference in cpu and tsc frequencies for
Intel SKL processors. Before this change the native tsc set
x86_platform.calibrate_tsc to native_calibrate_tsc() which is a hardware
calibration of the tsc, and in tsc_init() executed

	tsc_khz = x86_platform.calibrate_tsc();
	cpu_khz = tsc_khz;

The kvm code changed x86_platform.calibrate_tsc to kvm_get_tsc_khz() and
executed the same tsc_init() function.  This meant that KVM guests did not
execute the native hardware calibration function.

After aa297292d708, there are separate native calibrations for cpu_khz and
tsc_khz.  The code sets x86_platform.calibrate_tsc to native_calibrate_tsc()
which is now an Intel specific calibration function , and
x86_platform.calibrate_cpu to native_calibrate_cpu() which is the "old"
native_calibrate_tsc() function (ie, the native hardware calibration
function).

tsc_init() now does

	cpu_khz = x86_platform.calibrate_cpu();
	tsc_khz = x86_platform.calibrate_tsc();
	if (tsc_khz == 0)
		tsc_khz = cpu_khz;
	else if (abs(cpu_khz - tsc_khz) * 10 > tsc_khz)
		cpu_khz = tsc_khz;

The kvm code should not call the hardware initialization in
native_calibrate_cpu(), as it isn't applicable for kvm and it didn't do that
prior to aa297292d708.  Setting x86_platform.calibrate_cpu to NULL is not
appropriate as cpu_khz_from_cpuid() must be called to get the correct
value of cpu_khz on Intel KVM guests.

This patch resolves this issue by setting x86_platform.calibrate_cpu to
cpu_khz_from_cpuid() for KVM guests, which allows Intel KVM guests to get
the right cpu frequency.

Fixes: aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Len Brown <len.brown@intel.com>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Christopher S. Hall" <christopher.s.hall@intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: kvm@vger.kernel.org
---
 arch/x86/include/asm/tsc.h |    1 +
 arch/x86/kernel/kvmclock.c |    1 +
 arch/x86/kernel/tsc.c      |    2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h
index 33b6365c22fe..1bfb3a14dad0 100644
--- a/arch/x86/include/asm/tsc.h
+++ b/arch/x86/include/asm/tsc.h
@@ -37,6 +37,7 @@ extern int unsynchronized_tsc(void);
 extern int check_tsc_unstable(void);
 extern unsigned long native_calibrate_cpu(void);
 extern unsigned long native_calibrate_tsc(void);
+extern unsigned long cpu_khz_from_cpuid(void);
 extern unsigned long long native_sched_clock_from_tsc(u64 tsc);
 
 extern int tsc_clocksource_reliable;
diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index 1d39bfbd26bb..1fe23cff7c3e 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -289,6 +289,7 @@ void __init kvmclock_init(void)
 	put_cpu();
 
 	x86_platform.calibrate_tsc = kvm_get_tsc_khz;
+	x86_platform.calibrate_cpu = cpu_khz_from_cpuid;
 	x86_platform.get_wallclock = kvm_get_wallclock;
 	x86_platform.set_wallclock = kvm_set_wallclock;
 #ifdef CONFIG_X86_LOCAL_APIC
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 78b9cb5a26af..9265ea8effe9 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -699,7 +699,7 @@ unsigned long native_calibrate_tsc(void)
 	return crystal_khz * ebx_numerator / eax_denominator;
 }
 
-static unsigned long cpu_khz_from_cpuid(void)
+unsigned long cpu_khz_from_cpuid(void)
 {
 	unsigned int eax_base_mhz, ebx_max_mhz, ecx_bus_mhz, edx;
 
-- 
1.7.9.3

[toc] | [next] | [standalone]

#1479234

On 08/09/2016 15:07, Prarit Bhargava wrote:
> When booting a kvm guest on AMD with the latest kernel the following
> messages are displayed in the boot log:
> 
>  tsc: Unable to calibrate against PIT
>  tsc: HPET/PMTIMER calibration failed
> 
> aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
> introduced a change to account for a difference in cpu and tsc frequencies for
> Intel SKL processors. Before this change the native tsc set
> x86_platform.calibrate_tsc to native_calibrate_tsc() which is a hardware
> calibration of the tsc, and in tsc_init() executed
> 
> 	tsc_khz = x86_platform.calibrate_tsc();
> 	cpu_khz = tsc_khz;
> 
> The kvm code changed x86_platform.calibrate_tsc to kvm_get_tsc_khz() and
> executed the same tsc_init() function.  This meant that KVM guests did not
> execute the native hardware calibration function.
> 
> After aa297292d708, there are separate native calibrations for cpu_khz and
> tsc_khz.  The code sets x86_platform.calibrate_tsc to native_calibrate_tsc()
> which is now an Intel specific calibration function , and
> x86_platform.calibrate_cpu to native_calibrate_cpu() which is the "old"
> native_calibrate_tsc() function (ie, the native hardware calibration
> function). [...]
> 
> The kvm code should not call the hardware initialization in
> native_calibrate_cpu(), as it isn't applicable for kvm and it didn't do that
> prior to aa297292d708.  Setting x86_platform.calibrate_cpu to NULL is not
> appropriate as cpu_khz_from_cpuid() must be called to get the correct
> value of cpu_khz on Intel KVM guests.
> 
> This patch resolves this issue by setting x86_platform.calibrate_cpu to
> cpu_khz_from_cpuid() for KVM guests, which allows Intel KVM guests to get
> the right cpu frequency.

KVM guests don't have that CPUID leaf at all.  kvm_get_tsc_khz can
double as x86_platform.calibrate_cpu too for KVM guests, restoring the
behavior prior to aa297292d708.

Thanks,

Paolo

> Fixes: aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Radim Krčmář" <rkrcmar@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: "Christopher S. Hall" <christopher.s.hall@intel.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: kvm@vger.kernel.org
> ---
>  arch/x86/include/asm/tsc.h |    1 +
>  arch/x86/kernel/kvmclock.c |    1 +
>  arch/x86/kernel/tsc.c      |    2 +-
>  3 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h
> index 33b6365c22fe..1bfb3a14dad0 100644
> --- a/arch/x86/include/asm/tsc.h
> +++ b/arch/x86/include/asm/tsc.h
> @@ -37,6 +37,7 @@ extern int unsynchronized_tsc(void);
>  extern int check_tsc_unstable(void);
>  extern unsigned long native_calibrate_cpu(void);
>  extern unsigned long native_calibrate_tsc(void);
> +extern unsigned long cpu_khz_from_cpuid(void);
>  extern unsigned long long native_sched_clock_from_tsc(u64 tsc);
>  
>  extern int tsc_clocksource_reliable;
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index 1d39bfbd26bb..1fe23cff7c3e 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -289,6 +289,7 @@ void __init kvmclock_init(void)
>  	put_cpu();
>  
>  	x86_platform.calibrate_tsc = kvm_get_tsc_khz;
> +	x86_platform.calibrate_cpu = cpu_khz_from_cpuid;
>  	x86_platform.get_wallclock = kvm_get_wallclock;
>  	x86_platform.set_wallclock = kvm_set_wallclock;
>  #ifdef CONFIG_X86_LOCAL_APIC
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 78b9cb5a26af..9265ea8effe9 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -699,7 +699,7 @@ unsigned long native_calibrate_tsc(void)
>  	return crystal_khz * ebx_numerator / eax_denominator;
>  }
>  
> -static unsigned long cpu_khz_from_cpuid(void)
> +unsigned long cpu_khz_from_cpuid(void)
>  {
>  	unsigned int eax_base_mhz, ebx_max_mhz, ecx_bus_mhz, edx;
>  
> 

[toc] | [prev] | [next] | [standalone]

#1479239

On 09/08/2016 09:33 AM, Paolo Bonzini wrote:
> 
> 
> On 08/09/2016 15:07, Prarit Bhargava wrote:
>> When booting a kvm guest on AMD with the latest kernel the following
>> messages are displayed in the boot log:
>>
>>  tsc: Unable to calibrate against PIT
>>  tsc: HPET/PMTIMER calibration failed
>>
>> aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
>> introduced a change to account for a difference in cpu and tsc frequencies for
>> Intel SKL processors. Before this change the native tsc set
>> x86_platform.calibrate_tsc to native_calibrate_tsc() which is a hardware
>> calibration of the tsc, and in tsc_init() executed
>>
>> 	tsc_khz = x86_platform.calibrate_tsc();
>> 	cpu_khz = tsc_khz;
>>
>> The kvm code changed x86_platform.calibrate_tsc to kvm_get_tsc_khz() and
>> executed the same tsc_init() function.  This meant that KVM guests did not
>> execute the native hardware calibration function.
>>
>> After aa297292d708, there are separate native calibrations for cpu_khz and
>> tsc_khz.  The code sets x86_platform.calibrate_tsc to native_calibrate_tsc()
>> which is now an Intel specific calibration function , and
>> x86_platform.calibrate_cpu to native_calibrate_cpu() which is the "old"
>> native_calibrate_tsc() function (ie, the native hardware calibration
>> function). [...]
>>
>> The kvm code should not call the hardware initialization in
>> native_calibrate_cpu(), as it isn't applicable for kvm and it didn't do that
>> prior to aa297292d708.  Setting x86_platform.calibrate_cpu to NULL is not
>> appropriate as cpu_khz_from_cpuid() must be called to get the correct
>> value of cpu_khz on Intel KVM guests.
>>
>> This patch resolves this issue by setting x86_platform.calibrate_cpu to
>> cpu_khz_from_cpuid() for KVM guests, which allows Intel KVM guests to get
>> the right cpu frequency.
> 
> KVM guests don't have that CPUID leaf at all.  kvm_get_tsc_khz can
> double as x86_platform.calibrate_cpu too for KVM guests, restoring the
> behavior prior to aa297292d708.

Thanks Paolo -- v2 coming shortly.

P.

[toc] | [prev] | [next] | [standalone]

#1479269 — [PATCH v2] x86, clock: Fix kvm guest tsc initialization

When booting a kvm guest on AMD with the latest kernel the following
messages are displayed in the boot log:

 tsc: Unable to calibrate against PIT
 tsc: HPET/PMTIMER calibration failed

aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
introduced a change to account for a difference in cpu and tsc frequencies for
Intel SKL processors. Before this change the native tsc set
x86_platform.calibrate_tsc to native_calibrate_tsc() which is a hardware
calibration of the tsc, and in tsc_init() executed

	tsc_khz = x86_platform.calibrate_tsc();
	cpu_khz = tsc_khz;

The kvm code changed x86_platform.calibrate_tsc to kvm_get_tsc_khz() and
executed the same tsc_init() function.  This meant that KVM guests did not
execute the native hardware calibration function.

After aa297292d708, there are separate native calibrations for cpu_khz and
tsc_khz.  The code sets x86_platform.calibrate_tsc to native_calibrate_tsc()
which is now an Intel specific calibration function, and
x86_platform.calibrate_cpu to native_calibrate_cpu() which is the "old"
native_calibrate_tsc() function (ie, the native hardware calibration
function).

tsc_init() now does

	cpu_khz = x86_platform.calibrate_cpu();
	tsc_khz = x86_platform.calibrate_tsc();
	if (tsc_khz == 0)
		tsc_khz = cpu_khz;
	else if (abs(cpu_khz - tsc_khz) * 10 > tsc_khz)
		cpu_khz = tsc_khz;

The kvm code should not call the hardware initialization in
native_calibrate_cpu(), as it isn't applicable for kvm and it didn't do that
prior to aa297292d708.

This patch resolves this issue by setting x86_platform.calibrate_cpu to
kvm_get_tsc_khz().

v2: I had originally set x86_platform.calibrate_cpu to
cpu_khz_from_cpuid(), however, pbonzini pointed out that the CPUID leaf
in that function is not available in KVM.  I have changed the function
pointer to kvm_get_tsc_khz().

Fixes: aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Len Brown <len.brown@intel.com>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Christopher S. Hall" <christopher.s.hall@intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: kvm@vger.kernel.org
---
 arch/x86/kernel/kvmclock.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index 1d39bfbd26bb..3692249a70f1 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -289,6 +289,7 @@ void __init kvmclock_init(void)
 	put_cpu();
 
 	x86_platform.calibrate_tsc = kvm_get_tsc_khz;
+	x86_platform.calibrate_cpu = kvm_get_tsc_khz;
 	x86_platform.get_wallclock = kvm_get_wallclock;
 	x86_platform.set_wallclock = kvm_set_wallclock;
 #ifdef CONFIG_X86_LOCAL_APIC
-- 
1.7.9.3

[toc] | [prev] | [next] | [standalone]

#1479287 — Re: [PATCH v2] x86, clock: Fix kvm guest tsc initialization

On 08/09/2016 16:15, Prarit Bhargava wrote:
> When booting a kvm guest on AMD with the latest kernel the following
> messages are displayed in the boot log:
> 
>  tsc: Unable to calibrate against PIT
>  tsc: HPET/PMTIMER calibration failed
> 
> aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
> introduced a change to account for a difference in cpu and tsc frequencies for
> Intel SKL processors. Before this change the native tsc set
> x86_platform.calibrate_tsc to native_calibrate_tsc() which is a hardware
> calibration of the tsc, and in tsc_init() executed
> 
> 	tsc_khz = x86_platform.calibrate_tsc();
> 	cpu_khz = tsc_khz;
> 
> The kvm code changed x86_platform.calibrate_tsc to kvm_get_tsc_khz() and
> executed the same tsc_init() function.  This meant that KVM guests did not
> execute the native hardware calibration function.
> 
> After aa297292d708, there are separate native calibrations for cpu_khz and
> tsc_khz.  The code sets x86_platform.calibrate_tsc to native_calibrate_tsc()
> which is now an Intel specific calibration function, and
> x86_platform.calibrate_cpu to native_calibrate_cpu() which is the "old"
> native_calibrate_tsc() function (ie, the native hardware calibration
> function).
> 
> tsc_init() now does
> 
> 	cpu_khz = x86_platform.calibrate_cpu();
> 	tsc_khz = x86_platform.calibrate_tsc();
> 	if (tsc_khz == 0)
> 		tsc_khz = cpu_khz;
> 	else if (abs(cpu_khz - tsc_khz) * 10 > tsc_khz)
> 		cpu_khz = tsc_khz;
> 
> The kvm code should not call the hardware initialization in
> native_calibrate_cpu(), as it isn't applicable for kvm and it didn't do that
> prior to aa297292d708.
> 
> This patch resolves this issue by setting x86_platform.calibrate_cpu to
> kvm_get_tsc_khz().
> 
> v2: I had originally set x86_platform.calibrate_cpu to
> cpu_khz_from_cpuid(), however, pbonzini pointed out that the CPUID leaf
> in that function is not available in KVM.  I have changed the function
> pointer to kvm_get_tsc_khz().
> 
> Fixes: aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via CPUID")
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Radim Krčmář" <rkrcmar@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: "Christopher S. Hall" <christopher.s.hall@intel.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: kvm@vger.kernel.org
> ---
>  arch/x86/kernel/kvmclock.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index 1d39bfbd26bb..3692249a70f1 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -289,6 +289,7 @@ void __init kvmclock_init(void)
>  	put_cpu();
>  
>  	x86_platform.calibrate_tsc = kvm_get_tsc_khz;
> +	x86_platform.calibrate_cpu = kvm_get_tsc_khz;
>  	x86_platform.get_wallclock = kvm_get_wallclock;
>  	x86_platform.set_wallclock = kvm_set_wallclock;
>  #ifdef CONFIG_X86_LOCAL_APIC
> 

Applied to kvm/master, thanks (commit
a4497a86fb9b855c5ac8503fdc959393b00bb643).  I'll probably send a pull
request to Linus only next week though.

Paolo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web