Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1478160 > unrolled thread
| Started by | Gerd Hoffmann <kraxel@redhat.com> |
|---|---|
| First post | 2016-09-07 12:40 +0200 |
| Last post | 2016-09-09 09:00 +0200 |
| Articles | 8 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-07 12:40 +0200
Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-07 20:20 +0200
Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-08 09:50 +0200
Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-08 14:10 +0200
Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-09 10:30 +0200
Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-09 10:50 +0200
Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Scott Branden <scott.branden@broadcom.com> - 2016-09-08 22:00 +0200
Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-09 09:00 +0200
| From | Gerd Hoffmann <kraxel@redhat.com> |
|---|---|
| Date | 2016-09-07 12:40 +0200 |
| Subject | [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <seIqS-6Zc-27@gated-at.bofh.it> |
From: Eric Anholt <eric@anholt.net>
This will be used for having EMMC (sdhci-bcm2835.c) drive the
wireless.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
arch/arm/boot/dts/bcm283x.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index 062d09db..b6b1950 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -257,6 +257,11 @@
brcm,pins = <32 33>;
brcm,function = <BCM2835_FSEL_ALT3>;
};
+ emmc_gpio34: emmc_gpio34 {
+ brcm,pins = <34 35 36 37 38 39>;
+ brcm,function = <BCM2835_FSEL_ALT3>;
+ brcm,pull = <0 2 2 2 2 2>;
+ };
emmc_gpio48: emmc_gpio48 {
brcm,pins = <48 49 50 51 52 53>;
brcm,function = <BCM2835_FSEL_ALT3>;
--
1.8.3.1
[toc] | [next] | [standalone]
| From | Stefan Wahren <stefan.wahren@i2se.com> |
|---|---|
| Date | 2016-09-07 20:20 +0200 |
| Subject | Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <sePC2-3ed-25@gated-at.bofh.it> |
| In reply to | #1478160 |
> Gerd Hoffmann <kraxel@redhat.com> hat am 7. September 2016 um 12:31
> geschrieben:
>
>
> From: Eric Anholt <eric@anholt.net>
>
> This will be used for having EMMC (sdhci-bcm2835.c) drive the
> wireless.
sdhci-bcm2835.c has been replaced by sdhci-iproc.c
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> arch/arm/boot/dts/bcm283x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> index 062d09db..b6b1950 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -257,6 +257,11 @@
> brcm,pins = <32 33>;
> brcm,function = <BCM2835_FSEL_ALT3>;
> };
> + emmc_gpio34: emmc_gpio34 {
> + brcm,pins = <34 35 36 37 38 39>;
> + brcm,function = <BCM2835_FSEL_ALT3>;
> + brcm,pull = <0 2 2 2 2 2>;
How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h?
> + };
> emmc_gpio48: emmc_gpio48 {
> brcm,pins = <48 49 50 51 52 53>;
> brcm,function = <BCM2835_FSEL_ALT3>;
> --
> 1.8.3.1
>
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
[toc] | [prev] | [next] | [standalone]
| From | Gerd Hoffmann <kraxel@redhat.com> |
|---|---|
| Date | 2016-09-08 09:50 +0200 |
| Subject | Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <sf2fU-2RT-11@gated-at.bofh.it> |
| In reply to | #1478541 |
On Mi, 2016-09-07 at 20:13 +0200, Stefan Wahren wrote: > > Gerd Hoffmann <kraxel@redhat.com> hat am 7. September 2016 um 12:31 > > geschrieben: > > > > > > From: Eric Anholt <eric@anholt.net> > > > > This will be used for having EMMC (sdhci-bcm2835.c) drive the > > wireless. > > sdhci-bcm2835.c has been replaced by sdhci-iproc.c Ah, right, I'll update the commit msg for v2. > How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h? Already there (or do you mean something other than '#define BCM2835_FSEL_*' ?) cheers, Gerd
[toc] | [prev] | [next] | [standalone]
| From | Stefan Wahren <stefan.wahren@i2se.com> |
|---|---|
| Date | 2016-09-08 14:10 +0200 |
| Subject | Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <sf6jv-5D5-13@gated-at.bofh.it> |
| In reply to | #1478872 |
Am 08.09.2016 um 09:44 schrieb Gerd Hoffmann: > On Mi, 2016-09-07 at 20:13 +0200, Stefan Wahren wrote: >>> Gerd Hoffmann <kraxel@redhat.com> hat am 7. September 2016 um 12:31 >>> geschrieben: >>> >>> >>> From: Eric Anholt <eric@anholt.net> >>> >>> This will be used for having EMMC (sdhci-bcm2835.c) drive the >>> wireless. >> sdhci-bcm2835.c has been replaced by sdhci-iproc.c > Ah, right, I'll update the commit msg for v2. > >> How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h? > Already there (or do you mean something other than '#define > BCM2835_FSEL_*' ?) No, i thought of the GPIO pull up/down register values: BCM2835_PUD_OFF 0 BCM2835_PUD_DOWN 1 BCM2835_PUD_UP 2 > > cheers, > Gerd > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[toc] | [prev] | [next] | [standalone]
| From | Gerd Hoffmann <kraxel@redhat.com> |
|---|---|
| Date | 2016-09-09 10:30 +0200 |
| Subject | Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <sfpma-tM-21@gated-at.bofh.it> |
| In reply to | #1479153 |
Hi, > No, i thought of the GPIO pull up/down register values: > > BCM2835_PUD_OFF 0 > BCM2835_PUD_DOWN 1 > BCM2835_PUD_UP 2 We can do that, sure (and probably drop the unused "enum bcm2835_pinconf_pull" from drivers/pinctrl/bcm/pinctrl-bcm2835.c at the same time). But I fail to see how this is related to the patch discussed, looks like a independent issue to me ... cheers, Gerd
[toc] | [prev] | [next] | [standalone]
| From | Gerd Hoffmann <kraxel@redhat.com> |
|---|---|
| Date | 2016-09-09 10:50 +0200 |
| Subject | Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <sfpFw-zV-19@gated-at.bofh.it> |
| In reply to | #1479736 |
On Fr, 2016-09-09 at 10:26 +0200, Gerd Hoffmann wrote: > Hi, > > > No, i thought of the GPIO pull up/down register values: > > > > BCM2835_PUD_OFF 0 > > BCM2835_PUD_DOWN 1 > > BCM2835_PUD_UP 2 > > We can do that, sure (and probably drop the unused "enum > bcm2835_pinconf_pull" from drivers/pinctrl/bcm/pinctrl-bcm2835.c at the > same time). > > But I fail to see how this is related to the patch discussed, looks like > a independent issue to me ... Oops, noticed that emmc_gpio34 uses them while ordering all the entries. cheers, Gerd
[toc] | [prev] | [next] | [standalone]
| From | Scott Branden <scott.branden@broadcom.com> |
|---|---|
| Date | 2016-09-08 22:00 +0200 |
| Subject | Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <sfdEm-1zP-23@gated-at.bofh.it> |
| In reply to | #1478872 |
Hi Gerd/Eric On 16-09-08 12:44 AM, Gerd Hoffmann wrote: > On Mi, 2016-09-07 at 20:13 +0200, Stefan Wahren wrote: >>> Gerd Hoffmann <kraxel@redhat.com> hat am 7. September 2016 um 12:31 >>> geschrieben: >>> >>> >>> From: Eric Anholt <eric@anholt.net> >>> >>> This will be used for having EMMC (sdhci-bcm2835.c) drive the >>> wireless. >> >> sdhci-bcm2835.c has been replaced by sdhci-iproc.c > > Ah, right, I'll update the commit msg for v2. > Should we entirely remove sdhci-bcm2835.c to reduce confusion going forward? >> How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h? > > Already there (or do you mean something other than '#define > BCM2835_FSEL_*' ?) > > cheers, > Gerd > Thanks, Scott
[toc] | [prev] | [next] | [standalone]
| From | Stefan Wahren <stefan.wahren@i2se.com> |
|---|---|
| Date | 2016-09-09 09:00 +0200 |
| Subject | Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. |
| Message-ID | <sfnX3-7Yx-1@gated-at.bofh.it> |
| In reply to | #1479472 |
Hi Scott, Am 08.09.2016 um 21:50 schrieb Scott Branden: > Hi Gerd/Eric > > On 16-09-08 12:44 AM, Gerd Hoffmann wrote: >> On Mi, 2016-09-07 at 20:13 +0200, Stefan Wahren wrote: >>>> Gerd Hoffmann <kraxel@redhat.com> hat am 7. September 2016 um 12:31 >>>> geschrieben: >>>> >>>> >>>> From: Eric Anholt <eric@anholt.net> >>>> >>>> This will be used for having EMMC (sdhci-bcm2835.c) drive the >>>> wireless. >>> >>> sdhci-bcm2835.c has been replaced by sdhci-iproc.c >> >> Ah, right, I'll update the commit msg for v2. >> > Should we entirely remove sdhci-bcm2835.c to reduce confusion going > forward? did i missed something? https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=46cd175c9788e39a1c57698ab58f34844d216428 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7eb16493ecaa41ceeb448717ee2c59690cd9047f > >>> How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h? >> >> Already there (or do you mean something other than '#define >> BCM2835_FSEL_*' ?) >> >> cheers, >> Gerd >> > > Thanks, > Scott
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web