Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1477905 > unrolled thread
| Started by | Inhyuk Kang <hugh.kang@lge.com> |
|---|---|
| First post | 2016-09-07 02:50 +0200 |
| Last post | 2016-09-08 10:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] thermal: cpu_cooling: Fix wrong comment call function name Inhyuk Kang <hugh.kang@lge.com> - 2016-09-07 02:50 +0200
Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-07 07:10 +0200
Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name Javi Merino <javi.merino@arm.com> - 2016-09-08 10:30 +0200
| From | Inhyuk Kang <hugh.kang@lge.com> |
|---|---|
| Date | 2016-09-07 02:50 +0200 |
| Subject | [PATCH] thermal: cpu_cooling: Fix wrong comment call function name |
| Message-ID | <sezdT-Yp-19@gated-at.bofh.it> |
The last_load is updated not cpufreq_get_actual_power() function call
but cpufreq_get_requested_power() function call.
Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index a32b417..9ce0e9e 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -74,7 +74,7 @@ struct power_table {
* cpufreq frequencies.
* @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
* @node: list_head to link all cpufreq_cooling_device together.
- * @last_load: load measured by the latest call to cpufreq_get_actual_power()
+ * @last_load: load measured by the latest call to cpufreq_get_requested_power()
* @time_in_idle: previous reading of the absolute time that this cpu was idle
* @time_in_idle_timestamp: wall time of the last invocation of
* get_cpu_idle_time_us()
--
1.9.1
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2016-09-07 07:10 +0200 |
| Subject | Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name |
| Message-ID | <seDhv-3Q1-3@gated-at.bofh.it> |
| In reply to | #1477905 |
On 07-09-16, 09:35, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.
>
> Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
> * cpufreq frequencies.
> * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
> * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to cpufreq_get_requested_power()
> * @time_in_idle: previous reading of the absolute time that this cpu was idle
> * @time_in_idle_timestamp: wall time of the last invocation of
> * get_cpu_idle_time_us()
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
[toc] | [prev] | [next] | [standalone]
| From | Javi Merino <javi.merino@arm.com> |
|---|---|
| Date | 2016-09-08 10:30 +0200 |
| Subject | Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name |
| Message-ID | <sf2SC-3oQ-9@gated-at.bofh.it> |
| In reply to | #1477905 |
On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.
Yep, my bad. Thanks for fixing it!
> Signed-off-by: Inhyuk Kang <hugh.kang@lge.com>
Acked-by: Javi Merino <javi.merino@arm.com>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
> * cpufreq frequencies.
> * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
> * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to cpufreq_get_requested_power()
> * @time_in_idle: previous reading of the absolute time that this cpu was idle
> * @time_in_idle_timestamp: wall time of the last invocation of
> * get_cpu_idle_time_us()
> --
> 1.9.1
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web