Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475808 > unrolled thread

Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

Started bykbuild test robot <lkp@intel.com>
First post2016-09-04 02:30 +0200
Last post2016-09-07 17:40 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of  int for all bit test functions kbuild test robot <lkp@intel.com> - 2016-09-04 02:30 +0200
    Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of  int for all bit test functions Andrew Morton <akpm@linux-foundation.org> - 2016-09-06 21:30 +0200
      Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of  int for all bit test functions Fengguang Wu <lkp@intel.com> - 2016-09-07 04:00 +0200
        Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead  of int for all bit test functions Chen Gang <chengang@emindsoft.com.cn> - 2016-09-07 17:40 +0200

#1475808 — Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

Fromkbuild test robot <lkp@intel.com>
Date2016-09-04 02:30 +0200
SubjectRe: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Message-ID<sdttT-3NN-3@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hi Chen,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc4 next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
config: s390-default_defconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All errors (new ones prefixed by >>):

   In file included from include/linux/bitops.h:36:0,
                    from fs/btrfs/extent_io.c:1:
>> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
    static inline bool
                  ^
   arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
    static inline bool
                  ^
   arch/s390/include/asm/bitops.h:198:15: error: unknown type name 'bool'
    static inline bool
                  ^
   arch/s390/include/asm/bitops.h:231:15: error: unknown type name 'bool'
    static inline bool
                  ^
   arch/s390/include/asm/bitops.h:242:15: error: unknown type name 'bool'
    static inline bool
                  ^
   arch/s390/include/asm/bitops.h:253:15: error: unknown type name 'bool'
    static inline bool
                  ^
   arch/s390/include/asm/bitops.h:264:15: error: unknown type name 'bool'
    static inline bool test_bit(unsigned long nr, const volatile unsigned long *ptr)
                  ^
   arch/s390/include/asm/bitops.h:273:15: error: unknown type name 'bool'
    static inline bool test_and_set_bit_lock(unsigned long nr,
                  ^
   arch/s390/include/asm/bitops.h:324:15: error: unknown type name 'bool'
    static inline bool test_bit_inv(unsigned long nr,
                  ^

vim +/bool +176 arch/s390/include/asm/bitops.h

   170		}
   171	#endif
   172		mask = 1UL << (nr & (BITS_PER_LONG - 1));
   173		__BITOPS_LOOP(addr, mask, __BITOPS_XOR, __BITOPS_NO_BARRIER);
   174	}
   175	
 > 176	static inline bool
   177	test_and_set_bit(unsigned long nr, volatile unsigned long *ptr)
   178	{
   179		unsigned long *addr = __bitops_word(nr, ptr);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1477779

FromAndrew Morton <akpm@linux-foundation.org>
Date2016-09-06 21:30 +0200
Message-ID<seuee-688-17@gated-at.bofh.it>
In reply to#1475808
On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@intel.com> wrote:

> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.8-rc4 next-20160825]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
> 
> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
> config: s390-default_defconfig (attached as .config)
> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=s390 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/bitops.h:36:0,
>                     from fs/btrfs/extent_io.c:1:
> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>     static inline bool
>                   ^
>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>     static inline bool

My s390 cross compiler doesn't like that config.  Can someone test this?

--- a/arch/s390/include/asm/bitops.h~a
+++ a/arch/s390/include/asm/bitops.h
@@ -40,6 +40,7 @@
 #error only <linux/bitops.h> can be included directly
 #endif
 
+#include <linux/types.h>
 #include <linux/typecheck.h>
 #include <linux/compiler.h>
 #include <asm/barrier.h>
_

[toc] | [prev] | [next] | [standalone]

#1477927

FromFengguang Wu <lkp@intel.com>
Date2016-09-07 04:00 +0200
Message-ID<seAjD-1z8-5@gated-at.bofh.it>
In reply to#1477779
Hi Andrew,

On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote:
>On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@intel.com> wrote:
>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.8-rc4 next-20160825]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
>> [Check https://git-scm.com/docs/git-format-patch for more information]
>>
>> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
>> config: s390-default_defconfig (attached as .config)
>> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=s390
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from include/linux/bitops.h:36:0,
>>                     from fs/btrfs/extent_io.c:1:
>> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>>     static inline bool
>>                   ^
>>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>>     static inline bool
>
>My s390 cross compiler doesn't like that config.  Can someone test this?

Tested-by: Fengguang Wu <fengguang.wu@intel.com>

It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc:

https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz

>--- a/arch/s390/include/asm/bitops.h~a
>+++ a/arch/s390/include/asm/bitops.h
>@@ -40,6 +40,7 @@
> #error only <linux/bitops.h> can be included directly
> #endif
>
>+#include <linux/types.h>
> #include <linux/typecheck.h>
> #include <linux/compiler.h>
> #include <asm/barrier.h>

Regards,
Fengguang

[toc] | [prev] | [next] | [standalone]

#1478430 — Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

FromChen Gang <chengang@emindsoft.com.cn>
Date2016-09-07 17:40 +0200
SubjectRe: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions
Message-ID<seN7b-1w7-13@gated-at.bofh.it>
In reply to#1477927
Thank you all for your work. Commonly, I should send patch v3 for it.

And very sorry for replying too late. During these days I have no
enough time on it (working, buying house, and catching a cold, but I am
lucky enough that my father's health is OK).

Thanks.

On 9/7/16 09:52, Fengguang Wu wrote:
> Hi Andrew,
> 
> On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote:
>> On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@intel.com> wrote:
>>
>>> [auto build test ERROR on linus/master]
>>> [also build test ERROR on v4.8-rc4 next-20160825]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
>>> [Check https://git-scm.com/docs/git-format-patch for more information]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
>>> config: s390-default_defconfig (attached as .config)
>>> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
>>> reproduce:
>>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>>         chmod +x ~/bin/make.cross
>>>         # save the attached .config to linux build tree
>>>         make.cross ARCH=s390
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    In file included from include/linux/bitops.h:36:0,
>>>                     from fs/btrfs/extent_io.c:1:
>>> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>>>     static inline bool
>>>                   ^
>>>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>>>     static inline bool
>>
>> My s390 cross compiler doesn't like that config.  Can someone test this?
> 
> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc:
> 
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz
> 
>> --- a/arch/s390/include/asm/bitops.h~a
>> +++ a/arch/s390/include/asm/bitops.h
>> @@ -40,6 +40,7 @@
>> #error only <linux/bitops.h> can be included directly
>> #endif
>>
>> +#include <linux/types.h>
>> #include <linux/typecheck.h>
>> #include <linux/compiler.h>
>> #include <asm/barrier.h>
> 
> Regards,
> Fengguang

-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web