Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1477148 > unrolled thread
| Started by | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| First post | 2016-09-06 10:20 +0200 |
| Last post | 2016-09-07 01:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-06 10:20 +0200
Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static Arnd Bergmann <arnd@arndb.de> - 2016-09-06 11:30 +0200
Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static David Miller <davem@davemloft.net> - 2016-09-07 01:00 +0200
| From | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| Date | 2016-09-06 10:20 +0200 |
| Subject | [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static |
| Message-ID | <sejLP-7Or-5@gated-at.bofh.it> |
We get 1 warning when building kernel with W=1:
drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index c68fe49..fc68dd4 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1639,7 +1639,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
}
}
-void
+static void
vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
{
int i;
--
2.7.4
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-09-06 11:30 +0200 |
| Message-ID | <sekRF-5Z-21@gated-at.bofh.it> |
| In reply to | #1477148 |
On Tuesday, September 6, 2016 4:11:59 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Acked-by: Arnd Bergmann <arnd@arndb.de>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-09-07 01:00 +0200 |
| Subject | Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static |
| Message-ID | <sexvs-8ix-7@gated-at.bofh.it> |
| In reply to | #1477148 |
From: Baoyou Xie <baoyou.xie@linaro.org> Date: Tue, 6 Sep 2016 16:11:59 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> This doesn't apply cleanly to net-next.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web