Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1477059 > unrolled thread

[PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support

Started byStefan Agner <stefan@agner.ch>
First post2016-09-06 06:10 +0200
Last post2016-09-07 15:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Stefan Agner <stefan@agner.ch> - 2016-09-06 06:10 +0200
    RE: [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Meng Yi <meng.yi@nxp.com> - 2016-09-07 15:20 +0200

#1477059 — [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support

FromStefan Agner <stefan@agner.ch>
Date2016-09-06 06:10 +0200
Subject[PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support
Message-ID<sefRT-5e5-7@gated-at.bofh.it>
This patchset adds overlay and cursor plane support. It also
fixes some issues uncovered during implementation of this.

However, the plane updates currently causes the display to flicker for
unknown reasons. As far as I can tell, the CRTC atomic_flush should
trigger the update correctly via READREG, which according to
documentation:
The READREG bit causes a single transfer to begin at the next frame
blanking period. This bit is cleared when the transfer is complete.

I made a video how that looks:
https://cloud.agner.ch/index.php/s/Yfqa2u7UBEWUT8N

Any ideas?

Stefan Agner (4):
  drm/fsl-dcu: support overlay and cursor planes
  drm/fsl-dcu: respect pos/size register sizes
  drm/fsl-dcu: update all registers on flush
  drm/fsl-dcu: do not update when modifying irq registers

 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c  | 50 ++++++++++++++++++++++++-----
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c   |  4 ---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h   |  8 ++---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 42 +++++++++++-------------
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h |  3 +-
 5 files changed, 67 insertions(+), 40 deletions(-)

-- 
2.9.3

[toc] | [next] | [standalone]


#1478290

FromMeng Yi <meng.yi@nxp.com>
Date2016-09-07 15:20 +0200
Message-ID<seKVJ-db-47@gated-at.bofh.it>
In reply to#1477059
Hi Stefan,

I had tested the patches on LS1021A-TWR board using drmlib.

Like set three overlays:
root@ls1021atwr:~# ./modetest -P 39:900x100+10+10@RG24 -P 39:200x200+300+0@RG24 -P 39:200x200+400+300@RG24

How did you test the overlays and cursor layer, I mean I see you using x-window like thing in the  video.

Best Regards,
Meng

> This patchset adds overlay and cursor plane support. It also fixes some issues
> uncovered during implementation of this.
> 
> However, the plane updates currently causes the display to flicker for unknown
> reasons. As far as I can tell, the CRTC atomic_flush should trigger the update
> correctly via READREG, which according to
> documentation:
> The READREG bit causes a single transfer to begin at the next frame blanking
> period. This bit is cleared when the transfer is complete.
> 
> I made a video how that looks:
> https://cloud.agner.ch/index.php/s/Yfqa2u7UBEWUT8N
> 
> Any ideas?
> 
> Stefan Agner (4):
>   drm/fsl-dcu: support overlay and cursor planes
>   drm/fsl-dcu: respect pos/size register sizes
>   drm/fsl-dcu: update all registers on flush
>   drm/fsl-dcu: do not update when modifying irq registers
> 
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c  | 50
> ++++++++++++++++++++++++-----
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c   |  4 ---
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h   |  8 ++---
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 42 +++++++++++-------------
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h |  3 +-
>  5 files changed, 67 insertions(+), 40 deletions(-)
> 
> --
> 2.9.3

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web