Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1478109 > unrolled thread
| Started by | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| First post | 2016-09-07 11:30 +0200 |
| Last post | 2016-09-07 13:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/5] gpio: pca953x: code refactoring Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-07 11:30 +0200
Re: [PATCH v2 0/5] gpio: pca953x: code refactoring Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-07 13:40 +0200
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2016-09-07 11:30 +0200 |
| Subject | [PATCH v2 0/5] gpio: pca953x: code refactoring |
| Message-ID | <seHl7-6jf-3@gated-at.bofh.it> |
I'm working on converting the pca953x driver to using regmap, but since it's not a trivial task I figured I'd post a couple refactoring patches I did so far for 4.9. The first patch just fixes a couple coding style issues. The second removes a couple unnecessary switches. Last three refactor the read/write_regs functions to avoid if-elses by using function pointers to smaller, specialized routines. Tested with pca9534 and pca9535 chips. v1 -> v2: - constified the offset structures in patch 2/5 Bartosz Golaszewski (5): gpio: pca953x: coding style fixes gpio: pca953x: code shrink gpio: pca953x: refactor pca953x_write_regs() gpio: pca953x: remove an unused variable gpio: pca953x: refactor pca953x_read_regs() drivers/gpio/gpio-pca953x.c | 270 ++++++++++++++++++++++---------------------- 1 file changed, 136 insertions(+), 134 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2016-09-07 13:40 +0200 |
| Message-ID | <seJmV-7z9-3@gated-at.bofh.it> |
| In reply to | #1478109 |
On Wed, 2016-09-07 at 11:24 +0200, Bartosz Golaszewski wrote: > I'm working on converting the pca953x driver to using regmap, but > since > it's not a trivial task I figured I'd post a couple refactoring > patches > I did so far for 4.9. > > The first patch just fixes a couple coding style issues. The second > removes a couple unnecessary switches. Last three refactor the > read/write_regs functions to avoid if-elses by using function pointers > to smaller, specialized routines. > > Tested with pca9534 and pca9535 chips. Looks good to me overall, but please address my comments first. > > v1 -> v2: > - constified the offset structures in patch 2/5 > > Bartosz Golaszewski (5): > gpio: pca953x: coding style fixes > gpio: pca953x: code shrink > gpio: pca953x: refactor pca953x_write_regs() > gpio: pca953x: remove an unused variable > gpio: pca953x: refactor pca953x_read_regs() > > drivers/gpio/gpio-pca953x.c | 270 ++++++++++++++++++++++------------- > --------- > 1 file changed, 136 insertions(+), 134 deletions(-) > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web