Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478154 > unrolled thread

[PATCH v6 0/4] New debugfs API for capturing CRC of frames

Back to article view | Back to linux.kernel

Contents

  [PATCH v6 0/4] New debugfs API for capturing CRC of frames Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-09-07 12:30 +0200
    Re: [Intel-gfx] [PATCH v6 0/4] New debugfs API for capturing CRC of frames Emil Velikov <emil.l.velikov@gmail.com> - 2016-09-08 15:40 +0200

#1478154 — [PATCH v6 0/4] New debugfs API for capturing CRC of frames

Hi,

this series basically takes the facility for continuously capturing CRCs
of frames from the i915 driver and into the DRM core.

The idea is that test suites such as IGT use this information to check
that frames that are exected to be identical, also have identical CRC
values.

Other drivers for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.

Thanks,

Tomeu

Tomeu Vizoso (4):
  drm/i915/debugfs: Move out pipe CRC code
  drm: Add API for capturing frame CRCs
  drm/i915: Use new CRC debugfs API
  drm/i915: Put "cooked" vlank counters in frame CRC lines

 Documentation/gpu/drm-uapi.rst        |    6 +
 drivers/gpu/drm/Makefile              |    3 +-
 drivers/gpu/drm/drm_crtc.c            |   29 +-
 drivers/gpu/drm/drm_debugfs.c         |   34 +-
 drivers/gpu/drm/drm_debugfs_crc.c     |  351 ++++++++++++
 drivers/gpu/drm/drm_drv.c             |   15 +
 drivers/gpu/drm/drm_internal.h        |   10 +
 drivers/gpu/drm/i915/Makefile         |    2 +-
 drivers/gpu/drm/i915/i915_debugfs.c   |  886 +---------------------------
 drivers/gpu/drm/i915/i915_drv.c       |    2 +-
 drivers/gpu/drm/i915/i915_drv.h       |    3 +-
 drivers/gpu/drm/i915/i915_irq.c       |   83 ++-
 drivers/gpu/drm/i915/intel_display.c  |    1 +
 drivers/gpu/drm/i915/intel_drv.h      |    7 +
 drivers/gpu/drm/i915/intel_pipe_crc.c | 1014 +++++++++++++++++++++++++++++++++
 include/drm/drm_crtc.h                |   41 ++
 include/drm/drm_debugfs_crc.h         |   78 +++
 17 files changed, 1651 insertions(+), 914 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_debugfs_crc.c
 create mode 100644 drivers/gpu/drm/i915/intel_pipe_crc.c
 create mode 100644 include/drm/drm_debugfs_crc.h

-- 
2.7.4

[toc] | [next] | [standalone]

#1479232 — Re: [Intel-gfx] [PATCH v6 0/4] New debugfs API for capturing CRC of frames

On 7 September 2016 at 11:27, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
> Hi,
>
> this series basically takes the facility for continuously capturing CRCs
> of frames from the i915 driver and into the DRM core.
>
> The idea is that test suites such as IGT use this information to check
> that frames that are exected to be identical, also have identical CRC
> values.
>
> Other drivers for hardware that can provide frame CRCs (including eDP
> panels that support self-refresh) can easily implement the new callback
> and provide userspace with the CRC values.
>
> Thanks,
>
> Tomeu
>
> Tomeu Vizoso (4):
>   drm/i915/debugfs: Move out pipe CRC code
>   drm: Add API for capturing frame CRCs
>   drm/i915: Use new CRC debugfs API
>   drm/i915: Put "cooked" vlank counters in frame CRC lines
>
Thanks for the nice work and addressing my suggestions Tomeu. I think
I've spotted a bug in 2/4, plus there's a couple of trivial nitpicks
in 2/4 and 3/4 - either of which can be fixed as a follow up (if I
haven't lost it of course).

With the bug trivially fixed the series is:
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

-Emil

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web