Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1477985 > unrolled thread
| Started by | Lu Baolu <baolu.lu@linux.intel.com> |
|---|---|
| First post | 2016-09-07 08:30 +0200 |
| Last post | 2016-09-07 10:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] usb: xhci: fix return value of xhci_setup_device() Lu Baolu <baolu.lu@linux.intel.com> - 2016-09-07 08:30 +0200
Re: [PATCH 1/1] usb: xhci: fix return value of xhci_setup_device() Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-09-07 09:00 +0200
Re: [PATCH 1/1] usb: xhci: fix return value of xhci_setup_device() Lu Baolu <baolu.lu@linux.intel.com> - 2016-09-07 10:00 +0200
Re: [PATCH 1/1] usb: xhci: fix return value of xhci_setup_device() Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-09-07 10:10 +0200
| From | Lu Baolu <baolu.lu@linux.intel.com> |
|---|---|
| Date | 2016-09-07 08:30 +0200 |
| Subject | [PATCH 1/1] usb: xhci: fix return value of xhci_setup_device() |
| Message-ID | <seEwV-4wu-15@gated-at.bofh.it> |
From: "Lu, Baolu" <baolu.lu@linux.intel.com>
xhci_setup_device() should return failure with correct error number
when xhci host has died, removed or halted.
Cc: stable@vger.kernel.org # 4.3+
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/usb/host/xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 01d96c9..3e66e73 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -3785,8 +3785,10 @@ static int xhci_setup_device(struct usb_hcd *hcd, struct usb_device *udev,
mutex_lock(&xhci->mutex);
- if (xhci->xhc_state) /* dying, removing or halted */
+ if (xhci->xhc_state) { /* dying, removing or halted */
+ ret = -ESHUTDOWN;
goto out;
+ }
if (!udev->slot_id) {
xhci_dbg_trace(xhci, trace_xhci_dbg_address,
--
2.1.4
[toc] | [next] | [standalone]
| From | Mathias Nyman <mathias.nyman@linux.intel.com> |
|---|---|
| Date | 2016-09-07 09:00 +0200 |
| Message-ID | <seEZX-4FR-11@gated-at.bofh.it> |
| In reply to | #1477985 |
On 07.09.2016 09:22, Lu Baolu wrote: > From: "Lu, Baolu" <baolu.lu@linux.intel.com> > > xhci_setup_device() should return failure with correct error number > when xhci host has died, removed or halted. > Thanks, will add. Might go to 4.9 as 4.8-rc5 is already out -Mathias
[toc] | [prev] | [next] | [standalone]
| From | Lu Baolu <baolu.lu@linux.intel.com> |
|---|---|
| Date | 2016-09-07 10:00 +0200 |
| Message-ID | <seFW2-5g7-31@gated-at.bofh.it> |
| In reply to | #1478004 |
Hi Mathias, On 09/07/2016 02:51 PM, Mathias Nyman wrote: > On 07.09.2016 09:22, Lu Baolu wrote: >> From: "Lu, Baolu" <baolu.lu@linux.intel.com> >> >> xhci_setup_device() should return failure with correct error number >> when xhci host has died, removed or halted. >> > > Thanks, will add. > Might go to 4.9 as 4.8-rc5 is already out I'm sorry, I just realized that "From" signature is different from "Signed-off-by" signature in this patch. Do you mind if I resend this patch with this fixed? Best regards, Lu Baolu
[toc] | [prev] | [next] | [standalone]
| From | Mathias Nyman <mathias.nyman@linux.intel.com> |
|---|---|
| Date | 2016-09-07 10:10 +0200 |
| Message-ID | <seG5H-5A3-5@gated-at.bofh.it> |
| In reply to | #1478049 |
On 07.09.2016 10:54, Lu Baolu wrote: > Hi Mathias, > > On 09/07/2016 02:51 PM, Mathias Nyman wrote: >> On 07.09.2016 09:22, Lu Baolu wrote: >>> From: "Lu, Baolu" <baolu.lu@linux.intel.com> >>> >>> xhci_setup_device() should return failure with correct error number >>> when xhci host has died, removed or halted. >>> >> >> Thanks, will add. >> Might go to 4.9 as 4.8-rc5 is already out > > I'm sorry, I just realized that "From" signature is different from > "Signed-off-by" signature in this patch. > > Do you mind if I resend this patch with this fixed? > Not at all, I'll take v2 -Mathias
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web