Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1476896 > unrolled thread

[PATCH] staging: dgnc: Fix multi line comment alignment

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: dgnc: Fix multi line comment alignment Fernando Apesteguia <fernando.apesteguia@gmail.com> - 2016-09-05 20:30 +0200
    Re: [PATCH] staging: dgnc: Fix multi line comment alignment Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-05 22:50 +0200
      Re: [PATCH] staging: dgnc: Fix multi line comment alignment Fernando Apesteguia <fernando.apesteguia@gmail.com> - 2016-09-06 15:20 +0200
        Re: [PATCH] staging: dgnc: Fix multi line comment alignment Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-06 16:50 +0200

#1476896 — [PATCH] staging: dgnc: Fix multi line comment alignment

Fix alignment in multi line comment block.

Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle

Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>

---
 drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index cc6105a..01e948c 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
 	brd->re_map_membase = ioremap(brd->membase, 0x1000);
 }
 
-/*****************************************************************************
-*
-* Function:
-*
-*    dgnc_poll_handler
-*
-* Author:
-*
-*    Scott H Kilau
-*
-* Parameters:
-*
-*    dummy -- ignored
-*
-* Return Values:
-*
-*    none
-*
-* Description:
-*
-*    As each timer expires, it determines (a) whether the "transmit"
-*    waiter needs to be woken up, and (b) whether the poller needs to
-*    be rescheduled.
-*
-******************************************************************************/
+/*
+ *
+ * Function:
+ *
+ *    dgnc_poll_handler
+ *
+ * Author:
+ *
+ *    Scott H Kilau
+ *
+ * Parameters:
+ *
+ *    dummy -- ignored
+ *
+ * Return Values:
+ *
+ *    none
+ *
+ * Description:
+ *
+ *    As each timer expires, it determines (a) whether the "transmit"
+ *    waiter needs to be woken up, and (b) whether the poller needs to
+ *    be rescheduled.
+ *
+ */
 
 static void dgnc_poll_handler(ulong dummy)
 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1476962

On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> Fix alignment in multi line comment block.
> 
> Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle
> 
> Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> 
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index cc6105a..01e948c 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
>  	brd->re_map_membase = ioremap(brd->membase, 0x1000);
>  }
>  
> -/*****************************************************************************
> -*
> -* Function:
> -*
> -*    dgnc_poll_handler
> -*
> -* Author:
> -*
> -*    Scott H Kilau
> -*
> -* Parameters:
> -*
> -*    dummy -- ignored
> -*
> -* Return Values:
> -*
> -*    none
> -*
> -* Description:
> -*
> -*    As each timer expires, it determines (a) whether the "transmit"
> -*    waiter needs to be woken up, and (b) whether the poller needs to
> -*    be rescheduled.
> -*
> -******************************************************************************/
> +/*
> + *
> + * Function:
> + *
> + *    dgnc_poll_handler
> + *
> + * Author:
> + *
> + *    Scott H Kilau
> + *
> + * Parameters:
> + *
> + *    dummy -- ignored
> + *
> + * Return Values:
> + *
> + *    none
> + *
> + * Description:
> + *
> + *    As each timer expires, it determines (a) whether the "transmit"
> + *    waiter needs to be woken up, and (b) whether the poller needs to
> + *    be rescheduled.
> + *
> + */
>  
>  static void dgnc_poll_handler(ulong dummy)
>  {
> -- 
> 2.7.4

Changing first and last lines of that comment should be enough, but all
lines got changed. I'd (re)submit it with just first and last lines
changed.

[toc] | [prev] | [next] | [standalone]

#1477366

On Mon, Sep 05, 2016 at 11:45:30PM +0300, Andrey Utkin wrote:
> On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> > Fix alignment in multi line comment block.
> > 
> > Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle
> > 
> > Signed-off-by: Fernando Apesteguia <fernando.apesteguia@gmail.com>
> > 
> > ---
> >  drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
> >  1 file changed, 25 insertions(+), 25 deletions(-)
> > 
> > diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> > index cc6105a..01e948c 100644
> > --- a/drivers/staging/dgnc/dgnc_driver.c
> > +++ b/drivers/staging/dgnc/dgnc_driver.c
> > @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
> >  	brd->re_map_membase = ioremap(brd->membase, 0x1000);
> >  }
> >  
> > -/*****************************************************************************
> > -*
> > -* Function:
> > -*
> > -*    dgnc_poll_handler
> > -*
> > -* Author:
> > -*
> > -*    Scott H Kilau
> > -*
> > -* Parameters:
> > -*
> > -*    dummy -- ignored
> > -*
> > -* Return Values:
> > -*
> > -*    none
> > -*
> > -* Description:
> > -*
> > -*    As each timer expires, it determines (a) whether the "transmit"
> > -*    waiter needs to be woken up, and (b) whether the poller needs to
> > -*    be rescheduled.
> > -*
> > -******************************************************************************/
> > +/*
> > + *
> > + * Function:
> > + *
> > + *    dgnc_poll_handler
> > + *
> > + * Author:
> > + *
> > + *    Scott H Kilau
> > + *
> > + * Parameters:
> > + *
> > + *    dummy -- ignored
> > + *
> > + * Return Values:
> > + *
> > + *    none
> > + *
> > + * Description:
> > + *
> > + *    As each timer expires, it determines (a) whether the "transmit"
> > + *    waiter needs to be woken up, and (b) whether the poller needs to
> > + *    be rescheduled.
> > + *
> > + */
> >  
> >  static void dgnc_poll_handler(ulong dummy)
> >  {
> > -- 
> > 2.7.4
> 
> Changing first and last lines of that comment should be enough, but all
> lines got changed. I'd (re)submit it with just first and last lines
> changed.

Sorry, but I fail to see how I can align all the lines by changing just the first and last ones.

[toc] | [prev] | [next] | [standalone]

#1477472

On Tue, Sep 06, 2016 at 03:19:03PM +0200, Fernando Apesteguia wrote:
> Sorry, but I fail to see how I can align all the lines by changing just the first and last ones.

Ah now I see that original version doesn't have spaces before asterisk.
Sorry for noise.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web