Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1475893 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2016-09-04 11:10 +0200 |
| Last post | 2016-09-05 10:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] perf/x86: Use kmalloc_array() in merge_attr() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-04 11:10 +0200
Re: [PATCH] perf/x86: Use kmalloc_array() in merge_attr() Peter Zijlstra <peterz@infradead.org> - 2016-09-05 10:00 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-09-04 11:10 +0200 |
| Subject | [PATCH] perf/x86: Use kmalloc_array() in merge_attr() |
| Message-ID | <sdBB8-88b-19@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 4 Sep 2016 10:45:20 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- arch/x86/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index 18a1acf..f7f3578 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -1618,7 +1618,7 @@ __init struct attribute **merge_attr(struct attribute **a, struct attribute **b) j++; j++; - new = kmalloc(sizeof(struct attribute *) * j, GFP_KERNEL); + new = kmalloc_array(j, sizeof(*new), GFP_KERNEL); if (!new) return NULL; -- 2.9.3
[toc] | [next] | [standalone]
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2016-09-05 10:00 +0200 |
| Message-ID | <sdWYW-N5-13@gated-at.bofh.it> |
| In reply to | #1475893 |
On Sun, Sep 04, 2016 at 11:00:15AM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 4 Sep 2016 10:45:20 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. Why!?
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web