Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1475507 > unrolled thread

Re: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs

Started byCaesar Wang <wxt@rock-chips.com>
First post2016-09-03 02:20 +0200
Last post2016-09-05 01:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs Caesar Wang <wxt@rock-chips.com> - 2016-09-03 02:20 +0200
    Re: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs Heiko Stuebner <heiko@sntech.de> - 2016-09-05 00:10 +0200
      Re: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs Caesar Wang <wxt@rock-chips.com> - 2016-09-05 01:00 +0200

#1475507 — Re: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs

FromCaesar Wang <wxt@rock-chips.com>
Date2016-09-03 02:20 +0200
SubjectRe: [PATCH v2 0/2] arm64: dts: rockchip: Support PMU for rk3399 SoCs
Message-ID<sd6QF-6ph-3@gated-at.bofh.it>
Heiko,

What do you think of it?
Maybe I need re-update these patches on next kernel, and re-test them.

On 2016年07月06日 16:05, Caesar Wang wrote:
> Hello Heiko, Marc & ARM guys
>
> When Jay first submitted the rk3399.dtsi upstream
> <https://patchwork.kernel.org/patch/8885821/> he had the PMU node in there,
> but then took it out because the upstream binding wasn't done yet.
> It looks as if the upstream stuff has landed, since in linux/master I see:
> 287e9357abcc DT/arm,gic-v3: Documment PPI partition support
> e3825ba1af3a irqchip/gic-v3: Add support for partitioned PPIs
> 9e2c986cb460 irqchip: Add per-cpu interrupt partitioning library
> 222df54fd8b7 genirq: Allow the affinity of a percpu interrupt to be set/retrieved
> 651e8b54abde irqdomain: Allow domain matching on irq_fwspec
>
> This series patches add to support the rk3399 SoCs PMU.
> I pick up the https://patchwork.kernel.org/patch/9209369/.
>
> As do some tests with ChromeOs for my rk3399 board.
> Tested with linus master 4.7-rc6 kernel on rk3399 board.
> https://github.com/Caesar-github/rockchip/tree/rk3399/pmu-upstream
>
> localhost / # perf list
>
> List of pre-defined events (to be used in -e):
> cpu-cycles OR cycles [Hardware event]
> instructions [Hardware event]
> cache-references [Hardware event]
> cache-misses [Hardware event]
> branch-instructions OR branches [Hardware event]
> branch-misses [Hardware event]
> bus-cycles [Hardware event]
> ...
>
> perf stat --cpu 0/1/2/3..... to minitor
> e.g. cpu0;
>
> localhost / # perf stat --cpu 0
>
> Performance counter stats for 'CPU(s) 0':
>
> 3374.917571 task-clock (msec) # 1.001 CPUs utilized [100.00%]
> 20 context-switches # 0.006 K/sec [100.00%]
> 2 cpu-migrations # 0.001 K/sec [100.00%]
> 55 page-faults # 0.016 K/sec
> 7151843 cycles # 0.002 GHz [100.00%]
> <not supported> stalled-cycles-frontend
> <not supported> stalled-cycles-backend
> 4272536 instructions # 0.60 insns per cycle [100.00%]
> 568406 branches # 0.168 M/sec [100.00%]
> 65652 branch-misses # 11.55% of all branches
>
> Also, 'perf top' to monitor the PMU interrupts from cpus
>
> -Caesar
>
>
> Changes in v2:
> - AS Mark comments on https://patchwork.kernel.org/patch/9209369/
>    remove the interrupt-affinity property, we need depend on Marc' perf
>    code on https://patchwork.kernel.org/patch/9209369/.
>
> Caesar Wang (2):
>    arm64: dts: rockchip: change all interrupts cells for 4 on rk3399 SoCs
>    arm64: dts: rockchip: support the pmu node for rk3399
>
>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 118 ++++++++++++++++++-------------
>   1 file changed, 69 insertions(+), 49 deletions(-)
>


-- 
caesar wang | software engineer | wxt@rock-chip.com

[toc] | [next] | [standalone]

#1476047

FromHeiko Stuebner <heiko@sntech.de>
Date2016-09-05 00:10 +0200
Message-ID<sdNLX-3jM-17@gated-at.bofh.it>
In reply to#1475507
Hi Caesar,

Am Samstag, 3. September 2016, 08:13:17 CEST schrieb Caesar Wang:
> Heiko,
> 
> What do you think of it?
> Maybe I need re-update these patches on next kernel, and re-test them.

I checked linux-next and the underlying changes seem to all have gone in now, 
so we should be fine.

Updating the patches would be cool. I tried applying them to my dts64 branch 
just now, but they don't apply cleanly anymore due to other changes going in 
before.

When you check against linux-next, please take into account that there is no 
new linux-next since 20160825 and 20160905 is the next planned linux-next 
release (probably Stephen being on holiday).


Thanks
Heiko

> 
> On 2016年07月06日 16:05, Caesar Wang wrote:
> > Hello Heiko, Marc & ARM guys
> > 
> > When Jay first submitted the rk3399.dtsi upstream
> > <https://patchwork.kernel.org/patch/8885821/> he had the PMU node in
> > there,
> > but then took it out because the upstream binding wasn't done yet.
> > It looks as if the upstream stuff has landed, since in linux/master I see:
> > 287e9357abcc DT/arm,gic-v3: Documment PPI partition support
> > e3825ba1af3a irqchip/gic-v3: Add support for partitioned PPIs
> > 9e2c986cb460 irqchip: Add per-cpu interrupt partitioning library
> > 222df54fd8b7 genirq: Allow the affinity of a percpu interrupt to be
> > set/retrieved 651e8b54abde irqdomain: Allow domain matching on irq_fwspec
> > 
> > This series patches add to support the rk3399 SoCs PMU.
> > I pick up the https://patchwork.kernel.org/patch/9209369/.
> > 
> > As do some tests with ChromeOs for my rk3399 board.
> > Tested with linus master 4.7-rc6 kernel on rk3399 board.
> > https://github.com/Caesar-github/rockchip/tree/rk3399/pmu-upstream
> > 
> > localhost / # perf list
> > 
> > List of pre-defined events (to be used in -e):
> > cpu-cycles OR cycles [Hardware event]
> > instructions [Hardware event]
> > cache-references [Hardware event]
> > cache-misses [Hardware event]
> > branch-instructions OR branches [Hardware event]
> > branch-misses [Hardware event]
> > bus-cycles [Hardware event]
> > ...
> > 
> > perf stat --cpu 0/1/2/3..... to minitor
> > e.g. cpu0;
> > 
> > localhost / # perf stat --cpu 0
> > 
> > Performance counter stats for 'CPU(s) 0':
> > 
> > 3374.917571 task-clock (msec) # 1.001 CPUs utilized [100.00%]
> > 20 context-switches # 0.006 K/sec [100.00%]
> > 2 cpu-migrations # 0.001 K/sec [100.00%]
> > 55 page-faults # 0.016 K/sec
> > 7151843 cycles # 0.002 GHz [100.00%]
> > <not supported> stalled-cycles-frontend
> > <not supported> stalled-cycles-backend
> > 4272536 instructions # 0.60 insns per cycle [100.00%]
> > 568406 branches # 0.168 M/sec [100.00%]
> > 65652 branch-misses # 11.55% of all branches
> > 
> > Also, 'perf top' to monitor the PMU interrupts from cpus
> > 
> > -Caesar
> > 
> > 
> > Changes in v2:
> > - AS Mark comments on https://patchwork.kernel.org/patch/9209369/
> > 
> >    remove the interrupt-affinity property, we need depend on Marc' perf
> >    code on https://patchwork.kernel.org/patch/9209369/.
> > 
> > Caesar Wang (2):
> >    arm64: dts: rockchip: change all interrupts cells for 4 on rk3399 SoCs
> >    arm64: dts: rockchip: support the pmu node for rk3399
> >   
> >   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 118
> >   ++++++++++++++++++------------- 1 file changed, 69 insertions(+), 49
> >   deletions(-)

[toc] | [prev] | [next] | [standalone]

#1476052

FromCaesar Wang <wxt@rock-chips.com>
Date2016-09-05 01:00 +0200
Message-ID<sdOyl-3As-5@gated-at.bofh.it>
In reply to#1476047
On 2016年09月05日 06:09, Heiko Stuebner wrote:
> Hi Caesar,
>
> Am Samstag, 3. September 2016, 08:13:17 CEST schrieb Caesar Wang:
>> Heiko,
>>
>> What do you think of it?
>> Maybe I need re-update these patches on next kernel, and re-test them.
> I checked linux-next and the underlying changes seem to all have gone in now,
> so we should be fine.
>
> Updating the patches would be cool. I tried applying them to my dts64 branch
> just now, but they don't apply cleanly anymore due to other changes going in
> before.
>
> When you check against linux-next, please take into account that there is no
> new linux-next since 20160825 and 20160905 is the next planned linux-next
> release (probably Stephen being on holiday).

I will update/resend them base on your v4.9-armsoc/dts64 branch. (Wait a 
moment to retest them)

Thanks.


>
>
> Thanks
> Heiko
>
>> On 2016年07月06日 16:05, Caesar Wang wrote:
>>> Hello Heiko, Marc & ARM guys
>>>
>>> When Jay first submitted the rk3399.dtsi upstream
>>> <https://patchwork.kernel.org/patch/8885821/> he had the PMU node in
>>> there,
>>> but then took it out because the upstream binding wasn't done yet.
>>> It looks as if the upstream stuff has landed, since in linux/master I see:
>>> 287e9357abcc DT/arm,gic-v3: Documment PPI partition support
>>> e3825ba1af3a irqchip/gic-v3: Add support for partitioned PPIs
>>> 9e2c986cb460 irqchip: Add per-cpu interrupt partitioning library
>>> 222df54fd8b7 genirq: Allow the affinity of a percpu interrupt to be
>>> set/retrieved 651e8b54abde irqdomain: Allow domain matching on irq_fwspec
>>>
>>> This series patches add to support the rk3399 SoCs PMU.
>>> I pick up the https://patchwork.kernel.org/patch/9209369/.
>>>
>>> As do some tests with ChromeOs for my rk3399 board.
>>> Tested with linus master 4.7-rc6 kernel on rk3399 board.
>>> https://github.com/Caesar-github/rockchip/tree/rk3399/pmu-upstream
>>>
>>> localhost / # perf list
>>>
>>> List of pre-defined events (to be used in -e):
>>> cpu-cycles OR cycles [Hardware event]
>>> instructions [Hardware event]
>>> cache-references [Hardware event]
>>> cache-misses [Hardware event]
>>> branch-instructions OR branches [Hardware event]
>>> branch-misses [Hardware event]
>>> bus-cycles [Hardware event]
>>> ...
>>>
>>> perf stat --cpu 0/1/2/3..... to minitor
>>> e.g. cpu0;
>>>
>>> localhost / # perf stat --cpu 0
>>>
>>> Performance counter stats for 'CPU(s) 0':
>>>
>>> 3374.917571 task-clock (msec) # 1.001 CPUs utilized [100.00%]
>>> 20 context-switches # 0.006 K/sec [100.00%]
>>> 2 cpu-migrations # 0.001 K/sec [100.00%]
>>> 55 page-faults # 0.016 K/sec
>>> 7151843 cycles # 0.002 GHz [100.00%]
>>> <not supported> stalled-cycles-frontend
>>> <not supported> stalled-cycles-backend
>>> 4272536 instructions # 0.60 insns per cycle [100.00%]
>>> 568406 branches # 0.168 M/sec [100.00%]
>>> 65652 branch-misses # 11.55% of all branches
>>>
>>> Also, 'perf top' to monitor the PMU interrupts from cpus
>>>
>>> -Caesar
>>>
>>>
>>> Changes in v2:
>>> - AS Mark comments on https://patchwork.kernel.org/patch/9209369/
>>>
>>>     remove the interrupt-affinity property, we need depend on Marc' perf
>>>     code on https://patchwork.kernel.org/patch/9209369/.
>>>
>>> Caesar Wang (2):
>>>     arm64: dts: rockchip: change all interrupts cells for 4 on rk3399 SoCs
>>>     arm64: dts: rockchip: support the pmu node for rk3399
>>>    
>>>    arch/arm64/boot/dts/rockchip/rk3399.dtsi | 118
>>>    ++++++++++++++++++------------- 1 file changed, 69 insertions(+), 49
>>>    deletions(-)
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


-- 
caesar wang | software engineer | wxt@rock-chip.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web