Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472854 > unrolled thread

[PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 22:40 +0200
    Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-08-31 00:20 +0200
      Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 16:50 +0200
        Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-08-31 22:30 +0200
          Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 23:20 +0200
            Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-09-01 16:00 +0200

#1472854 — [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue

The workqueue "afs_async_calls" queues a single work item viz
&call->async_work and hence it doesn't require execution ordering.
Hence, alloc_workqueue has been used to replace the deprecated
create_singlethread_workqueue instance.

The WQ_MEM_RECLAIM flag has been set to ensure forward progress under
memory pressure because the workqueue is being used on a memory reclaim
path.

Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 Changes in v2:
	-No change

 fs/afs/rxrpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c
index 63cd9f9..4f9e9b3 100644
--- a/fs/afs/rxrpc.c
+++ b/fs/afs/rxrpc.c
@@ -85,7 +85,7 @@ int afs_open_socket(void)

 	skb_queue_head_init(&afs_incoming_calls);

-	afs_async_calls = create_singlethread_workqueue("kafsd");
+	afs_async_calls = alloc_workqueue("kafsd", WQ_MEM_RECLAIM, 0);
 	if (!afs_async_calls) {
 		_leave(" = -ENOMEM [wq]");
 		return -ENOMEM;
--
2.1.4

[toc] | [next] | [standalone]

#1472909 — Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue

Bhaktipriya Shridhar <bhaktipriya96@gmail.com> wrote:

> The workqueue "afs_async_calls" queues a single work item viz
> &call->async_work and hence it doesn't require execution ordering.
> ...
> Since there are fixed number of work items, explicit concurrency
> limit is unnecessary here.

There can be more than one single call and there's no fixed number.

> The workqueue "afs_lock_manager" queues a single work item
> &vnode->lock_work, and hence it doesn't require execution ordering.
> ...
> Since there are fixed number of work items, explicit concurrency
> limit is unnecessary here.

There may be more than one single vnode and there's no fixed number.

David

[toc] | [prev] | [next] | [standalone]

#1473574

On Tue, Aug 30, 2016 at 11:15:43PM +0100, David Howells wrote:
> Bhaktipriya Shridhar <bhaktipriya96@gmail.com> wrote:
> 
> > The workqueue "afs_async_calls" queues a single work item viz
> > &call->async_work and hence it doesn't require execution ordering.
> > ...
> > Since there are fixed number of work items, explicit concurrency
> > limit is unnecessary here.
> 
> There can be more than one single call and there's no fixed number.
> 
> > The workqueue "afs_lock_manager" queues a single work item
> > &vnode->lock_work, and hence it doesn't require execution ordering.
> > ...
> > Since there are fixed number of work items, explicit concurrency
> > limit is unnecessary here.
> 
> There may be more than one single vnode and there's no fixed number.

Ah, okay, the work items are dynamically allocated.  Do they need
strict execution ordering or can they be executed concurrently?

Thanks.

-- 
tejun

[toc] | [prev] | [next] | [standalone]

#1473828 — Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue

Tejun Heo <tj@kernel.org> wrote:

> Ah, okay, the work items are dynamically allocated.  Do they need
> strict execution ordering or can they be executed concurrently?

Concurrently is fine.

David

[toc] | [prev] | [next] | [standalone]

#1473887

Hello, David.

On Wed, Aug 31, 2016 at 09:24:40PM +0100, David Howells wrote:
> Tejun Heo <tj@kernel.org> wrote:
> 
> > Ah, okay, the work items are dynamically allocated.  Do they need
> > strict execution ordering or can they be executed concurrently?
> 
> Concurrently is fine.

I see.  Bhaktpriya, can you please update the patch description?  The
code itself should be fine, I think.

Thanks for the clarification.

-- 
tejun

[toc] | [prev] | [next] | [standalone]

#1474410 — Re: [PATCH v2 2/4] fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue

On Thu, Sep 1, 2016 at 2:47 AM, Tejun Heo <tj@kernel.org> wrote:
> On Wed, Aug 31, 2016 at 09:24:40PM +0100, David Howells wrote:
>> Concurrently is fine.
>
> I see.  Bhaktpriya, can you please update the patch description?  The
> code itself should be fine, I think.
>
Sure. Will update it in v2.

Thanks,
Bhaktipriya

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web