Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473286 > unrolled thread

Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around  mappings Greg KH <gregkh@linuxfoundation.org> - 2016-08-31 12:50 +0200
    RE: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around  mappings KY Srinivasan <kys@microsoft.com> - 2016-08-31 20:20 +0200

#1473286 — Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings

On Wed, Jul 06, 2016 at 05:25:02PM -0700, kys@exchange.microsoft.com wrote:
> From: Vitaly Kuznetsov <vkuznets@redhat.com>
> 
> In preparation for doing wrap around mappings for ring buffers cleanup
> vmbus_open() function:
> - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel
>   drivers now);
> - kfree(open_info) on error only after we kzalloc() it (not an issue as it
>   is valid to call kfree(NULL);
> - rename poorly named labels;
> - use alloc_pages() instead of __get_free_pages() as we need struct page
>   pointer for future.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Tested-by: Dexuan Cui <decui@microsoft.com>
> ---
>  drivers/hv/channel.c |   43 +++++++++++++++++++++++--------------------
>  1 files changed, 23 insertions(+), 20 deletions(-)

This patch doesn't apply to the tree due to the other hv patches you
sent.  Can you respin this series and resend?

thanks,

greg k-h

[toc] | [next] | [standalone]

#1473781

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Wednesday, August 31, 2016 4:13 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com;
> jasowang@redhat.com; leann.ogasawara@canonical.com
> Subject: Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around
> mappings
> 
> On Wed, Jul 06, 2016 at 05:25:02PM -0700, kys@exchange.microsoft.com
> wrote:
> > From: Vitaly Kuznetsov <vkuznets@redhat.com>
> >
> > In preparation for doing wrap around mappings for ring buffers cleanup
> > vmbus_open() function:
> > - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel
> >   drivers now);
> > - kfree(open_info) on error only after we kzalloc() it (not an issue as it
> >   is valid to call kfree(NULL);
> > - rename poorly named labels;
> > - use alloc_pages() instead of __get_free_pages() as we need struct page
> >   pointer for future.
> >
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Tested-by: Dexuan Cui <decui@microsoft.com>
> > ---
> >  drivers/hv/channel.c |   43 +++++++++++++++++++++++--------------------
> >  1 files changed, 23 insertions(+), 20 deletions(-)
> 
> This patch doesn't apply to the tree due to the other hv patches you
> sent.  Can you respin this series and resend?

Will do.

Regards,

K. Y
> 
> thanks,
> 
> greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web