Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1472629 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2016-08-30 18:40 +0200 |
| Last post | 2016-09-02 01:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] bonding: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 18:40 +0200
Re: [PATCH] bonding: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-31 16:10 +0200
Re: [PATCH] bonding: Remove deprecated create_singlethread_workqueue David Miller <davem@davemloft.net> - 2016-09-02 01:50 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-08-30 18:40 +0200 |
| Subject | [PATCH] bonding: Remove deprecated create_singlethread_workqueue |
| Message-ID | <sbUeS-7ka-13@gated-at.bofh.it> |
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces deprecated create_singlethread_workqueue(). This is the identity conversion. The workqueue "wq" queues multiple work items viz &bond->mcast_work, &nnw->work, &bond->mii_work, &bond->arp_work, &bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work which require strict execution ordering. Hence, an ordered dedicated workqueue has been used. Since, it is a network driver, WQ_MEM_RECLAIM has been set to ensure forward progress under memory pressure. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 941ec99..ebaf1a9 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -4635,7 +4635,7 @@ static int bond_init(struct net_device *bond_dev) netdev_dbg(bond_dev, "Begin bond_init\n"); - bond->wq = create_singlethread_workqueue(bond_dev->name); + bond->wq = alloc_ordered_workqueue(bond_dev->name, WQ_MEM_RECLAIM); if (!bond->wq) return -ENOMEM; -- 2.1.4
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2016-08-31 16:10 +0200 |
| Message-ID | <sceng-3nc-27@gated-at.bofh.it> |
| In reply to | #1472629 |
On Tue, Aug 30, 2016 at 10:02:01PM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > The workqueue "wq" queues multiple work items viz > &bond->mcast_work, &nnw->work, &bond->mii_work, &bond->arp_work, > &bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work > which require strict execution ordering. Hence, an ordered dedicated > workqueue has been used. > > Since, it is a network driver, WQ_MEM_RECLAIM has been set to > ensure forward progress under memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-09-02 01:50 +0200 |
| Subject | Re: [PATCH] bonding: Remove deprecated create_singlethread_workqueue |
| Message-ID | <scJU5-8tP-5@gated-at.bofh.it> |
| In reply to | #1472629 |
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Date: Tue, 30 Aug 2016 22:02:01 +0530 > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > The workqueue "wq" queues multiple work items viz > &bond->mcast_work, &nnw->work, &bond->mii_work, &bond->arp_work, > &bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work > which require strict execution ordering. Hence, an ordered dedicated > workqueue has been used. > > Since, it is a network driver, WQ_MEM_RECLAIM has been set to > ensure forward progress under memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web