Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471805 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-08-29 14:50 +0200 |
| Last post | 2016-08-31 16:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] crypto: hide unused label Arnd Bergmann <arnd@arndb.de> - 2016-08-29 14:50 +0200
Re: [PATCH v2] crypto: hide unused label Herbert Xu <herbert@gondor.apana.org.au> - 2016-08-31 16:40 +0200
Re: [PATCH v2] crypto: hide unused label Arnd Bergmann <arnd@arndb.de> - 2016-08-31 16:50 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-08-29 14:50 +0200 |
| Subject | [PATCH v2] crypto: hide unused label |
| Message-ID | <sbuaK-7mV-11@gated-at.bofh.it> |
A recent change left an existing label unused in some configurations,
as seen from a gcc warning:
crypto/xor.c: In function 'calibrate_xor_blocks':
crypto/xor.c:156:1: error: label 'out' defined but not used [-Werror=unused-label]
This adds an #ifdef around it to match the one around the respective "goto".
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 39457acda913 ("crypto: xor - skip speed test if the xor function is selected automatically")
---
v2: add proper changelog, sorry for missing that at first.
---
crypto/xor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/crypto/xor.c b/crypto/xor.c
index b8975d92cd94..1817015381ef 100644
--- a/crypto/xor.c
+++ b/crypto/xor.c
@@ -153,7 +153,9 @@ calibrate_xor_blocks(void)
#undef xor_speed
free_pages((unsigned long)b1, 2);
+#ifdef XOR_SELECT_TEMPLATE
out:
+#endif
active_template = fastest;
return 0;
}
--
2.9.0
[toc] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-08-31 16:40 +0200 |
| Message-ID | <sceQi-3B0-19@gated-at.bofh.it> |
| In reply to | #1471805 |
On Mon, Aug 29, 2016 at 02:40:43PM +0200, Arnd Bergmann wrote:
> A recent change left an existing label unused in some configurations,
> as seen from a gcc warning:
>
> crypto/xor.c: In function 'calibrate_xor_blocks':
> crypto/xor.c:156:1: error: label 'out' defined but not used [-Werror=unused-label]
>
> This adds an #ifdef around it to match the one around the respective "goto".
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 39457acda913 ("crypto: xor - skip speed test if the xor function is selected automatically")
Thanks for the patch. But I've already queued up a fix at
https://patchwork.kernel.org/patch/9301603/
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-08-31 16:50 +0200 |
| Message-ID | <sceZY-3Ew-41@gated-at.bofh.it> |
| In reply to | #1473548 |
On Wednesday, August 31, 2016 10:37:52 PM CEST Herbert Xu wrote:
> On Mon, Aug 29, 2016 at 02:40:43PM +0200, Arnd Bergmann wrote:
> > A recent change left an existing label unused in some configurations,
> > as seen from a gcc warning:
> >
> > crypto/xor.c: In function 'calibrate_xor_blocks':
> > crypto/xor.c:156:1: error: label 'out' defined but not used [-Werror=unused-label]
> >
> > This adds an #ifdef around it to match the one around the respective "goto".
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 39457acda913 ("crypto: xor - skip speed test if the xor function is selected automatically")
>
> Thanks for the patch. But I've already queued up a fix at
>
> https://patchwork.kernel.org/patch/9301603/
>
Ok, that one looks like a nicer solution anyway.
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web