Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472153 > unrolled thread

Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

Started bySteven Rostedt <rostedt@goodmis.org>
First post2016-08-30 01:10 +0200
Last post2016-08-31 14:10 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Steven Rostedt <rostedt@goodmis.org> - 2016-08-30 01:10 +0200
    Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Dmitry Safonov <0x7f454c46@gmail.com> - 2016-08-30 01:10 +0200
    Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Oleg Nesterov <oleg@redhat.com> - 2016-08-30 16:40 +0200
      Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Steven Rostedt <rostedt@goodmis.org> - 2016-08-30 23:20 +0200
        Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Oleg Nesterov <oleg@redhat.com> - 2016-08-31 14:10 +0200

#1472153 — Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

FromSteven Rostedt <rostedt@goodmis.org>
Date2016-08-30 01:10 +0200
SubjectRe: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe
Message-ID<sbDQK-5dS-1@gated-at.bofh.it>
On Mon, 29 Aug 2016 18:58:13 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 25 Aug 2016 18:21:09 +0300
> Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> 
> > It's useless. Before:
> >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
> >   -bash: echo: write error: No such file or directory
> >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> >   -bash: echo: write error: Invalid argument
> > 
> > After:
> >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> >   -bash: echo: write error: No such file or directory
> > 
> > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>  
> 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Actually, this patch seems agnostic to the series. I'll just pull it in
now.

-- Steve

> 
> > ---
> >  kernel/trace/trace_uprobe.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> > index c53485441c88..a74f2d9ff379 100644
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
> >  		pr_info("Probe point is not specified.\n");
> >  		return -EINVAL;
> >  	}
> > -	if (isdigit(argv[1][0])) {
> > -		pr_info("probe point must be have a filename.\n");
> > -		return -EINVAL;
> > -	}
> >  	arg = strchr(argv[1], ':');
> >  	if (!arg) {
> >  		ret = -EINVAL;  
>

[toc] | [next] | [standalone]

#1472154

FromDmitry Safonov <0x7f454c46@gmail.com>
Date2016-08-30 01:10 +0200
Message-ID<sbDQK-5dS-9@gated-at.bofh.it>
In reply to#1472153
2016-08-30 1:59 GMT+03:00 Steven Rostedt <rostedt@goodmis.org>:
> On Mon, 29 Aug 2016 18:58:13 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> On Thu, 25 Aug 2016 18:21:09 +0300
>> Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
>>
>> > It's useless. Before:
>> >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
>> >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
>> >   -bash: echo: write error: No such file or directory
>> >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
>> >   -bash: echo: write error: Invalid argument
>> >
>> > After:
>> >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
>> >   -bash: echo: write error: No such file or directory
>> >
>> > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
>>
>> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> Actually, this patch seems agnostic to the series. I'll just pull it in
> now.

Thanks, Steve!

-- 
             Dmitry

[toc] | [prev] | [next] | [standalone]

#1472520

FromOleg Nesterov <oleg@redhat.com>
Date2016-08-30 16:40 +0200
Message-ID<sbSmJ-67O-7@gated-at.bofh.it>
In reply to#1472153
On 08/29, Steven Rostedt wrote:
>
> On Mon, 29 Aug 2016 18:58:13 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > On Thu, 25 Aug 2016 18:21:09 +0300
> > Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> >
> > > It's useless. Before:
> > >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> > >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
> > >   -bash: echo: write error: No such file or directory
> > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > >   -bash: echo: write error: Invalid argument
> > > 
> > > After:
> > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > >   -bash: echo: write error: No such file or directory
> > > 
> > > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>  
> > 
> > Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> Actually, this patch seems agnostic to the series. I'll just pull it in
> now.

Yes, agreed, this isdigit() is pointless, thanks.

Oleg.

[toc] | [prev] | [next] | [standalone]

#1472883

FromSteven Rostedt <rostedt@goodmis.org>
Date2016-08-30 23:20 +0200
Message-ID<sbYBP-1MV-5@gated-at.bofh.it>
In reply to#1472520
On Tue, 30 Aug 2016 16:37:28 +0200
Oleg Nesterov <oleg@redhat.com> wrote:

> On 08/29, Steven Rostedt wrote:
> >
> > On Mon, 29 Aug 2016 18:58:13 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >  
> > > On Thu, 25 Aug 2016 18:21:09 +0300
> > > Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> > >  
> > > > It's useless. Before:
> > > >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> > > >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
> > > >   -bash: echo: write error: No such file or directory
> > > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > > >   -bash: echo: write error: Invalid argument
> > > > 
> > > > After:
> > > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > > >   -bash: echo: write error: No such file or directory
> > > > 
> > > > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>    
> > > 
> > > Acked-by: Steven Rostedt <rostedt@goodmis.org>  
> >
> > Actually, this patch seems agnostic to the series. I'll just pull it in
> > now.  
> 
> Yes, agreed, this isdigit() is pointless, thanks.

Should I put you down as an Acked-by?

-- Steve

[toc] | [prev] | [next] | [standalone]

#1473382

FromOleg Nesterov <oleg@redhat.com>
Date2016-08-31 14:10 +0200
Message-ID<sccv8-2fs-39@gated-at.bofh.it>
In reply to#1472883
On 08/30, Steven Rostedt wrote:
>
> On Tue, 30 Aug 2016 16:37:28 +0200
> Oleg Nesterov <oleg@redhat.com> wrote:
> 
> > On 08/29, Steven Rostedt wrote:
> > >
> > >
> > > Actually, this patch seems agnostic to the series. I'll just pull it in
> > > now.  
> > 
> > Yes, agreed, this isdigit() is pointless, thanks.
> 
> Should I put you down as an Acked-by?

Thanks, feel free to add my ack.

Oleg.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web