Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473186 > unrolled thread
| Started by | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| First post | 2016-08-31 10:40 +0200 |
| Last post | 2016-09-05 19:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: focaltech - mark focaltech_set_resolution() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-31 10:40 +0200
Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static Arnd Bergmann <arnd@arndb.de> - 2016-08-31 12:10 +0200
Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-05 19:40 +0200
| From | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| Date | 2016-08-31 10:40 +0200 |
| Subject | [PATCH] Input: focaltech - mark focaltech_set_resolution() static |
| Message-ID | <sc9dU-5u-15@gated-at.bofh.it> |
We get 1 warning when building kernel with W=1:
drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/input/mouse/focaltech.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c
index c8c6a8c..d3ca02a 100644
--- a/drivers/input/mouse/focaltech.c
+++ b/drivers/input/mouse/focaltech.c
@@ -390,7 +390,8 @@ static int focaltech_read_size(struct psmouse *psmouse)
return 0;
}
-void focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution)
+static void
+focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution)
{
/* not supported yet */
}
--
2.7.4
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-08-31 12:10 +0200 |
| Message-ID | <scaD0-13d-9@gated-at.bofh.it> |
| In reply to | #1473186 |
On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Acked-by: Arnd Bergmann <arnd@arndb.de>
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-09-05 19:40 +0200 |
| Message-ID | <se62f-6Q9-81@gated-at.bofh.it> |
| In reply to | #1473245 |
On Wed, Aug 31, 2016 at 11:58:50AM +0200, Arnd Bergmann wrote: > On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > So this patch marks it 'static'. > > > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> Applied, thank you. -- Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web