Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471776 > unrolled thread
| Started by | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| First post | 2016-08-29 14:30 +0200 |
| Last post | 2016-09-02 18:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] ath9k: mark ath_fill_led_pin() static Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-29 14:30 +0200
Re: [v2] ath9k: mark ath_fill_led_pin() static Kalle Valo <kvalo@qca.qualcomm.com> - 2016-09-02 18:10 +0200
| From | Baoyou Xie <baoyou.xie@linaro.org> |
|---|---|
| Date | 2016-08-29 14:30 +0200 |
| Subject | [PATCH v2] ath9k: mark ath_fill_led_pin() static |
| Message-ID | <sbtRo-7g9-21@gated-at.bofh.it> |
We get 1 warning about global functions without a declaration
in the ath9k gpio driver when building with W=1:
drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared
and don't need a declaration, but can be made static.
so this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/net/wireless/ath/ath9k/gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c
index 490f74d..ddb2886 100644
--- a/drivers/net/wireless/ath/ath9k/gpio.c
+++ b/drivers/net/wireless/ath/ath9k/gpio.c
@@ -22,7 +22,7 @@
#ifdef CONFIG_MAC80211_LEDS
-void ath_fill_led_pin(struct ath_softc *sc)
+static void ath_fill_led_pin(struct ath_softc *sc)
{
struct ath_hw *ah = sc->sc_ah;
--
2.7.4
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@qca.qualcomm.com> |
|---|---|
| Date | 2016-09-02 18:10 +0200 |
| Subject | Re: [v2] ath9k: mark ath_fill_led_pin() static |
| Message-ID | <scZct-1CU-29@gated-at.bofh.it> |
| In reply to | #1471776 |
Baoyou Xie <baoyou.xie@linaro.org> wrote: > We get 1 warning about global functions without a declaration > in the ath9k gpio driver when building with W=1: > drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> Thanks, 1 patch applied to ath-next branch of ath.git: c39265f72ae6 ath9k: mark ath_fill_led_pin() static -- Sent by pwcli https://patchwork.kernel.org/patch/9303795/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web