Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1473015 > unrolled thread
| Started by | Ian Kent <raven@themaw.net> |
|---|---|
| First post | 2016-08-31 05:40 +0200 |
| Last post | 2016-08-31 05:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH 1/3] autofs: remove possibly misleading /* #define DEBUG */ Ian Kent <raven@themaw.net> - 2016-08-31 05:40 +0200
| From | Ian Kent <raven@themaw.net> |
|---|---|
| Date | 2016-08-31 05:40 +0200 |
| Subject | [PATCH 1/3] autofs: remove possibly misleading /* #define DEBUG */ |
| Message-ID | <sc4xz-5tQ-9@gated-at.bofh.it> |
From: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Having this in autofs_i.h gives illusion that uncommenting this enables pr_debug(), but it doesn't enable all the pr_debug() in autofs because inclusion order matters. XFS has the same DEBUG macro in its core header fs/xfs/xfs.h, however XFS seems to have a rule to include this prior to other XFS headers as well as kernel headers. This is not the case with autofs, and DEBUG could be enabled via Makefile, so autofs should just get rid of this comment to make the code less confusing. It's a comment, so there is literally no functional difference. Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> Signed-off-by: Ian Kent <raven@themaw.net> --- fs/autofs4/autofs_i.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index dd71bd4..4404a22 100644 --- a/fs/autofs4/autofs_i.h +++ b/fs/autofs4/autofs_i.h @@ -34,8 +34,6 @@ #include <asm/current.h> #include <linux/uaccess.h> -/* #define DEBUG */ - #ifdef pr_fmt #undef pr_fmt #endif
Back to top | Article view | linux.kernel
csiph-web