Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1471756 > unrolled thread

Re: NULL-ptr deref in kvm_arch_vcpu_ioctl under AMD CPUs

Started byPaolo Bonzini <pbonzini@redhat.com>
First post2016-08-29 14:10 +0200
Last post2016-08-30 17:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: NULL-ptr deref in kvm_arch_vcpu_ioctl under AMD CPUs Paolo Bonzini <pbonzini@redhat.com> - 2016-08-29 14:10 +0200
    Re: NULL-ptr deref in kvm_arch_vcpu_ioctl under AMD CPUs Dmitry Vyukov <dvyukov@google.com> - 2016-08-30 15:10 +0200
      Re: NULL-ptr deref in kvm_arch_vcpu_ioctl under AMD CPUs Paolo Bonzini <pbonzini@redhat.com> - 2016-08-30 17:10 +0200

#1471756 — Re: NULL-ptr deref in kvm_arch_vcpu_ioctl under AMD CPUs

FromPaolo Bonzini <pbonzini@redhat.com>
Date2016-08-29 14:10 +0200
SubjectRe: NULL-ptr deref in kvm_arch_vcpu_ioctl under AMD CPUs
Message-ID<sbty1-77M-13@gated-at.bofh.it>

On 19/08/2016 02:16, Dmitry Vyukov wrote:
> > > This seems non-exploitable due to mmap_min_addr, so I guess it should
> > > be treated just as a regular bug
> >
> > Probably fixed by commit 4c5ea0a9cd02 ("locking/static_key: Fix
> > concurrent static_key_slow_inc()", 2016-06-21).  There should be no
> > outstanding syzkaller reports for KVM now!
>
> Thanks for the update. I will try to reenable kvm fuzzing on my
> syzkaller instances.
> Just to make sure, you mean all bugs prefixed with kvm: here, right?
> https://github.com/google/syzkaller/wiki/Found-Bugs

Yes.  These are the relevant commits:

b21629da120   kvm: x86: avoid warning on repeated KVM_SET_TSS_ADDR
83676e92389   KVM: x86: avoid vmalloc(0) in the KVM_SET_CPUID
78e546c824f   KVM: fail KVM_SET_VCPU_EVENTS with invalid exception number
c622a3c21ed   KVM: irqfd: fix NULL pointer dereference in kvm_irq_map_gsi
f8c1b85b252   KVM: x86: avoid vmalloc(0) in the KVM_SET_CPUID
d14bdb553f9   KVM: x86: fix OOPS after invalid KVM_SET_DEBUGREGS
250715a6171   KVM: x86: protect KVM_CREATE_PIT/KVM_CREATE_PIT2 with kvm->lock
4c5ea0a9cd0   locking/static_key: Fix concurrent static_key_slow_inc()

The last one is responsible for most if not all of the OOPses with
threads.

Paolo

[toc] | [next] | [standalone]


#1472476

FromDmitry Vyukov <dvyukov@google.com>
Date2016-08-30 15:10 +0200
Message-ID<sbQXD-5kV-15@gated-at.bofh.it>
In reply to#1471756
On Mon, Aug 29, 2016 at 2:02 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 19/08/2016 02:16, Dmitry Vyukov wrote:
>> > > This seems non-exploitable due to mmap_min_addr, so I guess it should
>> > > be treated just as a regular bug
>> >
>> > Probably fixed by commit 4c5ea0a9cd02 ("locking/static_key: Fix
>> > concurrent static_key_slow_inc()", 2016-06-21).  There should be no
>> > outstanding syzkaller reports for KVM now!
>>
>> Thanks for the update. I will try to reenable kvm fuzzing on my
>> syzkaller instances.
>> Just to make sure, you mean all bugs prefixed with kvm: here, right?
>> https://github.com/google/syzkaller/wiki/Found-Bugs
>
> Yes.  These are the relevant commits:
>
> b21629da120   kvm: x86: avoid warning on repeated KVM_SET_TSS_ADDR
> 83676e92389   KVM: x86: avoid vmalloc(0) in the KVM_SET_CPUID
> 78e546c824f   KVM: fail KVM_SET_VCPU_EVENTS with invalid exception number
> c622a3c21ed   KVM: irqfd: fix NULL pointer dereference in kvm_irq_map_gsi
> f8c1b85b252   KVM: x86: avoid vmalloc(0) in the KVM_SET_CPUID
> d14bdb553f9   KVM: x86: fix OOPS after invalid KVM_SET_DEBUGREGS
> 250715a6171   KVM: x86: protect KVM_CREATE_PIT/KVM_CREATE_PIT2 with kvm->lock
> 4c5ea0a9cd0   locking/static_key: Fix concurrent static_key_slow_inc()
>
> The last one is responsible for most if not all of the OOPses with
> threads.


I've started fuzzing kvm again. No crashes so far.

[toc] | [prev] | [next] | [standalone]


#1472545

FromPaolo Bonzini <pbonzini@redhat.com>
Date2016-08-30 17:10 +0200
Message-ID<sbSPM-6x2-33@gated-at.bofh.it>
In reply to#1472476

On 30/08/2016 15:08, Dmitry Vyukov wrote:
>> > b21629da120   kvm: x86: avoid warning on repeated KVM_SET_TSS_ADDR
>> > 83676e92389   KVM: x86: avoid vmalloc(0) in the KVM_SET_CPUID
>> > 78e546c824f   KVM: fail KVM_SET_VCPU_EVENTS with invalid exception number
>> > c622a3c21ed   KVM: irqfd: fix NULL pointer dereference in kvm_irq_map_gsi
>> > f8c1b85b252   KVM: x86: avoid vmalloc(0) in the KVM_SET_CPUID
>> > d14bdb553f9   KVM: x86: fix OOPS after invalid KVM_SET_DEBUGREGS
>> > 250715a6171   KVM: x86: protect KVM_CREATE_PIT/KVM_CREATE_PIT2 with kvm->lock
>> > 4c5ea0a9cd0   locking/static_key: Fix concurrent static_key_slow_inc()
>> >
>> > The last one is responsible for most if not all of the OOPses with
>> > threads.
> 
> I've started fuzzing kvm again. No crashes so far.

Fingers crossed! :)

Paolo

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web