Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1471640 > unrolled thread

[PATCH v3] brcmfmac: add missing header dependencies

Started byBaoyou Xie <baoyou.xie@linaro.org>
First post2016-08-29 10:30 +0200
Last post2016-08-29 11:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v3] brcmfmac: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-29 10:30 +0200
    Re: [PATCH v3] brcmfmac: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-08-29 11:10 +0200

#1471640 — [PATCH v3] brcmfmac: add missing header dependencies

FromBaoyou Xie <baoyou.xie@linaro.org>
Date2016-08-29 10:30 +0200
Subject[PATCH v3] brcmfmac: add missing header dependencies
Message-ID<sbq78-4Wv-15@gated-at.bofh.it>
We get 1 warning when biuld kernel with W=1:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]

In fact, this function is declared in brcmfmac/debug.h, so this patch
add missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
index a10f35c..fe67559 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
@@ -19,6 +19,7 @@
 #ifndef __CHECKER__
 #define CREATE_TRACE_POINTS
 #include "tracepoint.h"
+#include "debug.h"
 
 void __brcmf_err(const char *func, const char *fmt, ...)
 {
-- 
2.7.4

[toc] | [next] | [standalone]


#1471656

FromArnd Bergmann <arnd@arndb.de>
Date2016-08-29 11:10 +0200
Message-ID<sbqJP-5oR-5@gated-at.bofh.it>
In reply to#1471640
On Monday, August 29, 2016 4:14:45 PM CEST Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
> 
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web