Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1471539 > unrolled thread

Build error in timer-atmel-pit.c

Back to article view | Back to linux.kernel

Contents

  Build error in timer-atmel-pit.c Brent Taylor <motobud@gmail.com> - 2016-08-29 06:50 +0200
    [PATCH] clocksource/drivers/atmel-pit: Fix compilation error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-29 08:50 +0200
      Re: [PATCH] clocksource/drivers/atmel-pit: Fix compilation error Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-08-29 09:00 +0200
      [tip:timers/urgent] clocksource/drivers/atmel-pit: Fix compilation  error tip-bot for Daniel Lezcano <tipbot@zytor.com> - 2016-08-29 10:10 +0200

#1471539 — Build error in timer-atmel-pit.c

Daniel,
   After updating to linux-4.8-rc4, I got the following build error:

linux-x.yy/drivers/clocksource/timer-atmel-pit.c: In function
'at91sam926x_pit_dt_init':
linux-x.yy/drivers/clocksource/timer-atmel-pit.c:264:2: error: 'ret'
undeclared (first use in this function)
  ret = clk_prepare_enable(data->mck);
  ^~~
linux-x.yy/drivers/clocksource/timer-atmel-pit.c:264:2: note: each
undeclared identifier is reported only once for each function it
appears in

This was introduced in commit: 699e36e5b8e9f77b2be4c23f0b309e53be4b2880

Regards,
Brent Taylor

[toc] | [next] | [standalone]

#1471569 — [PATCH] clocksource/drivers/atmel-pit: Fix compilation error

The previous fix introduced a check against the ret variable which
is not defined, hence producing a compilation error:

linux/drivers/clocksource/timer-atmel-pit.c: In function ‘at91sam926x_pit_dt_init’:
linux/drivers/clocksource/timer-atmel-pit.c:264:2: error: ‘ret’ undeclared (first use in this function)
  ret = clk_prepare_enable(data->mck);
  ^
linux/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in

Add the missing the variable 'ret'.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/timer-atmel-pit.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 3494bc5..7f0f5b2 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -240,6 +240,7 @@ static int __init at91sam926x_pit_common_init(struct pit_data *data)
 static int __init at91sam926x_pit_dt_init(struct device_node *node)
 {
 	struct pit_data *data;
+	int ret;
 
 	data = kzalloc(sizeof(*data), GFP_KERNEL);
 	if (!data)
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1471579 — Re: [PATCH] clocksource/drivers/atmel-pit: Fix compilation error

On 08/29/2016 08:44 AM, Daniel Lezcano wrote:
> The previous fix introduced a check against the ret variable which
> is not defined, hence producing a compilation error:
> 
> linux/drivers/clocksource/timer-atmel-pit.c: In function ‘at91sam926x_pit_dt_init’:
> linux/drivers/clocksource/timer-atmel-pit.c:264:2: error: ‘ret’ undeclared (first use in this function)
>   ret = clk_prepare_enable(data->mck);
>   ^
> linux/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in
> 
> Add the missing the variable 'ret'.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---

Thomas,

do you mind to directly apply this patch ?

Thanks

  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[toc] | [prev] | [next] | [standalone]

#1471614 — [tip:timers/urgent] clocksource/drivers/atmel-pit: Fix compilation error

Commit-ID:  98744b408c757901df57fa50cbd5826245dc3a1f
Gitweb:     http://git.kernel.org/tip/98744b408c757901df57fa50cbd5826245dc3a1f
Author:     Daniel Lezcano <daniel.lezcano@linaro.org>
AuthorDate: Mon, 29 Aug 2016 08:44:03 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 29 Aug 2016 09:51:39 +0200

clocksource/drivers/atmel-pit: Fix compilation error

The previous fix introduced a check against the ret variable which
is not defined, hence producing a compilation error:

linux/drivers/clocksource/timer-atmel-pit.c: In function ‘at91sam926x_pit_dt_init’:
linux/drivers/clocksource/timer-atmel-pit.c:264:2: error: ‘ret’ undeclared (first use in this function)
  ret = clk_prepare_enable(data->mck);
  ^
linux/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in

Add the missing the variable 'ret'.

Fixes: 504f34c9e45c "clocksource/drivers/atmel-pit: Convert init function to return error"
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: alexandre.belloni@free-electrons.com
Cc: motobud@gmail.com
Cc: realbright@lgcns.com
Link: http://lkml.kernel.org/r/1472453043-24287-1-git-send-email-daniel.lezcano@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 drivers/clocksource/timer-atmel-pit.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index 3494bc5..7f0f5b2 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -240,6 +240,7 @@ static int __init at91sam926x_pit_common_init(struct pit_data *data)
 static int __init at91sam926x_pit_dt_init(struct device_node *node)
 {
 	struct pit_data *data;
+	int ret;
 
 	data = kzalloc(sizeof(*data), GFP_KERNEL);
 	if (!data)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web