Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472817 > unrolled thread

[PATCH net-next 0/1] rxrpc: Remove use of skbs from AFS [ver #2]

Back to article view | Back to linux.kernel

Contents

  [PATCH net-next 0/1] rxrpc: Remove use of skbs from AFS [ver #2] David Howells <dhowells@redhat.com> - 2016-08-30 21:50 +0200
    Re: [PATCH net-next 1/1] rxrpc: Don't expose skbs to in-kernel  users [ver #2] David Miller <davem@davemloft.net> - 2016-09-02 01:50 +0200
      Re: [PATCH net-next 1/1] rxrpc: Don't expose skbs to in-kernel users [ver #2] David Howells <dhowells@redhat.com> - 2016-09-02 08:10 +0200

#1472817 — [PATCH net-next 0/1] rxrpc: Remove use of skbs from AFS [ver #2]

Here's a single patch that removes the use of sk_buffs from fs/afs.  From
this point on they'll be entirely retained within net/rxrpc and AFS just
asks AF_RXRPC for linear buffers of data.  This needs to be applied on top
of the just-posted preparatory patch set.

This makes some future developments easier/possible:

 (1) Simpler rxrpc_call usage counting.

 (2) Earlier freeing of metadata sk_buffs.

 (3) Rx phase shortcutting on abort/error.

 (4) Encryption/decryption in the AFS fs contexts/threads and directly
     between sk_buffs and AFS buffers.

 (5) Synchronous waiting in reception for AFS.

Changes:

 (V2) Fixed afs_transfer_reply() whereby call->offset was incorrectly being
      added to the buffer pointer (it doesn't matter as long as the reply
      fits entirely inside a single packet).

      Removed an unused goto-label and an unused variable.


The patch can be found here also:

	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite

Tagged thusly:

	git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
	rxrpc-rewrite-20160830-2v2

David
---
David Howells (1):
      rxrpc: Don't expose skbs to in-kernel users


 Documentation/networking/rxrpc.txt |   72 +++---
 fs/afs/cmservice.c                 |  142 ++++++------
 fs/afs/fsclient.c                  |  148 +++++-------
 fs/afs/internal.h                  |   33 +--
 fs/afs/rxrpc.c                     |  439 +++++++++++++-----------------------
 fs/afs/vlclient.c                  |    7 -
 include/net/af_rxrpc.h             |   35 +--
 net/rxrpc/af_rxrpc.c               |   29 +-
 net/rxrpc/ar-internal.h            |   23 ++
 net/rxrpc/call_accept.c            |   13 +
 net/rxrpc/call_object.c            |    5 
 net/rxrpc/conn_event.c             |    1 
 net/rxrpc/input.c                  |   10 +
 net/rxrpc/output.c                 |    2 
 net/rxrpc/recvmsg.c                |  191 +++++++++++++---
 net/rxrpc/skbuff.c                 |    1 
 16 files changed, 565 insertions(+), 586 deletions(-)

[toc] | [next] | [standalone]

#1474809 — Re: [PATCH net-next 1/1] rxrpc: Don't expose skbs to in-kernel users [ver #2]

From: David Howells <dhowells@redhat.com>
Date: Tue, 30 Aug 2016 20:42:14 +0100

> Don't expose skbs to in-kernel users, such as the AFS filesystem, but
> instead provide a notification hook the indicates that a call needs
> attention and another that indicates that there's a new call to be
> collected.
 ...
> Signed-off-by: David Howells <dhowells@redhat.com>

Ok, I tried this one instead.  If no warnings, I'll push it to net-next.

Thanks.

[toc] | [prev] | [next] | [standalone]

#1474900 — Re: [PATCH net-next 1/1] rxrpc: Don't expose skbs to in-kernel users [ver #2]

David Miller <davem@davemloft.net> wrote:

> Ok, I tried this one instead.  If no warnings, I'll push it to net-next.

Thanks,
David

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web