Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1472731 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2016-08-30 19:50 +0200 |
| Last post | 2016-08-30 22:00 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/9] Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 19:50 +0200
[PATCH 1/9] fs/afs/vlocation: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 19:50 +0200
Re: [PATCH 0/9] Remove deprecated create_singlethread_workqueue David Howells <dhowells@redhat.com> - 2016-08-30 21:40 +0200
Re: [PATCH 0/9] Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-30 22:00 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-08-30 19:50 +0200 |
| Subject | [PATCH 0/9] Remove deprecated create_singlethread_workqueue |
| Message-ID | <sbVkC-7WI-13@gated-at.bofh.it> |
This patch set removes deprecated create_singlethread_workqueue usages in fs/. Bhaktipriya Shridhar (9): fs/afs/vlocation: Remove deprecated create_singlethread_workqueue fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue fs/afs/callback: Remove deprecated create_singlethread_workqueue fs/afs/flock: Remove deprecated create_singlethread_workqueue fs/ocfs2/dlmfs: Remove deprecated create_singlethread_workqueue fs/ocfs2/cluster: Remove deprecated create_singlethread_workqueue fs/ocfs2/super: Remove deprecated create_singlethread_workqueue fs/ocfs2/dlm: Remove deprecated create_singlethread_workqueue fs/nfsd/nfs4callback: Remove deprecated create_singlethread_workqueue fs/afs/callback.c | 4 ++-- fs/afs/flock.c | 4 ++-- fs/afs/rxrpc.c | 2 +- fs/afs/vlocation.c | 4 ++-- fs/nfsd/nfs4callback.c | 2 +- fs/ocfs2/cluster/tcp.c | 2 +- fs/ocfs2/dlm/dlmdomain.c | 2 +- fs/ocfs2/dlmfs/dlmfs.c | 2 +- fs/ocfs2/super.c | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-) -- 2.1.4
[toc] | [next] | [standalone]
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-08-30 19:50 +0200 |
| Subject | [PATCH 1/9] fs/afs/vlocation: Remove deprecated create_singlethread_workqueue |
| Message-ID | <sbVkD-7WI-69@gated-at.bofh.it> |
| In reply to | #1472731 |
The workqueue "afs_vlocation_update_worker" queues a single work item
&afs_vlocation_update and hence it doesn't require execution ordering.
Hence, alloc_workqueue has been used to replace the deprecated
create_singlethread_workqueue instance.
Since the workqueue is being used on a memory reclaim path, WQ_MEM_RECLAIM
flag has been set to ensure forward progress under memory pressure.
Since there are fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
fs/afs/vlocation.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/afs/vlocation.c b/fs/afs/vlocation.c
index 5297678..45a8639 100644
--- a/fs/afs/vlocation.c
+++ b/fs/afs/vlocation.c
@@ -594,8 +594,8 @@ static void afs_vlocation_reaper(struct work_struct *work)
*/
int __init afs_vlocation_update_init(void)
{
- afs_vlocation_update_worker =
- create_singlethread_workqueue("kafs_vlupdated");
+ afs_vlocation_update_worker = alloc_workqueue("kafs_vlupdated",
+ WQ_MEM_RECLAIM, 0);
return afs_vlocation_update_worker ? 0 : -ENOMEM;
}
--
2.1.4
[toc] | [prev] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-08-30 21:40 +0200 |
| Message-ID | <sbX34-GW-25@gated-at.bofh.it> |
| In reply to | #1472731 |
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> wrote: > This patch set removes deprecated create_singlethread_workqueue > usages in fs/. > > Bhaktipriya Shridhar (9): > fs/afs/vlocation: Remove deprecated create_singlethread_workqueue > fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue > fs/afs/callback: Remove deprecated create_singlethread_workqueue > fs/afs/flock: Remove deprecated create_singlethread_workqueue I'm removing the workqueue in fs/afs/rxrpc.c in one of my patches. Can I take your other three AFS patches myself and leave someone else to handle the non-AFS patches? David
[toc] | [prev] | [next] | [standalone]
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-08-30 22:00 +0200 |
| Message-ID | <sbXmq-Og-21@gated-at.bofh.it> |
| In reply to | #1472814 |
Hello David, I'll mail another patchset with AFS, ocfs2 and nfsd patches separated out. Thanks, Bhaktipriya On Wed, Aug 31, 2016 at 1:06 AM, David Howells <dhowells@redhat.com> wrote: > Bhaktipriya Shridhar <bhaktipriya96@gmail.com> wrote: > >> This patch set removes deprecated create_singlethread_workqueue >> usages in fs/. >> >> Bhaktipriya Shridhar (9): >> fs/afs/vlocation: Remove deprecated create_singlethread_workqueue >> fs/afs/rxrpc: Remove deprecated create_singlethread_workqueue >> fs/afs/callback: Remove deprecated create_singlethread_workqueue >> fs/afs/flock: Remove deprecated create_singlethread_workqueue > > I'm removing the workqueue in fs/afs/rxrpc.c in one of my patches. Can I take > your other three AFS patches myself and leave someone else to handle the > non-AFS patches? > > David
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web