Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472640 > unrolled thread

Re: [PATCH 2/4] Bluetooth: hci_h5: fix a race in the closing path

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/4] Bluetooth: hci_h5: fix a race in the closing path Marcel Holtmann <marcel@holtmann.org> - 2016-08-30 19:00 +0200

#1472640 — Re: [PATCH 2/4] Bluetooth: hci_h5: fix a race in the closing path

Hi Boris,

> The H5 timer should not be rescheduled while we are closing the device,
> otherwise it's defeating the del_timer_sync() call done in h5_close().
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/bluetooth/hci_h5.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> index 0879d64b1caf..d9720c59cffa 100644
> --- a/drivers/bluetooth/hci_h5.c
> +++ b/drivers/bluetooth/hci_h5.c
> @@ -140,7 +140,12 @@ static void h5_timed_event(unsigned long arg)
> 	}
> 
> 	if (h5->state != H5_ACTIVE) {
> -		mod_timer(&h5->timer, jiffies + H5_SYNC_TIMEOUT);
> +		/*
> +		 * Do not re-schedule the timer if the device is being closed.
> +		 */

same here as the other patch. Use network subsystem comment style.

Regards

Marcel

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web