Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472592 > unrolled thread

[PATCH net-next] rxrpc: Remove use of skbs from AFS

Back to article view | Back to linux.kernel

Contents

  [PATCH net-next] rxrpc: Remove use of skbs from AFS David Howells <dhowells@redhat.com> - 2016-08-30 18:00 +0200
    Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users David Miller <davem@davemloft.net> - 2016-09-02 01:40 +0200
      Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users David Miller <davem@davemloft.net> - 2016-09-02 01:40 +0200
        Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users David Howells <dhowells@redhat.com> - 2016-09-02 01:50 +0200

#1472592 — [PATCH net-next] rxrpc: Remove use of skbs from AFS

Here's a single patch that removes the use of sk_buffs from fs/afs.  From
this point on they'll be entirely retained within net/rxrpc and AFS just
asks AF_RXRPC for linear buffers of data.  This needs to be applied on top
of the just-posted preparatory patch set.

This makes some future developments easier/possible:

 (1) Simpler rxrpc_call usage counting.

 (2) Earlier freeing of metadata sk_buffs.

 (3) Rx phase shortcutting on abort/error.

 (4) Encryption/decryption in the AFS fs contexts/threads and directly
     between sk_buffs and AFS buffers.

 (5) Synchronous waiting in reception for AFS.

The patch can be found here also:

	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite

Tagged thusly:

	git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
	rxrpc-rewrite-20160830-2

David
---
David Howells (1):
      rxrpc: Don't expose skbs to in-kernel users


 Documentation/networking/rxrpc.txt |   72 +++---
 fs/afs/cmservice.c                 |  142 ++++++------
 fs/afs/fsclient.c                  |  148 +++++-------
 fs/afs/internal.h                  |   34 +--
 fs/afs/rxrpc.c                     |  439 +++++++++++++-----------------------
 fs/afs/vlclient.c                  |    7 -
 include/net/af_rxrpc.h             |   35 +--
 net/rxrpc/af_rxrpc.c               |   29 +-
 net/rxrpc/ar-internal.h            |   23 ++
 net/rxrpc/call_accept.c            |   13 +
 net/rxrpc/call_object.c            |    5 
 net/rxrpc/conn_event.c             |    1 
 net/rxrpc/input.c                  |   10 +
 net/rxrpc/output.c                 |    2 
 net/rxrpc/recvmsg.c                |  195 +++++++++++++---
 net/rxrpc/skbuff.c                 |    1 
 16 files changed, 570 insertions(+), 586 deletions(-)

[toc] | [next] | [standalone]

#1474801 — Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

From: David Howells <dhowells@redhat.com>
Date: Tue, 30 Aug 2016 16:52:39 +0100

> Don't expose skbs to in-kernel users, such as the AFS filesystem, but
> instead provide a notification hook the indicates that a call needs
> attention and another that indicates that there's a new call to be
> collected.
 ...
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied.

[toc] | [prev] | [next] | [standalone]

#1474802 — Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

From: David Miller <davem@davemloft.net>
Date: Thu, 01 Sep 2016 16:38:32 -0700 (PDT)

> From: David Howells <dhowells@redhat.com>
> Date: Tue, 30 Aug 2016 16:52:39 +0100
> 
>> Don't expose skbs to in-kernel users, such as the AFS filesystem, but
>> instead provide a notification hook the indicates that a call needs
>> attention and another that indicates that there's a new call to be
>> collected.
>  ...
>> Signed-off-by: David Howells <dhowells@redhat.com>
> 
> Applied.

Actually, reverted, this adds a new warning to the build:

net/rxrpc/recvmsg.c: In function ‘rxrpc_kernel_recv_data’:
net/rxrpc/recvmsg.c:531:1: warning: label ‘need_more_data’ defined but not used [-Wunused-label]
 need_more_data:
 ^
net/rxrpc/recvmsg.c:475:7: warning: unused variable ‘no_more’ [-Wunused-variable]
  bool no_more;
       ^

[toc] | [prev] | [next] | [standalone]

#1474811 — Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

David Miller <davem@davemloft.net> wrote:

> Actually, reverted, this adds a new warning to the build:
> 
> net/rxrpc/recvmsg.c: In function ‘rxrpc_kernel_recv_data’:
> net/rxrpc/recvmsg.c:531:1: warning: label ‘need_more_data’ defined but not used [-Wunused-label]
>  need_more_data:
>  ^
> net/rxrpc/recvmsg.c:475:7: warning: unused variable ‘no_more’ [-Wunused-variable]
>   bool no_more;
>        ^

Yes.  I sent a second version.

David

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web