Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1472155 > unrolled thread
| Started by | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| First post | 2016-08-30 01:10 +0200 |
| Last post | 2016-08-30 17:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Steven Rostedt <rostedt@goodmis.org> - 2016-08-30 01:10 +0200
Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2016-08-30 17:00 +0200
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2016-08-30 01:10 +0200 |
| Subject | Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe |
| Message-ID | <sbDQK-5dS-5@gated-at.bofh.it> |
On Thu, 25 Aug 2016 18:21:09 +0300
Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> It's useless. Before:
> [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> [tracing]# echo 'p:test a:0x0' >> uprobe_events
> -bash: echo: write error: No such file or directory
> [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> -bash: echo: write error: Invalid argument
>
> After:
> [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> -bash: echo: write error: No such file or directory
>
> Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> ---
> kernel/trace/trace_uprobe.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index c53485441c88..a74f2d9ff379 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
> pr_info("Probe point is not specified.\n");
> return -EINVAL;
> }
> - if (isdigit(argv[1][0])) {
> - pr_info("probe point must be have a filename.\n");
> - return -EINVAL;
> - }
> arg = strchr(argv[1], ':');
> if (!arg) {
> ret = -EINVAL;
[toc] | [next] | [standalone]
| From | Srikar Dronamraju <srikar@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-08-30 17:00 +0200 |
| Message-ID | <sbSG5-6ew-1@gated-at.bofh.it> |
| In reply to | #1472155 |
* Steven Rostedt <rostedt@goodmis.org> [2016-08-29 18:58:13]: > On Thu, 25 Aug 2016 18:21:09 +0300 > Dmitry Safonov <dsafonov@virtuozzo.com> wrote: > > > It's useless. Before: > > [tracing]# echo 'p:test /a:0x0' >> uprobe_events > > [tracing]# echo 'p:test a:0x0' >> uprobe_events > > -bash: echo: write error: No such file or directory > > [tracing]# echo 'p:test 1:0x0' >> uprobe_events > > -bash: echo: write error: Invalid argument > > > > After: > > [tracing]# echo 'p:test 1:0x0' >> uprobe_events > > -bash: echo: write error: No such file or directory > > > > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com> > > Acked-by: Steven Rostedt <rostedt@goodmis.org> Agree. Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> -- Thanks and Regards Srikar Dronamraju
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web