Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470359 > unrolled thread

Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed

Started byWolfram Sang <wsa@the-dreams.de>
First post2016-08-25 21:50 +0200
Last post2016-08-30 21:20 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after  config_load reg programmed Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 21:50 +0200
    RE: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after  config_load reg programmed Shardar Mohammed <smohammed@nvidia.com> - 2016-08-26 11:20 +0200
      Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after  config_load reg programmed Wolfram Sang <wsa@the-dreams.de> - 2016-08-26 18:00 +0200
        RE: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after  config_load reg programmed Shardar Mohammed <smohammed@nvidia.com> - 2016-08-30 21:20 +0200

#1470359 — Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed

FromWolfram Sang <wsa@the-dreams.de>
Date2016-08-25 21:50 +0200
SubjectRe: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed
Message-ID<sa8OZ-5jF-9@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

> > > +		err = readx_poll_timeout(readl, i2c_dev->base + reg_offset,
> > > +					 val, val == 0, 1000,
> > > +					 I2C_CONFIG_LOAD_TIMEOUT);
> > 
> > Any reason we can't use readl_poll_timeout() here?
> [Shardar] Can be used, will change and push the new patchset.

Still interested? Should be an easy change, but I am reluctant to fix it
here with no testing.

[toc] | [next] | [standalone]


#1470608

FromShardar Mohammed <smohammed@nvidia.com>
Date2016-08-26 11:20 +0200
Message-ID<salsR-54s-1@gated-at.bofh.it>
In reply to#1470359
> -----Original Message-----
> From: Wolfram Sang [mailto:wsa@the-dreams.de]
> Sent: Friday, August 26, 2016 1:10 AM
> To: Shardar Mohammed
> Cc: Laxman Dewangan; swarren@wwwdotorg.org;
> thierry.reding@gmail.com; gnurou@gmail.com; linux-i2c@vger.kernel.org;
> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after
> config_load reg programmed
> 
> * PGP Signed by an unknown key
> 
> 
> > > > +		err = readx_poll_timeout(readl, i2c_dev->base + reg_offset,
> > > > +					 val, val == 0, 1000,
> > > > +					 I2C_CONFIG_LOAD_TIMEOUT);
> > >
> > > Any reason we can't use readl_poll_timeout() here?
> > [Shardar] Can be used, will change and push the new patchset.
> 
> Still interested? Should be an easy change, but I am reluctant to fix it here
> with no testing.
[Shardar] Will push the change by tomorrow.
> 
> 
> * Unknown Key
> * 0x14A029B6

[toc] | [prev] | [next] | [standalone]


#1470868

FromWolfram Sang <wsa@the-dreams.de>
Date2016-08-26 18:00 +0200
Message-ID<sarHX-B0-3@gated-at.bofh.it>
In reply to#1470608

[Multipart message — attachments visible in raw view] — view raw

> > Still interested? Should be an easy change, but I am reluctant to fix it here
> > with no testing.
> [Shardar] Will push the change by tomorrow.

Thanks. If possibe, could you rebase it on top of this series?

[PATCH V2 0/9] Some Tegra I2C Updates

Or is it easier to rebase Jon's series on top of yours?

CCing Jon, too...

[toc] | [prev] | [next] | [standalone]


#1472801

FromShardar Mohammed <smohammed@nvidia.com>
Date2016-08-30 21:20 +0200
Message-ID<sbWJI-yF-9@gated-at.bofh.it>
In reply to#1470868
Hi Wolfram Sang,

I have pushed below changes:
PATCH v9 series with only taking care of review comment.

PATCH v10 series with rebasing on top of Jon's patch series  [PATCH V2 0/9] Some Tegra I2C Updates.

Please review.

Thanks,
Shardar

> -----Original Message-----
> From: Wolfram Sang [mailto:wsa@the-dreams.de]
> Sent: Friday, August 26, 2016 9:24 PM
> To: Shardar Mohammed
> Cc: Laxman Dewangan; swarren@wwwdotorg.org;
> thierry.reding@gmail.com; gnurou@gmail.com; linux-i2c@vger.kernel.org;
> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org; Jonathan Hunter
> Subject: Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after
> config_load reg programmed
> 
> * PGP Signed by an unknown key
> 
> > > Still interested? Should be an easy change, but I am reluctant to
> > > fix it here with no testing.
> > [Shardar] Will push the change by tomorrow.
> 
> Thanks. If possibe, could you rebase it on top of this series?
> 
> [PATCH V2 0/9] Some Tegra I2C Updates
> 
> Or is it easier to rebase Jon's series on top of yours?
> 
> CCing Jon, too...
> 
> 
> * Unknown Key
> * 0x14A029B6

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web