Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470544 > unrolled thread

[PATCH 2/2] IB/hfi1: Clean up type used and casting

Back to article view | Back to linux.kernel

Contents

  [PATCH 2/2] IB/hfi1: Clean up type used and casting Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-26 07:00 +0200
    Re: [PATCH 2/2] IB/hfi1: Clean up type used and casting Doug Ledford <dledford@redhat.com> - 2016-08-26 16:30 +0200

#1470544 — [PATCH 2/2] IB/hfi1: Clean up type used and casting

In all other places in this file where 'find_first_bit' is called,
port_num is defined as a 'u8' and no casting is done.

Do the same here in order to be more consistent.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/infiniband/hw/hfi1/mad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/mad.c b/drivers/infiniband/hw/hfi1/mad.c
index 2c6c138c41b2..b9e47d1c462b 100644
--- a/drivers/infiniband/hw/hfi1/mad.c
+++ b/drivers/infiniband/hw/hfi1/mad.c
@@ -2599,7 +2599,7 @@ static int pma_get_opa_datacounters(struct opa_pma_mad *pmp,
 	u8 lq, num_vls;
 	u8 res_lli, res_ler;
 	u64 port_mask;
-	unsigned long port_num;
+	u8 port_num;
 	unsigned long vl;
 	u32 vl_select_mask;
 	int vfi;
@@ -2634,7 +2634,7 @@ static int pma_get_opa_datacounters(struct opa_pma_mad *pmp,
 	port_mask = be64_to_cpu(req->port_select_mask[3]);
 	port_num = find_first_bit((unsigned long *)&port_mask, 64);
 
-	if ((u8)port_num != port) {
+	if (port_num != port) {
 		pmp->mad_hdr.status |= IB_SMP_INVALID_FIELD;
 		return reply((struct ib_mad_hdr *)pmp);
 	}
-- 
2.7.4


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

[toc] | [next] | [standalone]

#1470745

[Multipart message — attachments visible in raw view] — view raw

On 8/26/2016 12:49 AM, Christophe JAILLET wrote:
> In all other places in this file where 'find_first_bit' is called,
> port_num is defined as a 'u8' and no casting is done.
> 
> Do the same here in order to be more consistent.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks, applied.


-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: 0E572FDD

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web