Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1471155 > unrolled thread

Re: [PATCH] pcmcia: ds: fix suspend/resume

Started byDominik Brodowski <linux@dominikbrodowski.net>
First post2016-08-27 14:10 +0200
Last post2016-08-27 14:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] pcmcia: ds: fix suspend/resume Dominik Brodowski <linux@dominikbrodowski.net> - 2016-08-27 14:10 +0200
    Re: [PATCH] pcmcia: ds: fix suspend/resume Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-27 14:50 +0200

#1471155 — Re: [PATCH] pcmcia: ds: fix suspend/resume

FromDominik Brodowski <linux@dominikbrodowski.net>
Date2016-08-27 14:10 +0200
SubjectRe: [PATCH] pcmcia: ds: fix suspend/resume
Message-ID<saKAV-4mF-1@gated-at.bofh.it>
Russell,

On Sun, Aug 21, 2016 at 12:05:30AM +0100, Russell King wrote:
> PCMCIA suspend/resume no longer works since the commit mentioned below,
> as the callbacks are no longer made.  Convert the driver to the new
> dev_pm_ops, which restores the suspend/resume functionality.  Tested on
> the arm arch Assabet platform with a pcnet_cs CF card.
> 
> Fixes: aa8e54b559479 ("PM / sleep: Go direct_complete if driver has no callbacks")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Looks goot to me. Can you push it upstream, please?

Best
	Dominik

[toc] | [next] | [standalone]


#1471167

FromRussell King - ARM Linux <linux@armlinux.org.uk>
Date2016-08-27 14:50 +0200
Message-ID<saLdD-4BF-1@gated-at.bofh.it>
In reply to#1471155
On Sat, Aug 27, 2016 at 02:05:22PM +0200, Dominik Brodowski wrote:
> Russell,
> 
> On Sun, Aug 21, 2016 at 12:05:30AM +0100, Russell King wrote:
> > PCMCIA suspend/resume no longer works since the commit mentioned below,
> > as the callbacks are no longer made.  Convert the driver to the new
> > dev_pm_ops, which restores the suspend/resume functionality.  Tested on
> > the arm arch Assabet platform with a pcnet_cs CF card.
> > 
> > Fixes: aa8e54b559479 ("PM / sleep: Go direct_complete if driver has no callbacks")
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> Looks goot to me. Can you push it upstream, please?

I can do - should I take that as an Acked-by?

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web