Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1471107 > unrolled thread

[PATCH v2] fix:brcmfmac: add missing header dependencies

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] fix:brcmfmac: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-27 08:20 +0200
    Re: [PATCH v2] fix:brcmfmac: add missing header dependencies Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-08-29 10:10 +0200

#1471107 — [PATCH v2] fix:brcmfmac: add missing header dependencies

We get 1 warning when biuld kernel with W=1:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-
prototypes]

In fact, this function is declared in brcmfmac/debug.h, so this patch
add missing header dependencies

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
index a10f35c..fe67559 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
@@ -19,6 +19,7 @@
 #ifndef __CHECKER__
 #define CREATE_TRACE_POINTS
 #include "tracepoint.h"
+#include "debug.h"
 
 void __brcmf_err(const char *func, const char *fmt, ...)
 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1471617

On 27-8-2016 8:08, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-
> prototypes]
> 
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies

Thanks for this fix, but please remove the 'fix:' prefix in the subject
as it just noise.

Regards,
Arend

> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> index a10f35c..fe67559 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> @@ -19,6 +19,7 @@
>  #ifndef __CHECKER__
>  #define CREATE_TRACE_POINTS
>  #include "tracepoint.h"
> +#include "debug.h"
>  
>  void __brcmf_err(const char *func, const char *fmt, ...)
>  {
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web