Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1471086 > unrolled thread
| Started by | Oleg Drokin <green@linuxhacker.ru> |
|---|---|
| First post | 2016-08-27 05:10 +0200 |
| Last post | 2016-08-30 11:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mx3fb: Fix print format string Oleg Drokin <green@linuxhacker.ru> - 2016-08-27 05:10 +0200
Re: [PATCH] mx3fb: Fix print format string Joe Perches <joe@perches.com> - 2016-08-27 05:20 +0200
Re: [PATCH] mx3fb: Fix print format string Oleg Drokin <green@linuxhacker.ru> - 2016-08-27 06:10 +0200
Re: [PATCH] mx3fb: Fix print format string Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-08-30 11:00 +0200
| From | Oleg Drokin <green@linuxhacker.ru> |
|---|---|
| Date | 2016-08-27 05:10 +0200 |
| Subject | [PATCH] mx3fb: Fix print format string |
| Message-ID | <saCam-7xx-7@gated-at.bofh.it> |
%ul was probably meant as %lu since the former would print an unsigned value and a letter l. But in fact the whole value we are printing in u32 anyway, so we don't need the format to be long. Therefore just drop the l altogether. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> --- Also do we really need 1000UL specification if we cast to u32 anyway? Or should we drop away the cast instead? Are pixelclocks over 4GHz possible here? drivers/video/fbdev/mx3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index f91b1db..8778e01 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/drivers/video/fbdev/mx3fb.c @@ -845,7 +845,7 @@ static int __set_par(struct fb_info *fbi, bool lock) if (fbi->var.sync & FB_SYNC_SHARP_MODE) mode = IPU_PANEL_SHARP_TFT; - dev_dbg(fbi->device, "pixclock = %ul Hz\n", + dev_dbg(fbi->device, "pixclock = %u Hz\n", (u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL)); if (sdc_init_panel(mx3fb, mode, -- 2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-08-27 05:20 +0200 |
| Message-ID | <saCk1-7AH-7@gated-at.bofh.it> |
| In reply to | #1471086 |
On Fri, 2016-08-26 at 23:05 -0400, Oleg Drokin wrote: > %ul was probably meant as %lu since the former would print > an unsigned value and a letter l. > > But in fact the whole value we are printing in u32 anyway, so > we don't need the format to be long. Therefore just drop the l > altogether. [] > Also do we really need 1000UL specification if we > cast to u32 anyway? Or should we drop away the cast instead? > Are pixelclocks over 4GHz possible here? It's a debugging printk, it doesn't matter much. Why not use "%u kHz" and drop the "* 1000UL"? > diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c [] > @@ -845,7 +845,7 @@ static int __set_par(struct fb_info *fbi, bool lock) > if (fbi->var.sync & FB_SYNC_SHARP_MODE) > mode = IPU_PANEL_SHARP_TFT; > > - dev_dbg(fbi->device, "pixclock = %ul Hz\n", > + dev_dbg(fbi->device, "pixclock = %u Hz\n", > (u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL)); > > if (sdc_init_panel(mx3fb, mode,
[toc] | [prev] | [next] | [standalone]
| From | Oleg Drokin <green@linuxhacker.ru> |
|---|---|
| Date | 2016-08-27 06:10 +0200 |
| Message-ID | <saD6p-862-1@gated-at.bofh.it> |
| In reply to | #1471088 |
On Aug 26, 2016, at 11:18 PM, Joe Perches wrote: > On Fri, 2016-08-26 at 23:05 -0400, Oleg Drokin wrote: >> %ul was probably meant as %lu since the former would print >> an unsigned value and a letter l. >> >> But in fact the whole value we are printing in u32 anyway, so >> we don't need the format to be long. Therefore just drop the l >> altogether. > [] >> Also do we really need 1000UL specification if we >> cast to u32 anyway? Or should we drop away the cast instead? >> Are pixelclocks over 4GHz possible here? > > It's a debugging printk, it doesn't matter much. > Why not use "%u kHz" and drop the "* 1000UL"? I have no strong opinion on this since it's not my debugging code. But XXX000l Hz makes zero sense either way. >> diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c > [] >> @@ -845,7 +845,7 @@ static int __set_par(struct fb_info *fbi, bool lock) >> if (fbi->var.sync & FB_SYNC_SHARP_MODE) >> mode = IPU_PANEL_SHARP_TFT; >> >> - dev_dbg(fbi->device, "pixclock = %ul Hz\n", >> + dev_dbg(fbi->device, "pixclock = %u Hz\n", >> (u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL)); >> >> if (sdc_init_panel(mx3fb, mode, >> (PICOS2KHZ(fbi->var.pixclock)) * 1000UL, I guess it's printed like that to match sdc_init_panel argument exactly?
[toc] | [prev] | [next] | [standalone]
| From | Tomi Valkeinen <tomi.valkeinen@ti.com> |
|---|---|
| Date | 2016-08-30 11:00 +0200 |
| Message-ID | <sbN3H-2x1-3@gated-at.bofh.it> |
| In reply to | #1471086 |
[Multipart message — attachments visible in raw view] — view raw
On 27/08/16 06:05, Oleg Drokin wrote: > %ul was probably meant as %lu since the former would print > an unsigned value and a letter l. > > But in fact the whole value we are printing in u32 anyway, so > we don't need the format to be long. Therefore just drop the l > altogether. > > Signed-off-by: Oleg Drokin <green@linuxhacker.ru> > --- > Also do we really need 1000UL specification if we > cast to u32 anyway? Or should we drop away the cast instead? > Are pixelclocks over 4GHz possible here? > > drivers/video/fbdev/mx3fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c > index f91b1db..8778e01 100644 > --- a/drivers/video/fbdev/mx3fb.c > +++ b/drivers/video/fbdev/mx3fb.c > @@ -845,7 +845,7 @@ static int __set_par(struct fb_info *fbi, bool lock) > if (fbi->var.sync & FB_SYNC_SHARP_MODE) > mode = IPU_PANEL_SHARP_TFT; > > - dev_dbg(fbi->device, "pixclock = %ul Hz\n", > + dev_dbg(fbi->device, "pixclock = %u Hz\n", > (u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL)); > > if (sdc_init_panel(mx3fb, mode, > Thanks, queued for 4.9. Tomi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web