Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1469303 > unrolled thread

[PATCH] input: pegasus_notetaker - directly include workqueue header

Started byMartin Kepplinger <martink@posteo.de>
First post2016-08-24 12:00 +0200
Last post2016-08-25 18:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] input: pegasus_notetaker - directly include workqueue header Martin Kepplinger <martink@posteo.de> - 2016-08-24 12:00 +0200
    Re: [PATCH] input: pegasus_notetaker - directly include workqueue  header Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-25 18:50 +0200

#1469303 — [PATCH] input: pegasus_notetaker - directly include workqueue header

FromMartin Kepplinger <martink@posteo.de>
Date2016-08-24 12:00 +0200
Subject[PATCH] input: pegasus_notetaker - directly include workqueue header
Message-ID<s9D8t-tX-7@gated-at.bofh.it>
According to the kernel's guidelines, let's directly include the
workqueue functions we use.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
I don't know if it's worth it, but I should have included this according to
the guidelines :)


 drivers/input/tablet/pegasus_notetaker.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c
index 949dacc..47de5a8 100644
--- a/drivers/input/tablet/pegasus_notetaker.c
+++ b/drivers/input/tablet/pegasus_notetaker.c
@@ -40,6 +40,7 @@
 #include <linux/input.h>
 #include <linux/usb/input.h>
 #include <linux/slab.h>
+#include <linux/workqueue.h>
 
 /* USB HID defines */
 #define USB_REQ_GET_REPORT		0x01
-- 
2.1.4

[toc] | [next] | [standalone]


#1470274 — Re: [PATCH] input: pegasus_notetaker - directly include workqueue header

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2016-08-25 18:50 +0200
SubjectRe: [PATCH] input: pegasus_notetaker - directly include workqueue header
Message-ID<sa60O-3vb-13@gated-at.bofh.it>
In reply to#1469303
On Wed, Aug 24, 2016 at 11:52:05AM +0200, Martin Kepplinger wrote:
> According to the kernel's guidelines, let's directly include the
> workqueue functions we use.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> I don't know if it's worth it, but I should have included this according to
> the guidelines :)

It won't hurt.

Applied, thank you.

> 
> 
>  drivers/input/tablet/pegasus_notetaker.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c
> index 949dacc..47de5a8 100644
> --- a/drivers/input/tablet/pegasus_notetaker.c
> +++ b/drivers/input/tablet/pegasus_notetaker.c
> @@ -40,6 +40,7 @@
>  #include <linux/input.h>
>  #include <linux/usb/input.h>
>  #include <linux/slab.h>
> +#include <linux/workqueue.h>
>  
>  /* USB HID defines */
>  #define USB_REQ_GET_REPORT		0x01
> -- 
> 2.1.4
> 

-- 
Dmitry

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web