Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470232 > unrolled thread

[PATCH 0/9] staging: fbtft: Fix checkpatch warning

Started byAnson Jacob <ansonjacob.aj@gmail.com>
First post2016-08-25 17:40 +0200
Last post2016-08-25 18:40 +0200
Articles 5 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/9] staging: fbtft: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-25 17:40 +0200
    [PATCH 1/9] staging: fbtft: fb_s6d02a1.c: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-25 17:40 +0200
    [PATCH 3/9] staging: fbtft: fb_ssd1289: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-25 17:40 +0200
    [PATCH 4/9] staging: fbtft: fb_ssd1306: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-25 18:20 +0200
    [PATCH 2/9] staging: fbtft: fb_s6d1121.c: Fix checkpatch warning Anson Jacob <ansonjacob.aj@gmail.com> - 2016-08-25 18:40 +0200

#1470232 — [PATCH 0/9] staging: fbtft: Fix checkpatch warning

FromAnson Jacob <ansonjacob.aj@gmail.com>
Date2016-08-25 17:40 +0200
Subject[PATCH 0/9] staging: fbtft: Fix checkpatch warning
Message-ID<sa4Ln-2LX-5@gated-at.bofh.it>
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line

Anson Jacob (9):
  staging: fbtft: fb_s6d02a1.c: Fix checkpatch warning
  staging: fbtft: fb_s6d1121.c: Fix checkpatch warning
  staging: fbtft: fb_ssd1289: Fix checkpatch warning
  staging: fbtft: fb_ssd1306: Fix checkpatch warning
  staging: fbtft: fb_ssd1331: Fix checkpatch warning
  staging: fbtft: fb_st7735r: Fix checkpatch warning
  staging: fbtft: fbtft-bus: Fix checkpatch warning
  staging: fbtft: fbtft_device: Fix checkpatch warning
  staging: fbtft: fb_tls8204: Fix checkpatch warning

 drivers/staging/fbtft/fb_s6d02a1.c   | 14 +++++----
 drivers/staging/fbtft/fb_s6d1121.c   |  8 ++---
 drivers/staging/fbtft/fb_ssd1289.c   |  8 ++---
 drivers/staging/fbtft/fb_ssd1306.c   | 23 ++++++++-------
 drivers/staging/fbtft/fb_ssd1331.c   | 40 ++++++++++++-------------
 drivers/staging/fbtft/fb_st7735r.c   | 43 ++++++++++++++++-----------
 drivers/staging/fbtft/fb_tls8204.c   | 57 ++++++++++++++++++------------------
 drivers/staging/fbtft/fbtft-bus.c    |  3 +-
 drivers/staging/fbtft/fbtft_device.c |  8 +++--
 9 files changed, 110 insertions(+), 94 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]


#1470233 — [PATCH 1/9] staging: fbtft: fb_s6d02a1.c: Fix checkpatch warning

FromAnson Jacob <ansonjacob.aj@gmail.com>
Date2016-08-25 17:40 +0200
Subject[PATCH 1/9] staging: fbtft: fb_s6d02a1.c: Fix checkpatch warning
Message-ID<sa4V4-2PH-31@gated-at.bofh.it>
In reply to#1470232
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/fbtft/fb_s6d02a1.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c
index 3113355..774b0ff 100644
--- a/drivers/staging/fbtft/fb_s6d02a1.c
+++ b/drivers/staging/fbtft/fb_s6d02a1.c
@@ -113,12 +113,14 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 #define MV BIT(5)
 static int set_var(struct fbtft_par *par)
 {
-	/* Memory data access control (0x36h)
-	     RGB/BGR:
-		1. Mode selection pin SRGB
-			RGB H/W pin for color filter setting: 0=RGB, 1=BGR
-		2. MADCTL RGB bit
-			RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR */
+	/*
+	 * Memory data access control (0x36h)
+	 * RGB/BGR:
+	 *	1. Mode selection pin SRGB
+	 *		RGB H/W pin for color filter setting: 0=RGB, 1=BGR
+	 *	2. MADCTL RGB bit
+	 *		RGB-BGR ORDER color filter panel: 0=RGB, 1=BGR
+	 */
 	switch (par->info->var.rotate) {
 	case 0:
 		write_reg(par, MIPI_DCS_SET_ADDRESS_MODE,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]


#1470235 — [PATCH 3/9] staging: fbtft: fb_ssd1289: Fix checkpatch warning

FromAnson Jacob <ansonjacob.aj@gmail.com>
Date2016-08-25 17:40 +0200
Subject[PATCH 3/9] staging: fbtft: fb_ssd1289: Fix checkpatch warning
Message-ID<sa4V4-2PH-23@gated-at.bofh.it>
In reply to#1470232
Fix checkpatch.pl warning:
Block comments use * on subsequent lines

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/fbtft/fb_ssd1289.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/fbtft/fb_ssd1289.c b/drivers/staging/fbtft/fb_ssd1289.c
index 5d5f280..25f9fbe 100644
--- a/drivers/staging/fbtft/fb_ssd1289.c
+++ b/drivers/staging/fbtft/fb_ssd1289.c
@@ -131,10 +131,10 @@ static int set_var(struct fbtft_par *par)
 }
 
 /*
-  Gamma string format:
-    VRP0 VRP1 PRP0 PRP1 PKP0 PKP1 PKP2 PKP3 PKP4 PKP5
-    VRN0 VRN1 PRN0 PRN1 PKN0 PKN1 PKN2 PKN3 PKN4 PKN5
-*/
+ * Gamma string format:
+ * VRP0 VRP1 PRP0 PRP1 PKP0 PKP1 PKP2 PKP3 PKP4 PKP5
+ * VRN0 VRN1 PRN0 PRN1 PKN0 PKN1 PKN2 PKN3 PKN4 PKN5
+ */
 #define CURVE(num, idx)  curves[num * par->gamma.num_values + idx]
 static int set_gamma(struct fbtft_par *par, unsigned long *curves)
 {
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]


#1470253 — [PATCH 4/9] staging: fbtft: fb_ssd1306: Fix checkpatch warning

FromAnson Jacob <ansonjacob.aj@gmail.com>
Date2016-08-25 18:20 +0200
Subject[PATCH 4/9] staging: fbtft: fb_ssd1306: Fix checkpatch warning
Message-ID<sa5xM-3jP-31@gated-at.bofh.it>
In reply to#1470232
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/fbtft/fb_ssd1306.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c
index e0b34a4..80fc570 100644
--- a/drivers/staging/fbtft/fb_ssd1306.c
+++ b/drivers/staging/fbtft/fb_ssd1306.c
@@ -27,15 +27,15 @@
 #define HEIGHT		64
 
 /*
-  write_reg() caveat:
-
-     This doesn't work because D/C has to be LOW for both values:
-       write_reg(par, val1, val2);
-
-     Do it like this:
-       write_reg(par, val1);
-       write_reg(par, val2);
-*/
+ * write_reg() caveat:
+ *
+ * This doesn't work because D/C has to be LOW for both values:
+ * write_reg(par, val1, val2);
+ *
+ * Do it like this:
+ * write_reg(par, val1);
+ * write_reg(par, val2);
+ */
 
 /* Init sequence taken from the Adafruit SSD1306 Arduino library */
 static int init_display(struct fbtft_par *par)
@@ -113,8 +113,9 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0xA4);
 
 	/* Set Normal Display
-	   0 in RAM: OFF in display panel
-	   1 in RAM: ON in display panel */
+	 * 0 in RAM: OFF in display panel
+	 * 1 in RAM: ON in display panel
+	 */
 	write_reg(par, 0xA6);
 
 	/* Set Display ON */
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]


#1470265 — [PATCH 2/9] staging: fbtft: fb_s6d1121.c: Fix checkpatch warning

FromAnson Jacob <ansonjacob.aj@gmail.com>
Date2016-08-25 18:40 +0200
Subject[PATCH 2/9] staging: fbtft: fb_s6d1121.c: Fix checkpatch warning
Message-ID<sa5R7-3r1-9@gated-at.bofh.it>
In reply to#1470232
Fix checkpatch.pl warning:
Block comments use * on subsequent lines

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/fbtft/fb_s6d1121.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/fbtft/fb_s6d1121.c b/drivers/staging/fbtft/fb_s6d1121.c
index d6ae76b..9b1d70b 100644
--- a/drivers/staging/fbtft/fb_s6d1121.c
+++ b/drivers/staging/fbtft/fb_s6d1121.c
@@ -125,10 +125,10 @@ static int set_var(struct fbtft_par *par)
 }
 
 /*
-  Gamma string format:
-    PKP0 PKP1 PKP2 PKP3 PKP4 PKP5 PKP6 PKP7 PKP8 PKP9 PKP10 PKP11 VRP0 VRP1
-    PKN0 PKN1 PKN2 PKN3 PKN4 PKN5 PKN6 PKN7 PRN8 PRN9 PRN10 PRN11 VRN0 VRN1
-*/
+ * Gamma string format:
+ * PKP0 PKP1 PKP2 PKP3 PKP4 PKP5 PKP6 PKP7 PKP8 PKP9 PKP10 PKP11 VRP0 VRP1
+ * PKN0 PKN1 PKN2 PKN3 PKN4 PKN5 PKN6 PKN7 PRN8 PRN9 PRN10 PRN11 VRN0 VRN1
+ */
 #define CURVE(num, idx)  curves[num * par->gamma.num_values + idx]
 static int set_gamma(struct fbtft_par *par, unsigned long *curves)
 {
-- 
2.7.4

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web