Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1469614 > unrolled thread
| Started by | Aaro Koskinen <aaro.koskinen@iki.fi> |
|---|---|
| First post | 2016-08-24 20:00 +0200 |
| Last post | 2016-08-25 16:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12" Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-08-24 20:00 +0200
Re: [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12" Johannes Berg <johannes@sipsolutions.net> - 2016-08-24 21:50 +0200
Re: [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12" Aaro Koskinen <aaro.koskinen@iki.fi> - 2016-08-24 22:40 +0200
Re: [alsa-devel] [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12" Takashi Iwai <tiwai@suse.de> - 2016-08-25 16:50 +0200
| From | Aaro Koskinen <aaro.koskinen@iki.fi> |
|---|---|
| Date | 2016-08-24 20:00 +0200 |
| Subject | [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12" |
| Message-ID | <s9KD0-5zX-37@gated-at.bofh.it> |
Enable sound on PowerBook G4 12".
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
sound/aoa/fabrics/layout.c | 8 ++++++++
sound/aoa/soundbus/i2sbus/core.c | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c
index 8f71f7e..edc8681 100644
--- a/sound/aoa/fabrics/layout.c
+++ b/sound/aoa/fabrics/layout.c
@@ -112,6 +112,7 @@ MODULE_ALIAS("sound-layout-100");
MODULE_ALIAS("aoa-device-id-14");
MODULE_ALIAS("aoa-device-id-22");
+MODULE_ALIAS("aoa-device-id-31");
MODULE_ALIAS("aoa-device-id-35");
MODULE_ALIAS("aoa-device-id-44");
@@ -362,6 +363,13 @@ static struct layout layouts[] = {
.connections = tas_connections_nolineout,
},
},
+ /* PowerBook6,1 */
+ { .device_id = 31,
+ .codecs[0] = {
+ .name = "tas",
+ .connections = tas_connections_nolineout,
+ },
+ },
/* PowerBook6,5 */
{ .device_id = 44,
.codecs[0] = {
diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c
index 1cbf210..000b585 100644
--- a/sound/aoa/soundbus/i2sbus/core.c
+++ b/sound/aoa/soundbus/i2sbus/core.c
@@ -197,7 +197,7 @@ static int i2sbus_add_dev(struct macio_dev *macio,
* so restrict to those we do handle for now.
*/
if (id && (*id == 22 || *id == 14 || *id == 35 ||
- *id == 44)) {
+ *id == 31 || *id == 44)) {
snprintf(dev->sound.modalias, 32,
"aoa-device-id-%d", *id);
ok = 1;
--
2.9.2
[toc] | [next] | [standalone]
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Date | 2016-08-24 21:50 +0200 |
| Message-ID | <s9Mlr-6QO-13@gated-at.bofh.it> |
| In reply to | #1469614 |
On Wed, 2016-08-24 at 20:57 +0300, Aaro Koskinen wrote:
> Enable sound on PowerBook G4 12".
Looks good to me, I assume you tested it and it works :)
johannes
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> sound/aoa/fabrics/layout.c | 8 ++++++++
> sound/aoa/soundbus/i2sbus/core.c | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c
> index 8f71f7e..edc8681 100644
> --- a/sound/aoa/fabrics/layout.c
> +++ b/sound/aoa/fabrics/layout.c
> @@ -112,6 +112,7 @@ MODULE_ALIAS("sound-layout-100");
>
> MODULE_ALIAS("aoa-device-id-14");
> MODULE_ALIAS("aoa-device-id-22");
> +MODULE_ALIAS("aoa-device-id-31");
> MODULE_ALIAS("aoa-device-id-35");
> MODULE_ALIAS("aoa-device-id-44");
>
> @@ -362,6 +363,13 @@ static struct layout layouts[] = {
> .connections = tas_connections_nolineout,
> },
> },
> + /* PowerBook6,1 */
> + { .device_id = 31,
> + .codecs[0] = {
> + .name = "tas",
> + .connections = tas_connections_nolineout,
> + },
> + },
> /* PowerBook6,5 */
> { .device_id = 44,
> .codecs[0] = {
> diff --git a/sound/aoa/soundbus/i2sbus/core.c
> b/sound/aoa/soundbus/i2sbus/core.c
> index 1cbf210..000b585 100644
> --- a/sound/aoa/soundbus/i2sbus/core.c
> +++ b/sound/aoa/soundbus/i2sbus/core.c
> @@ -197,7 +197,7 @@ static int i2sbus_add_dev(struct macio_dev
> *macio,
> * so restrict to those we do handle for
> now.
> */
> if (id && (*id == 22 || *id == 14 || *id ==
> 35 ||
> - *id == 44)) {
> + *id == 31 || *id == 44)) {
> snprintf(dev->sound.modalias, 32,
> "aoa-device-id-%d", *id);
> ok = 1;
[toc] | [prev] | [next] | [standalone]
| From | Aaro Koskinen <aaro.koskinen@iki.fi> |
|---|---|
| Date | 2016-08-24 22:40 +0200 |
| Message-ID | <s9N7Q-7tx-3@gated-at.bofh.it> |
| In reply to | #1469672 |
Hi, On Wed, Aug 24, 2016 at 09:43:23PM +0200, Johannes Berg wrote: > On Wed, 2016-08-24 at 20:57 +0300, Aaro Koskinen wrote: > > Enable sound on PowerBook G4 12". > > Looks good to me, I assume you tested it and it works :) Yes, I have this laptop in use. A.
[toc] | [prev] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2016-08-25 16:50 +0200 |
| Subject | Re: [alsa-devel] [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12" |
| Message-ID | <sa48G-2d0-25@gated-at.bofh.it> |
| In reply to | #1469696 |
On Wed, 24 Aug 2016 22:35:58 +0200, Aaro Koskinen wrote: > > Hi, > > On Wed, Aug 24, 2016 at 09:43:23PM +0200, Johannes Berg wrote: > > On Wed, 2016-08-24 at 20:57 +0300, Aaro Koskinen wrote: > > > Enable sound on PowerBook G4 12". > > > > Looks good to me, I assume you tested it and it works :) > > Yes, I have this laptop in use. OK, applied the patch now. Thanks. Takashi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web