Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1470108 > unrolled thread
| Started by | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| First post | 2016-08-25 14:20 +0200 |
| Last post | 2016-08-26 05:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] PM / devfreq: fix Kconfig indent style Jisheng Zhang <jszhang@marvell.com> - 2016-08-25 14:20 +0200
Re: [PATCH] PM / devfreq: fix Kconfig indent style Chanwoo Choi <cw00.choi@samsung.com> - 2016-08-26 04:30 +0200
Re: [PATCH] PM / devfreq: fix Kconfig indent style Jisheng Zhang <jszhang@marvell.com> - 2016-08-26 05:00 +0200
RE: Re: [PATCH] PM / devfreq: fix Kconfig indent style MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-08-26 05:00 +0200
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2016-08-25 14:20 +0200 |
| Subject | [PATCH] PM / devfreq: fix Kconfig indent style |
| Message-ID | <sa1Nw-PS-25@gated-at.bofh.it> |
Use tab rather than space to indent, and tab + two spaces to indent help message. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- drivers/devfreq/Kconfig | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index a5be56e..86d06ab 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -91,14 +91,14 @@ config ARM_EXYNOS_BUS_DEVFREQ This does not yet operate with optimal voltages. config ARM_TEGRA_DEVFREQ - tristate "Tegra DEVFREQ Driver" - depends on ARCH_TEGRA_124_SOC - select DEVFREQ_GOV_SIMPLE_ONDEMAND - select PM_OPP - help - This adds the DEVFREQ driver for the Tegra family of SoCs. - It reads ACTMON counters of memory controllers and adjusts the - operating frequencies and voltages with OPP support. + tristate "Tegra DEVFREQ Driver" + depends on ARCH_TEGRA_124_SOC + select DEVFREQ_GOV_SIMPLE_ONDEMAND + select PM_OPP + help + This adds the DEVFREQ driver for the Tegra family of SoCs. + It reads ACTMON counters of memory controllers and adjusts the + operating frequencies and voltages with OPP support. source "drivers/devfreq/event/Kconfig" -- 2.9.3
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-08-26 04:30 +0200 |
| Message-ID | <saf46-Zl-17@gated-at.bofh.it> |
| In reply to | #1470108 |
Hi Jisheng, Looks good to me. But, you need to rebase it on latest devfreq.git because the related patch is already merged[1] for COMPILE_TEST. So, the merge conflict may happen. [1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rc&id=c2f9bf4e49c12a3d9fcbee2cd48c9f5d769d8cc8 If you resend it with rebase on devfreq.git, Feel free to add my reviewed-by tag: Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> On 2016년 08월 25일 21:06, Jisheng Zhang wrote: > Use tab rather than space to indent, and tab + two spaces to indent > help message. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > --- > drivers/devfreq/Kconfig | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index a5be56e..86d06ab 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -91,14 +91,14 @@ config ARM_EXYNOS_BUS_DEVFREQ > This does not yet operate with optimal voltages. > > config ARM_TEGRA_DEVFREQ > - tristate "Tegra DEVFREQ Driver" > - depends on ARCH_TEGRA_124_SOC > - select DEVFREQ_GOV_SIMPLE_ONDEMAND > - select PM_OPP > - help > - This adds the DEVFREQ driver for the Tegra family of SoCs. > - It reads ACTMON counters of memory controllers and adjusts the > - operating frequencies and voltages with OPP support. > + tristate "Tegra DEVFREQ Driver" > + depends on ARCH_TEGRA_124_SOC > + select DEVFREQ_GOV_SIMPLE_ONDEMAND > + select PM_OPP > + help > + This adds the DEVFREQ driver for the Tegra family of SoCs. > + It reads ACTMON counters of memory controllers and adjusts the > + operating frequencies and voltages with OPP support. > > source "drivers/devfreq/event/Kconfig" > > -- Best Regards, Chanwoo Choi
[toc] | [prev] | [next] | [standalone]
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2016-08-26 05:00 +0200 |
| Message-ID | <safx7-19S-1@gated-at.bofh.it> |
| In reply to | #1470108 |
Hi MyungJoo, Chanwoo, On Fri, 26 Aug 2016 02:42:05 +0000 MyungJoo Ham wrote: > > Hi Jisheng, > > > > Looks good to me. But, you need to rebase it > > on latest devfreq.git because the related patch > > is already merged[1] for COMPILE_TEST. > > So, the merge conflict may happen. > > > > [1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rc&id=c2f9bf4e49c12a3d9fcbee2cd48c9f5d769d8cc8 > > > > If you resend it with rebase on devfreq.git, > > Feel free to add my reviewed-by tag: > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > Don't worry. > > It is already rebased and queued up at > https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/log/?h=for-rc > thanks so much!
[toc] | [prev] | [next] | [standalone]
| From | MyungJoo Ham <myungjoo.ham@samsung.com> |
|---|---|
| Date | 2016-08-26 05:00 +0200 |
| Message-ID | <safx8-19S-3@gated-at.bofh.it> |
| In reply to | #1470108 |
[Multipart message — attachments visible in raw view] — view raw
> Hi Jisheng, > > Looks good to me. But, you need to rebase it > on latest devfreq.git because the related patch > is already merged[1] for COMPILE_TEST. > So, the merge conflict may happen. > > [1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rc&id=c2f9bf4e49c12a3d9fcbee2cd48c9f5d769d8cc8 > > If you resend it with rebase on devfreq.git, > Feel free to add my reviewed-by tag: > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Don't worry. It is already rebased and queued up at https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/log/?h=for-rc Cheers, MyungJoo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web