Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1558374 > unrolled thread

[PATCH 00/10] ARM: da850-lcdk: add SATA support

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/10] ARM: da850-lcdk: add SATA support Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
    [PATCH 06/10] sata: ahci_da850: implement a softreset quirk Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
      Re: [PATCH 06/10] sata: ahci_da850: implement a softreset quirk Tejun Heo <tj@kernel.org> - 2017-01-16 00:20 +0100
        Re: [PATCH 06/10] sata: ahci_da850: implement a softreset quirk Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-16 11:20 +0100
    [PATCH 01/10] ARM: davinci: add a clock lookup entry for the SATA clock Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
    [PATCH 09/10] ARM: dts: da850: add the SATA node Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
      Re: [PATCH 09/10] ARM: dts: da850: add the SATA node David Lechner <david@lechnology.com> - 2017-01-13 20:40 +0100
        Re: [PATCH 09/10] ARM: dts: da850: add the SATA node Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-16 11:10 +0100
    [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850 Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
      Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850 David Lechner <david@lechnology.com> - 2017-01-13 20:30 +0100
        Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850 Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-16 11:20 +0100
          Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850 Sekhar Nori <nsekhar@ti.com> - 2017-01-16 13:50 +0100
            Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850 Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-16 15:40 +0100
              Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850 David Lechner <david@lechnology.com> - 2017-01-16 19:50 +0100
    [PATCH 05/10] sata: ahci_da850: add device tree match table Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
    [PATCH 08/10] ARM: dts: da850: add pinmux settings for the SATA controller Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
    [PATCH 07/10] sata: ahci_da850: add support for the da850,clk_multiplier DT property Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
      Re: [PATCH 07/10] sata: ahci_da850: add support for the  da850,clk_multiplier DT property David Lechner <david@lechnology.com> - 2017-01-13 21:40 +0100
    [PATCH 04/10] sata: hardreset: retry if phys link is down Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 13:50 +0100
      Re: [PATCH 04/10] sata: hardreset: retry if phys link is down Tejun Heo <tj@kernel.org> - 2017-01-16 00:20 +0100
        Re: [PATCH 04/10] sata: hardreset: retry if phys link is down Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-16 13:30 +0100
    [PATCH 02/10] ARM: davinci_all_defconfig: enable SATA modules Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-13 14:50 +0100
    Re: [PATCH 00/10] ARM: da850-lcdk: add SATA support Sekhar Nori <nsekhar@ti.com> - 2017-01-13 15:40 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1559685 — Re: [PATCH 04/10] sata: hardreset: retry if phys link is down

2017-01-16 0:10 GMT+01:00 Tejun Heo <tj@kernel.org>:
> Hello,
>
> On Fri, Jan 13, 2017 at 01:37:58PM +0100, Bartosz Golaszewski wrote:
>> The sata core driver already retries to resume the link because some
>> controllers ignore writes to the SControl register.
>>
>> We have a use case with the da850 SATA controller where at PLL0
>> frequency of 456MHz (needed to properly service the LCD controller)
>> the chip becomes unstable and the hardreset operation is ignored the
>> first time 50% of times.
>>
>> Retrying just the resume operation doesn't work - we need to issue
>> the phy/wake reset again to make it work.
>>
>> If ata_phys_link_offline() returns true in sata_link_hardreset(),
>> retry a couple times before really giving up.
>
> I think it'd be better to implement the driver specific implementation
> rather than changing the behavior for everybody.
>
> Thanks.
>

For v2 I created a new ahci-locally exported function:
ahci_do_hardreset() that allows to retrieve the online state of the
link and used it in the da850-specific hardreset implementation.

Hope that'll be good.

Thanks,
Bartosz Golaszewski

[toc] | [prev] | [next] | [standalone]

#1558414 — [PATCH 02/10] ARM: davinci_all_defconfig: enable SATA modules

Add the da850-ahci driver to davinci defconfig.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 arch/arm/configs/davinci_all_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
index 8806754..a1b9c58 100644
--- a/arch/arm/configs/davinci_all_defconfig
+++ b/arch/arm/configs/davinci_all_defconfig
@@ -78,6 +78,8 @@ CONFIG_IDE=m
 CONFIG_BLK_DEV_PALMCHIP_BK3710=m
 CONFIG_SCSI=m
 CONFIG_BLK_DEV_SD=m
+CONFIG_ATA=m
+CONFIG_AHCI_DA850=m
 CONFIG_NETDEVICES=y
 CONFIG_NETCONSOLE=y
 CONFIG_TUN=m
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1558433

On Friday 13 January 2017 06:07 PM, Bartosz Golaszewski wrote:
> This series contains all the changes necessary to make SATA work on
> the da850-lcdk board.
> 
> The first patch adds a clock lookup entry required for the ahci core
> to retrieve a functional clock.
> 
> The second enables relevant config options for all davinci boards.
> 
> The third adds device tree bindings for the ahci_da850 driver.
> 
> The fourth adds a workaround for a SATA controller instability we
> detected after increasing the PLL0 frequency for proper LCD
> controller support.
> 
> Patches 5 through 7 extend the ahci_da850 driver - add DT support,
> un-hardcode the clock multiplier value and add a workaround for
> a quirk present on the da850 SATA controller.
> 
> Patches 8-10 add the device tree changes required to probe the driver.
> 
> I'm posting the series as a whole to give all reviewers the full
> picture and visibility of the changes required, if needed I can resend
> the patches separately.

I just tested this series on my LCDK board using a Western Digital SATA
HDD and it works great with some basic read / write tests. Thanks!

For the non-platform patches which I wont be queuing:

Tested-by: Sekhar Nori <nsekhar@ti.com>

I will take a look at the series closely next week.

Thanks,
Sekhar

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web