Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1559205 > unrolled thread

Bluetooth: always-true condition in dtl1_confcheck

Started byNicolas Iooss <nicolas.iooss_linux@m4x.org>
First post2017-01-15 12:10 +0100
Last post2017-01-15 12:10 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  Bluetooth: always-true condition in dtl1_confcheck Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2017-01-15 12:10 +0100

#1559205 — Bluetooth: always-true condition in dtl1_confcheck

FromNicolas Iooss <nicolas.iooss_linux@m4x.org>
Date2017-01-15 12:10 +0100
SubjectBluetooth: always-true condition in dtl1_confcheck
Message-ID<sZQRc-1OP-13@gated-at.bofh.it>
Hello,

Since commit 00990e7ce0b0 ("pcmcia: use autoconfiguration feature for
ioports and iomem") function dtl1_confcheck() starts with the following
statements (in drivers/bluetooth/dtl1_cs.c):

    static int dtl1_confcheck(struct pcmcia_device *p_dev, void *priv_data)
    {
        if ((p_dev->resource[1]->end) || (p_dev->resource[1]->end < 8))
            return -ENODEV;

The condition in the if statement is always true and the compiler
reports an issue when building with -Wlogical-op. What was the condition
supposed to be?

Thanks,
Nicolas

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web