Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1559038 > unrolled thread

[PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition

Started byKartikey Singh <dr.kartikeynrc@gmail.com>
First post2017-01-14 19:20 +0100
Last post2017-01-14 19:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after  macro definition Kartikey Singh <dr.kartikeynrc@gmail.com> - 2017-01-14 19:20 +0100
    Re: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon  after macro definition Greg KH <gregkh@linuxfoundation.org> - 2017-01-14 19:40 +0100

#1559038 — [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition

FromKartikey Singh <dr.kartikeynrc@gmail.com>
Date2017-01-14 19:20 +0100
Subject[PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition
Message-ID<sZB5L-Kf-7@gated-at.bofh.it>
fixed a trailing semicolon after macro definition

Signed-off-by: Kartikey Singh <dr.kartikeynrc@gmail.com>
---
 drivers/staging/rtl8188eu/include/basic_types.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/drivers/staging/rtl8188eu/include/basic_types.h
index 69c4d49..cbd6f92 100644
--- a/drivers/staging/rtl8188eu/include/basic_types.h
+++ b/drivers/staging/rtl8188eu/include/basic_types.h
@@ -128,7 +128,7 @@ value to host byte ordering.*/
 		(						\
 		LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \
 		((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \
-		);
+		)
 
 #define SET_BITS_TO_LE_1BYTE(__pstart, __bitoffset, __bitlen, __val) \
 		*((u8 *)(__pstart)) = EF1BYTE			\
-- 
2.9.3

[toc] | [next] | [standalone]


#1559044 — Re: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-01-14 19:40 +0100
SubjectRe: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition
Message-ID<sZBp8-Qr-19@gated-at.bofh.it>
In reply to#1559038
On Sat, Jan 14, 2017 at 11:47:56PM +0530, Kartikey Singh wrote:
> fixed a trailing semicolon after macro definition
> 
> Signed-off-by: Kartikey Singh <dr.kartikeynrc@gmail.com>
> ---
>  drivers/staging/rtl8188eu/include/basic_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/drivers/staging/rtl8188eu/include/basic_types.h
> index 69c4d49..cbd6f92 100644
> --- a/drivers/staging/rtl8188eu/include/basic_types.h
> +++ b/drivers/staging/rtl8188eu/include/basic_types.h
> @@ -128,7 +128,7 @@ value to host byte ordering.*/
>  		(						\
>  		LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \
>  		((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \
> -		);
> +		)

This macro, and others in this file, are also never used, can you just
remove them too?

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web