Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1556831 > unrolled thread
| Started by | "Gustavo A. R. Silva" <silvagustavosilva@gmail.com> |
|---|---|
| First post | 2017-01-11 19:50 +0100 |
| Last post | 2017-01-12 01:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] drivers: block: Remove unnecessary cast "Gustavo A. R. Silva" <silvagustavosilva@gmail.com> - 2017-01-11 19:50 +0100
Re: [PATCH] drivers: block: Remove unnecessary cast Greg KH <gregkh@linuxfoundation.org> - 2017-01-11 21:20 +0100
Re: [PATCH] drivers: block: Remove unnecessary cast "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-01-12 01:10 +0100
| From | "Gustavo A. R. Silva" <silvagustavosilva@gmail.com> |
|---|---|
| Date | 2017-01-11 19:50 +0100 |
| Subject | [PATCH] drivers: block: Remove unnecessary cast |
| Message-ID | <sYw89-1XP-9@gated-at.bofh.it> |
This issue was detected using Coccinelle and the following semantic patch: @@ expression * e; expression arg1, arg2; type T; @@ - e = (T *) + e = kmalloc(arg1, arg2); Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/block/cciss_scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c index a18de9d..98ba8fc 100644 --- a/drivers/block/cciss_scsi.c +++ b/drivers/block/cciss_scsi.c @@ -647,8 +647,7 @@ cciss_scsi_setup(ctlr_info_t *h) struct cciss_scsi_adapter_data_t * shba; ccissscsi[h->ctlr].ndevices = 0; - shba = (struct cciss_scsi_adapter_data_t *) - kmalloc(sizeof(*shba), GFP_KERNEL); + shba = kmalloc(sizeof(*shba), GFP_KERNEL); if (shba == NULL) return; shba->scsi_host = NULL; -- 2.5.0
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-01-11 21:20 +0100 |
| Message-ID | <sYxxg-2Xz-13@gated-at.bofh.it> |
| In reply to | #1556831 |
On Wed, Jan 11, 2017 at 12:41:05PM -0600, Gustavo A. R. Silva wrote: > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression * e; > expression arg1, arg2; > type T; > @@ > > - e = (T *) > + e = > kmalloc(arg1, arg2); > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/block/cciss_scsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Why send this to me?
[toc] | [prev] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-01-12 01:10 +0100 |
| Message-ID | <sYB7P-5mx-1@gated-at.bofh.it> |
| In reply to | #1556885 |
Quoting Greg KH <gregkh@linuxfoundation.org>: > On Wed, Jan 11, 2017 at 12:41:05PM -0600, Gustavo A. R. Silva wrote: >> This issue was detected using Coccinelle and the following semantic patch: >> >> @@ >> expression * e; >> expression arg1, arg2; >> type T; >> @@ >> >> - e = (T *) >> + e = >> kmalloc(arg1, arg2); >> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> --- >> drivers/block/cciss_scsi.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > > Why send this to me? Oops... Sorry... I was also working with the Staging tree, so it seems your e-mail address got in the middle at some point. -- Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web