Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550831 > unrolled thread

[PATCH v4] drm: add fourcc codes for 16bit R and RG

Started byRainer Hochecker <fernetmenta@kodi.tv>
First post2017-01-04 15:00 +0100
Last post2017-01-04 19:30 +0100
Articles 10 — 5 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v4] drm: add fourcc codes for 16bit R and RG Rainer Hochecker <fernetmenta@kodi.tv> - 2017-01-04 15:00 +0100
    Re: [PATCH v4] drm: add fourcc codes for 16bit R and RG Eric Engestrom <eric.engestrom@imgtec.com> - 2017-01-04 19:10 +0100
      Re: [PATCH v5] drm: add fourcc codes for 16bit R and RG Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-01-04 19:30 +0100
        [PATCH v6] drm: add fourcc codes for 16bit R and RG Rainer Hochecker <fernetmenta@kodi.tv> - 2017-01-04 19:40 +0100
          Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-01-05 12:40 +0100
            Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG Christian König <deathsimple@vodafone.de> - 2017-01-05 14:50 +0100
              Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-01-11 16:10 +0100
                Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG Ben Widawsky <ben@bwidawsk.net> - 2017-01-11 17:00 +0100
                  Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-01-11 17:50 +0100
      [PATCH v5] drm: add fourcc codes for 16bit R and RG Rainer Hochecker <fernetmenta@kodi.tv> - 2017-01-04 19:30 +0100

#1550831 — [PATCH v4] drm: add fourcc codes for 16bit R and RG

FromRainer Hochecker <fernetmenta@kodi.tv>
Date2017-01-04 15:00 +0100
Subject[PATCH v4] drm: add fourcc codes for 16bit R and RG
Message-ID<sVUgF-5oR-35@gated-at.bofh.it>
From: Rainer Hochecker <fernetmenta@online.de>

Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
---
 include/uapi/drm/drm_fourcc.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index a5890bf..4d65fb6 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -41,10 +41,17 @@ extern "C" {
 /* 8 bpp Red */
 #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
 
+/* 16 bpp Red */
+#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R */
+
 /* 16 bpp RG */
 #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
 #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
 
+/* 32 bpp RG */
+#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] G:R 16:16 little endian */
+#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
+
 /* 8 bpp RGB */
 #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
 #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
-- 
2.9.3

[toc] | [next] | [standalone]

#1551051

FromEric Engestrom <eric.engestrom@imgtec.com>
Date2017-01-04 19:10 +0100
Message-ID<sVYaC-8bd-29@gated-at.bofh.it>
In reply to#1550831
On Wednesday, 2017-01-04 14:50:02 +0100, Rainer Hochecker wrote:
> From: Rainer Hochecker <fernetmenta@online.de>
> 
> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
> ---
>  include/uapi/drm/drm_fourcc.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index a5890bf..4d65fb6 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -41,10 +41,17 @@ extern "C" {
>  /* 8 bpp Red */
>  #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>  
> +/* 16 bpp Red */
> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R */
> +
>  /* 16 bpp RG */
>  #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>  #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>  
> +/* 32 bpp RG */
> +#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] G:R 16:16 little endian */

Comment above is still wrong: s/G:R/R:G/ :)

> +#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
> +
>  /* 8 bpp RGB */
>  #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>  #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
> -- 
> 2.9.3
>

[toc] | [prev] | [next] | [standalone]

#1551082 — Re: [PATCH v5] drm: add fourcc codes for 16bit R and RG

FromVille Syrjälä <ville.syrjala@linux.intel.com>
Date2017-01-04 19:30 +0100
SubjectRe: [PATCH v5] drm: add fourcc codes for 16bit R and RG
Message-ID<sVYtY-8k8-39@gated-at.bofh.it>
In reply to#1551051
On Wed, Jan 04, 2017 at 07:24:09PM +0100, Rainer Hochecker wrote:
> From: Rainer Hochecker <fernetmenta@online.de>
> 
> Thanks for bearing with me. My ml skills have greatly improved now :)
> 
> v5 of patch:
> 
> This adds fourcc codes for 16bit planes required for DRM buffer
> export to mesa.
> 
> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
> ---
>  include/uapi/drm/drm_fourcc.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index a5890bf..e7f6bcd 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -41,10 +41,17 @@ extern "C" {
>  /* 8 bpp Red */
>  #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>  
> +/* 16 bpp Red */
> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R */

little endian

> +
>  /* 16 bpp RG */
>  #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>  #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>  
> +/* 32 bpp RG */
> +#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
> +#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
> +
>  /* 8 bpp RGB */
>  #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>  #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
> -- 
> 2.9.3

-- 
Ville Syrjälä
Intel OTC

[toc] | [prev] | [next] | [standalone]

#1551087 — [PATCH v6] drm: add fourcc codes for 16bit R and RG

FromRainer Hochecker <fernetmenta@kodi.tv>
Date2017-01-04 19:40 +0100
Subject[PATCH v6] drm: add fourcc codes for 16bit R and RG
Message-ID<sVYDE-8nf-9@gated-at.bofh.it>
In reply to#1551082
From: Rainer Hochecker <fernetmenta@online.de>

This adds fourcc codes for 16bit planes required for DRM buffer
export to mesa.

Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
---
 include/uapi/drm/drm_fourcc.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index a5890bf..d230e58 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -41,10 +41,17 @@ extern "C" {
 /* 8 bpp Red */
 #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
 
+/* 16 bpp Red */
+#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */
+
 /* 16 bpp RG */
 #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
 #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
 
+/* 32 bpp RG */
+#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
+#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
+
 /* 8 bpp RGB */
 #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
 #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1551909 — Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG

FromVille Syrjälä <ville.syrjala@linux.intel.com>
Date2017-01-05 12:40 +0100
SubjectRe: [PATCH v6] drm: add fourcc codes for 16bit R and RG
Message-ID<sWeyJ-2mW-13@gated-at.bofh.it>
In reply to#1551087
On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote:
> From: Rainer Hochecker <fernetmenta@online.de>
> 
> This adds fourcc codes for 16bit planes required for DRM buffer
> export to mesa.
> 
> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  include/uapi/drm/drm_fourcc.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index a5890bf..d230e58 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -41,10 +41,17 @@ extern "C" {
>  /* 8 bpp Red */
>  #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>  
> +/* 16 bpp Red */
> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */
> +
>  /* 16 bpp RG */
>  #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>  #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>  
> +/* 32 bpp RG */
> +#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
> +#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
> +
>  /* 8 bpp RGB */
>  #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>  #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
> -- 
> 2.9.3

-- 
Ville Syrjälä
Intel OTC

[toc] | [prev] | [next] | [standalone]

#1551992 — Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG

FromChristian König <deathsimple@vodafone.de>
Date2017-01-05 14:50 +0100
SubjectRe: [PATCH v6] drm: add fourcc codes for 16bit R and RG
Message-ID<sWgAy-3JT-31@gated-at.bofh.it>
In reply to#1551909
Am 05.01.2017 um 12:37 schrieb Ville Syrjälä:
> On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote:
>> From: Rainer Hochecker <fernetmenta@online.de>
>>
>> This adds fourcc codes for 16bit planes required for DRM buffer
>> export to mesa.
>>
>> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Good to see some work landing on that part, patch is Acked-by: Christian 
König <christian.koenig@amd.com>.

>
>> ---
>>   include/uapi/drm/drm_fourcc.h | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> index a5890bf..d230e58 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -41,10 +41,17 @@ extern "C" {
>>   /* 8 bpp Red */
>>   #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>>   
>> +/* 16 bpp Red */
>> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */
>> +
>>   /* 16 bpp RG */
>>   #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>>   #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>>   
>> +/* 32 bpp RG */
>> +#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
>> +#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
>> +
>>   /* 8 bpp RGB */
>>   #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>>   #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
>> -- 
>> 2.9.3

[toc] | [prev] | [next] | [standalone]

#1556591 — Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG

FromVille Syrjälä <ville.syrjala@linux.intel.com>
Date2017-01-11 16:10 +0100
SubjectRe: [PATCH v6] drm: add fourcc codes for 16bit R and RG
Message-ID<sYsHg-8rV-73@gated-at.bofh.it>
In reply to#1551992
On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote:
> Am 05.01.2017 um 12:37 schrieb Ville Syrjälä:
> > On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote:
> >> From: Rainer Hochecker <fernetmenta@online.de>
> >>
> >> This adds fourcc codes for 16bit planes required for DRM buffer
> >> export to mesa.
> >>
> >> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Good to see some work landing on that part, patch is Acked-by: Christian 
> König <christian.koenig@amd.com>.

Has the userspace side of this been reviewed already?

/me wonders if it's safe to push this...

> 
> >
> >> ---
> >>   include/uapi/drm/drm_fourcc.h | 7 +++++++
> >>   1 file changed, 7 insertions(+)
> >>
> >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> >> index a5890bf..d230e58 100644
> >> --- a/include/uapi/drm/drm_fourcc.h
> >> +++ b/include/uapi/drm/drm_fourcc.h
> >> @@ -41,10 +41,17 @@ extern "C" {
> >>   /* 8 bpp Red */
> >>   #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
> >>   
> >> +/* 16 bpp Red */
> >> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */
> >> +
> >>   /* 16 bpp RG */
> >>   #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
> >>   #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
> >>   
> >> +/* 32 bpp RG */
> >> +#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
> >> +#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
> >> +
> >>   /* 8 bpp RGB */
> >>   #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
> >>   #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
> >> -- 
> >> 2.9.3
> 

-- 
Ville Syrjälä
Intel OTC

[toc] | [prev] | [next] | [standalone]

#1556659 — Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG

FromBen Widawsky <ben@bwidawsk.net>
Date2017-01-11 17:00 +0100
SubjectRe: [PATCH v6] drm: add fourcc codes for 16bit R and RG
Message-ID<sYttF-id-37@gated-at.bofh.it>
In reply to#1556591
On 17-01-11 17:05:04, Ville Syrjälä wrote:
>On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote:
>> Am 05.01.2017 um 12:37 schrieb Ville Syrjälä:
>> > On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote:
>> >> From: Rainer Hochecker <fernetmenta@online.de>
>> >>
>> >> This adds fourcc codes for 16bit planes required for DRM buffer
>> >> export to mesa.
>> >>
>> >> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
>> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Good to see some work landing on that part, patch is Acked-by: Christian
>> König <christian.koenig@amd.com>.
>
>Has the userspace side of this been reviewed already?
>
>/me wonders if it's safe to push this...
>

I acked the mesa side, and Rainer sent a version 2 which also looked fine to me.
Let me bump that thread...

>>
>> >
>> >> ---
>> >>   include/uapi/drm/drm_fourcc.h | 7 +++++++
>> >>   1 file changed, 7 insertions(+)
>> >>
>> >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> >> index a5890bf..d230e58 100644
>> >> --- a/include/uapi/drm/drm_fourcc.h
>> >> +++ b/include/uapi/drm/drm_fourcc.h
>> >> @@ -41,10 +41,17 @@ extern "C" {
>> >>   /* 8 bpp Red */
>> >>   #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>> >>
>> >> +/* 16 bpp Red */
>> >> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */
>> >> +
>> >>   /* 16 bpp RG */
>> >>   #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>> >>   #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>> >>
>> >> +/* 32 bpp RG */
>> >> +#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
>> >> +#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
>> >> +
>> >>   /* 8 bpp RGB */
>> >>   #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>> >>   #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
>> >> --
>> >> 2.9.3
>>
>
>-- 
>Ville Syrjälä
>Intel OTC

[toc] | [prev] | [next] | [standalone]

#1556708 — Re: [PATCH v6] drm: add fourcc codes for 16bit R and RG

FromVille Syrjälä <ville.syrjala@linux.intel.com>
Date2017-01-11 17:50 +0100
SubjectRe: [PATCH v6] drm: add fourcc codes for 16bit R and RG
Message-ID<sYug1-OR-17@gated-at.bofh.it>
In reply to#1556659
On Wed, Jan 11, 2017 at 07:44:05AM -0800, Ben Widawsky wrote:
> On 17-01-11 17:05:04, Ville Syrjälä wrote:
> >On Thu, Jan 05, 2017 at 02:45:37PM +0100, Christian König wrote:
> >> Am 05.01.2017 um 12:37 schrieb Ville Syrjälä:
> >> > On Wed, Jan 04, 2017 at 07:38:55PM +0100, Rainer Hochecker wrote:
> >> >> From: Rainer Hochecker <fernetmenta@online.de>
> >> >>
> >> >> This adds fourcc codes for 16bit planes required for DRM buffer
> >> >> export to mesa.
> >> >>
> >> >> Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
> >> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> Good to see some work landing on that part, patch is Acked-by: Christian
> >> König <christian.koenig@amd.com>.
> >
> >Has the userspace side of this been reviewed already?
> >
> >/me wonders if it's safe to push this...
> >
> 
> I acked the mesa side, and Rainer sent a version 2 which also looked fine to me.
> Let me bump that thread...

Thanks everyone. I've pushed this patch to drm-misc-next.

> 
> >>
> >> >
> >> >> ---
> >> >>   include/uapi/drm/drm_fourcc.h | 7 +++++++
> >> >>   1 file changed, 7 insertions(+)
> >> >>
> >> >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> >> >> index a5890bf..d230e58 100644
> >> >> --- a/include/uapi/drm/drm_fourcc.h
> >> >> +++ b/include/uapi/drm/drm_fourcc.h
> >> >> @@ -41,10 +41,17 @@ extern "C" {
> >> >>   /* 8 bpp Red */
> >> >>   #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
> >> >>
> >> >> +/* 16 bpp Red */
> >> >> +#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R little endian */
> >> >> +
> >> >>   /* 16 bpp RG */
> >> >>   #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
> >> >>   #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
> >> >>
> >> >> +/* 32 bpp RG */
> >> >> +#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
> >> >> +#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
> >> >> +
> >> >>   /* 8 bpp RGB */
> >> >>   #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
> >> >>   #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
> >> >> --
> >> >> 2.9.3
> >>
> >
> >-- 
> >Ville Syrjälä
> >Intel OTC

-- 
Ville Syrjälä
Intel OTC

[toc] | [prev] | [next] | [standalone]

#1551083 — [PATCH v5] drm: add fourcc codes for 16bit R and RG

FromRainer Hochecker <fernetmenta@kodi.tv>
Date2017-01-04 19:30 +0100
Subject[PATCH v5] drm: add fourcc codes for 16bit R and RG
Message-ID<sVYtY-8k8-29@gated-at.bofh.it>
In reply to#1551051
From: Rainer Hochecker <fernetmenta@online.de>

Thanks for bearing with me. My ml skills have greatly improved now :)

v5 of patch:

This adds fourcc codes for 16bit planes required for DRM buffer
export to mesa.

Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
---
 include/uapi/drm/drm_fourcc.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index a5890bf..e7f6bcd 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -41,10 +41,17 @@ extern "C" {
 /* 8 bpp Red */
 #define DRM_FORMAT_R8		fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
 
+/* 16 bpp Red */
+#define DRM_FORMAT_R16		fourcc_code('R', '1', '6', ' ') /* [15:0] R */
+
 /* 16 bpp RG */
 #define DRM_FORMAT_RG88		fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
 #define DRM_FORMAT_GR88		fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
 
+/* 32 bpp RG */
+#define DRM_FORMAT_RG1616	fourcc_code('R', 'G', '3', '2') /* [31:0] R:G 16:16 little endian */
+#define DRM_FORMAT_GR1616	fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */
+
 /* 8 bpp RGB */
 #define DRM_FORMAT_RGB332	fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
 #define DRM_FORMAT_BGR233	fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
-- 
2.9.3

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web