Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556471 > unrolled thread

Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-01-11 14:10 +0100

#1556471 — Re: [PATCH] video: fbdev: maxinefb: add __initdata to maxinefb_fix

Hi,

On Sunday, January 01, 2017 10:06:17 PM Bhumika Goyal wrote:
> The object maxinefb_fix of type fb_fix_screeninfo is never referenced
> after initialization by maxinefb_init. In the init function, the object
> and one of its fields is only stored into another variable. So, the
> object and its fields are never referenced anywhere after initialization
> and therefore add __initdata to its declaration.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Thanks, queued fpr 4.11.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/maxinefb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
> index 5cf52d3..cab7333 100644
> --- a/drivers/video/fbdev/maxinefb.c
> +++ b/drivers/video/fbdev/maxinefb.c
> @@ -51,7 +51,7 @@
>  	.vmode =	FB_VMODE_NONINTERLACED,
>  };
>  
> -static struct fb_fix_screeninfo maxinefb_fix = {
> +static struct fb_fix_screeninfo maxinefb_fix __initdata = {
>  	.id =		"Maxine",
>  	.smem_len =	(1024*768),
>  	.type =		FB_TYPE_PACKED_PIXELS,

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web