Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1556417 > unrolled thread

Re: [PATCH] ASoC: rt5651: use msleep for large delays

Started byJoe Perches <joe@perches.com>
First post2017-01-11 13:00 +0100
Last post2017-01-11 13:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] ASoC: rt5651: use msleep for large delays Joe Perches <joe@perches.com> - 2017-01-11 13:00 +0100
    Re: [PATCH] ASoC: rt5651: use msleep for large delays Nicholas Mc Guire <der.herr@hofr.at> - 2017-01-11 13:10 +0100

#1556417 — Re: [PATCH] ASoC: rt5651: use msleep for large delays

FromJoe Perches <joe@perches.com>
Date2017-01-11 13:00 +0100
SubjectRe: [PATCH] ASoC: rt5651: use msleep for large delays
Message-ID<sYpJn-6v8-7@gated-at.bofh.it>
On Wed, 2017-01-11 at 12:49 +0100, Nicholas Mc Guire wrote:
> ulseep_range() uses hrtimers and provides no advantage over msleep()
> for larger delays. Fix up the 75/85ms delays here to use msleep() and
> reduce the load on the hrtimer subsystem.

If this is useful, why not convert all the large value
usleep_range uses in sound/soc/ ?

[toc] | [next] | [standalone]


#1556433

FromNicholas Mc Guire <der.herr@hofr.at>
Date2017-01-11 13:10 +0100
Message-ID<sYpT4-6Ny-43@gated-at.bofh.it>
In reply to#1556417
On Wed, Jan 11, 2017 at 03:55:49AM -0800, Joe Perches wrote:
> On Wed, 2017-01-11 at 12:49 +0100, Nicholas Mc Guire wrote:
> > ulseep_range() uses hrtimers and provides no advantage over msleep()
> > for larger delays. Fix up the 75/85ms delays here to use msleep() and
> > reduce the load on the hrtimer subsystem.
> 
> If this is useful, why not convert all the large value
> usleep_range uses in sound/soc/ ?
>
thats what Im currently doing - just that it cant be done fully
automatic as it may be justified in some cases - so it needs a 
case-by-case review. 

And its not only in sound/soc/ its quite a bit in drivers/ as
well.

thx!
hofrat 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web