Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550507 > unrolled thread

[PATCH 1/2] gpio: davinci: Remove redundant members davinci_gpio_controller stuct

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] gpio: davinci: Remove redundant members davinci_gpio_controller stuct Keerthy <j-keerthy@ti.com> - 2017-01-04 09:30 +0100
    Re: [PATCH 1/2] gpio: davinci: Remove redundant members  davinci_gpio_controller stuct Linus Walleij <linus.walleij@linaro.org> - 2017-01-11 12:10 +0100

#1550507 — [PATCH 1/2] gpio: davinci: Remove redundant members davinci_gpio_controller stuct

davinci_gpio_controller struct has set_data, in_data, clr_data
members that are assigned and never used.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/gpio/gpio-davinci.c                | 3 ---
 include/linux/platform_data/gpio-davinci.h | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 9191056..163f81e 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -266,9 +266,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
 		if (!regs)
 			return -ENXIO;
 		chips[i].regs = regs;
-		chips[i].set_data = &regs->set_data;
-		chips[i].clr_data = &regs->clr_data;
-		chips[i].in_data = &regs->in_data;
 
 		gpiochip_add_data(&chips[i].chip, &chips[i]);
 	}
diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h
index 6ace3fd..44ca530 100644
--- a/include/linux/platform_data/gpio-davinci.h
+++ b/include/linux/platform_data/gpio-davinci.h
@@ -33,9 +33,6 @@ struct davinci_gpio_controller {
 	/* Serialize access to GPIO registers */
 	spinlock_t		lock;
 	void __iomem		*regs;
-	void __iomem		*set_data;
-	void __iomem		*clr_data;
-	void __iomem		*in_data;
 	int			gpio_unbanked;
 	unsigned		gpio_irq;
 };
-- 
1.9.1

[toc] | [next] | [standalone]

#1556398 — Re: [PATCH 1/2] gpio: davinci: Remove redundant members davinci_gpio_controller stuct

On Wed, Jan 4, 2017 at 9:26 AM, Keerthy <j-keerthy@ti.com> wrote:

> davinci_gpio_controller struct has set_data, in_data, clr_data
> members that are assigned and never used.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>

Nice catch!

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web